On Thu, Mar 11, 2010 at 4:04 PM, Dan McGee <dpmcgee@gmail.com> wrote:
On Thu, Mar 11, 2010 at 4:01 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
--- cron-jobs/adjust-permissions | 10 ++++---- cron-jobs/create-filelists | 24 ++++++++++---------- cron-jobs/devlist-mailer | 10 ++++---- cron-jobs/ftpdir-cleanup | 2 +- cron-jobs/sourceballs | 16 +++++++------- cron-jobs/sourceballs-cleanup | 6 ++-- db-community | 2 +- db-community-testing | 2 +- db-core | 2 +- db-extra | 2 +- db-functions | 20 +++++++++--------- db-move | 16 +++++++------- db-remove | 16 +++++++------- db-testing | 2 +- db-update | 44 +++++++++++++++++++------------------- misc-scripts/ftpdir-cleanup | 46 ++++++++++++++++++++-------------------- misc-scripts/make-sourceball | 8 +++--- testing2community | 2 +- testing2community-any | 2 +- testing2community64 | 2 +- testing2core | 2 +- testing2core-any | 2 +- testing2core64 | 2 +- testing2extra | 2 +- testing2extra-any | 2 +- testing2extra64 | 2 +- testing2x | 6 ++-- 27 files changed, 126 insertions(+), 126 deletions(-)
-1? Did I miss something here in our coding standards? This seems excessive because I know: * Someone will check in code with the wrong format * Someone will add a $var to a string and forget to change the quotes * Someone will remove a $var from a string and forget to change the quotes
If $foobar vs. ${foobar} is next, oh boy...
-1 from me too. At the very least, double quotes should be the norm, single quotes the edge case