On Mon, Mar 14, 2011 at 8:48 PM, Allan McRae <allan@archlinux.org> wrote:
On 15/03/11 08:50, Rémy Oudompheng wrote:
On 2011/3/13 Rémy Oudompheng<remyoudompheng@gmail.com> wrote:
Hello people,
namcap version 3.0.1 is now in testing. This is a quick bugfix followup release that corrects bugs FS#23258, FS#23259, FS#23260.
Sources are at the usual places ftp://ftp.archlinux.org/other/namcap/namcap-3.0.1.tar.gz http://projects.archlinux.org/namcap.git/tree/?id=3.0.1
Have fun with it and don't hesitate to report any other bugs or wrong behaviour.
Version 3.0.2 is released. It features two bug fixes : * crashes in non-English locales (reported by Pierre) * large amount of false positives in the extravars rules for multiline arrays (reported by Allan).
This appears to have gotten worse:
namcap-3.0.1:
find /var/abs/core -name PKGBUILD | xargs namcap | grep "Non standard variable" | wc -l 129
namcap-3.0.2:
find /var/abs/core -name PKGBUILD | xargs namcap | grep "Non standard variable" | wc -l 710
It turns out every PKGBUILD is giving the following warnings:
namcap /var/abs/core/tar/PKGBUILD PKGBUILD (tar) W: Non standard variable 'rootdelay' doesn't start with an underscore PKGBUILD (tar) W: Non standard variable 'init' doesn't start with an underscore PKGBUILD (tar) W: Non standard variable 'udevd_running' doesn't start with an underscore PKGBUILD (tar) W: Non standard variable 'root' doesn't start with an underscore
Note the original commit message on this rule, very telling...anyway, I have a hopefully real fix for this mess on the way. I didn't even realize I wasn't running the latest rule from my devel branch, but what I've coded up is hopefully a lot more correct fix for the problem. commit c35379b4e1ba2721c20ae1735f5e8028baa9a942 Author: Jesse Young <jesse.young@gmail.com> Date: Tue Jul 24 13:38:04 2007 -0700 Add extravars rule but don't enable it by default. It still needs tweaking to get it to work properly. Things inside the build function can trigger it, for example. Signed-off-by: Jason Chu <jason@archlinux.org>