On 2011/3/13 Dan McGee <dpmcgee@gmail.com> wrote:
On Sun, Mar 13, 2011 at 8:30 AM, Allan McRae <allan@archlinux.org> wrote:
Looks good to me. I just ran it on a whole heap of PKGBUILDs and packages and nothing looked too wrong.
There is a bunch of false positives in the form of: W: Non standard variable 'foo' doesn't start with an underscore e.g. the perl PKGBUILD. I'm not sure if they are new or not.
I'm not so sure these are false positives- the rule just didn't run at all before, if I remember one of Rémy's emails, so you never saw this trigger a warning.
By the way if someone could explain the exact purpose of the "CARCH" rule, which does not work currently with the various syntaxes ($CARCH, ${CARCH}, "$CARCH"), I could try to fix it, but I really don't know its purpose. -- Rémy.