On Tue, Sep 22, 2009 at 11:51 AM, Thomas Bächler <thomas@archlinux.org> wrote:
Aaron Griffin schrieb:
This would work, assuming all the error handling is in place (i.e. ensure editor can be called, if undefined, use vi by default, ensure return value before committing, ensure non-zero length commit message).
What about the simple way:
if [ -z "$1" ]; then echo "Please ..." exit 1 done
This way, the editor code path could be removed again.
If someone wants a more complex commit message, take Francois' aproach and svn commit manually before calling XXXpkg.
A simple commit message can be given on the command line and doesn't need a separate editor.
Hmm that seems ok, but we should probably try and prevent things like: $ extrapkg " " via: ----- msg="$(echo $@)" if [ -z "$msg" ]; then echo "wtfdude?"; exit 1; fi sv commit -m "upgpkg: blah -> blah $msg" -----