[arch-dev-public] fixing the dependency cycle in Core, part 1: coreutils
Hi! I've attached a patch that removes unneeded dependency on coreutils from some packages. It also modifies install.proto to not endorse bad practice of /bin/true usage. Please review and signoff. -- Roman Kyrylych (Роман Кирилич)
btw, whats the purpose of using depmod in verbose mode and redirecting all output to /dev/null? # arg 1: the new package version @@ -12,13 +11,6 @@ post_upgrade() { KERNEL_VERSION='2.6.23-ARCH' depmod -v $KERNEL_VERSION > /dev/null 2>&1 ^^^ ^^^^^^^^^^^^^^^^ Jürgen
Am Freitag, 23. November 2007 schrieb Jürgen Hötzel:
btw, whats the purpose of using depmod in verbose mode and redirecting all output to /dev/null?
# arg 1: the new package version @@ -12,13 +11,6 @@ post_upgrade() { KERNEL_VERSION='2.6.23-ARCH' depmod -v $KERNEL_VERSION > /dev/null 2>&1 ^^^ ^^^^^^^^^^^^^^^^
Jürgen
_______________________________________________ arch-dev-public mailing list arch-dev-public@archlinux.org http://archlinux.org/mailman/listinfo/arch-dev-public
that is not verbose mode it's giving depmod the version of the kernel -- Tobias Powalowski Archlinux Developer & Package Maintainer (tpowa) http://www.archlinux.org tpowa@archlinux.org
On Fri, Nov 23, 2007 at 12:25:04PM +0100, Tobias Powalowski wrote:
Am Freitag, 23. November 2007 schrieb Jürgen Hötzel:
btw, whats the purpose of using depmod in verbose mode and redirecting all output to /dev/null?
# arg 1: the new package version @@ -12,13 +11,6 @@ post_upgrade() { KERNEL_VERSION='2.6.23-ARCH' depmod -v $KERNEL_VERSION > /dev/null 2>&1 ^^^ ^^^^^^^^^^^^^^^^
Jürgen
_______________________________________________ arch-dev-public mailing list arch-dev-public@archlinux.org http://archlinux.org/mailman/listinfo/arch-dev-public
that is not verbose mode it's giving depmod the version of the kernel
verbose isn't explained in the manpage [-v] is the verbose option: depmod $KERNEL_VERSION works. Jürgen
On Nov 23, 2007 6:36 AM, Jürgen Hötzel <juergen@hoetzel.info> wrote:
On Fri, Nov 23, 2007 at 12:25:04PM +0100, Tobias Powalowski wrote:
that is not verbose mode it's giving depmod the version of the kernel
verbose isn't explained in the manpage [-v] is the verbose option:
depmod $KERNEL_VERSION
works.
Jürgen
From the man page:
SYNOPSIS depmod [-b basedir] [-e] [-F System.map] [-n] [-v] [version] [-A ] depmod [-e] [-FSystem.map] [-n] [-v] [version] [filename ...] -------------------- Man that's confusing argument placement. Notice how [-v] [version] are two separate arguments, not [-v version]. This implies that [-v] has nothing to do with [version], and that Jurgen is right.
2007/11/23, Travis Willard <travis@archlinux.org>:
On Nov 23, 2007 6:36 AM, Jürgen Hötzel <juergen@hoetzel.info> wrote:
On Fri, Nov 23, 2007 at 12:25:04PM +0100, Tobias Powalowski wrote:
that is not verbose mode it's giving depmod the version of the kernel
verbose isn't explained in the manpage [-v] is the verbose option:
depmod $KERNEL_VERSION
works.
Jürgen
From the man page:
SYNOPSIS depmod [-b basedir] [-e] [-F System.map] [-n] [-v] [version] [-A ]
depmod [-e] [-FSystem.map] [-n] [-v] [version] [filename ...] --------------------
Man that's confusing argument placement. Notice how [-v] [version] are two separate arguments, not [-v version]. This implies that [-v] has nothing to do with [version], and that Jurgen is right.
That could be just a typo though. :-P Anyway - what's the difference if it works as it is now? /me shrugs -- Roman Kyrylych (Роман Кирилич)
2007/11/23, Roman Kyrylych <roman.kyrylych@gmail.com>:
Hi!
I've attached a patch that removes unneeded dependency on coreutils from some packages. It also modifies install.proto to not endorse bad practice of /bin/true usage. Please review and signoff.
Ok, it seems there are no objections, so I'm going to apply it today. FYI, it touches the following packages: db ipw3945 iwlwifi lilo ndiswrapper pam perl rt2500 rt2x00-cvs udev wlan-ng26 wpa_supplicant Only db and lilo get coreutils removed from depends array. Udev needs coreutils because of sbin/migrate_udev script. Other packages used /bin/true but didn't contain coreutils in depends. I think a pkgrel bump for db and lilo is needed so we get rid of cyclic depends before the ISO release. -- Roman Kyrylych (Роман Кирилич)
On Nov 24, 2007 4:19 AM, Roman Kyrylych <roman.kyrylych@gmail.com> wrote:
Other packages used /bin/true but didn't contain coreutils in depends.
if it does one of these things: post_install () { /bin/true } then you can get rid of it. pacman will be happy with an empty function too.
participants (5)
-
Aaron Griffin
-
Jürgen Hötzel
-
Roman Kyrylych
-
Tobias Powalowski
-
Travis Willard