[arch-dev-public] [PATCH 4/7] Remove testing2* scripts
--- testing2community | 13 ----------- testing2community-any | 13 ----------- testing2community64 | 13 ----------- testing2core | 11 --------- testing2core-any | 13 ----------- testing2core64 | 13 ----------- testing2extra | 13 ----------- testing2extra-any | 13 ----------- testing2extra64 | 13 ----------- testing2x | 57 ------------------------------------------------- testing2x64 | 1 - 11 files changed, 0 insertions(+), 173 deletions(-) delete mode 100755 testing2community delete mode 100755 testing2community-any delete mode 100755 testing2community64 delete mode 100755 testing2core delete mode 100755 testing2core-any delete mode 100755 testing2core64 delete mode 100755 testing2extra delete mode 100755 testing2extra-any delete mode 100755 testing2extra64 delete mode 100755 testing2x delete mode 120000 testing2x64 diff --git a/testing2community b/testing2community deleted file mode 100755 index f87c927..0000000 --- a/testing2community +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/bash - -if [ $# -le 0 ]; then - echo "usage: $(basename 0) <packagename> [<packagename> [<packagename ...]]" - exit 0 -fi - -for pkg in $@; do - echo "==> Moving package '$pkg'" - $(dirname $0)/db-move "$pkg" 'community-testing' 'community' 'i686' -done - -# vim: set ts=4 sw=4 noet ft=sh: diff --git a/testing2community-any b/testing2community-any deleted file mode 100755 index c9540f7..0000000 --- a/testing2community-any +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/bash - -if [ $# -le 0 ]; then - echo "usage: $(basename 0) <packagename> [<packagename> [<packagename ...]]" - exit 0 -fi - -for pkg in $@; do - echo "==> Moving package '$pkg'" - $(dirname $0)/db-move "$pkg" 'community-testing' 'community' 'any' -done - -# vim: set ts=4 sw=4 noet ft=sh: diff --git a/testing2community64 b/testing2community64 deleted file mode 100755 index c808b3f..0000000 --- a/testing2community64 +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/bash - -if [ $# -le 0 ]; then - echo "usage: $(basename 0) <packagename> [<packagename> [<packagename ...]]" - exit 0 -fi - -for pkg in $@; do - echo "==> Moving package '$pkg'" - $(dirname $0)/db-move "$pkg" 'community-testing' 'community' 'x86_64' -done - -# vim: set ts=4 sw=4 noet ft=sh: diff --git a/testing2core b/testing2core deleted file mode 100755 index 4c53d34..0000000 --- a/testing2core +++ /dev/null @@ -1,11 +0,0 @@ -#!/bin/bash - -if [ $# -le 0 ]; then - echo "usage: $(basename 0) <packagename> [<packagename> [<packagename ...]]" - exit 0 -fi - -for pkg in $@; do - echo "==> Moving package '$pkg'" - $(dirname $0)/db-move "$pkg" 'testing' 'core' 'i686' -done diff --git a/testing2core-any b/testing2core-any deleted file mode 100755 index 56f0753..0000000 --- a/testing2core-any +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/bash - -if [ $# -le 0 ]; then - echo "usage: $(basename 0) <packagename> [<packagename> [<packagename ...]]" - exit 0 -fi - -for pkg in $@; do - echo "==> Moving package '$pkg'" - $(dirname $0)/db-move "$pkg" 'testing' 'core' 'any' -done - -# vim: set ts=4 sw=4 noet ft=sh: diff --git a/testing2core64 b/testing2core64 deleted file mode 100755 index c9420fe..0000000 --- a/testing2core64 +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/bash - -if [ $# -le 0 ]; then - echo "usage: $(basename 0) <packagename> [<packagename> [<packagename ...]]" - exit 0 -fi - -for pkg in $@; do - echo "==> Moving package '$pkg'" - $(dirname $0)/db-move "$pkg" 'testing' 'core' 'x86_64' -done - -# vim: set ts=4 sw=4 noet ft=sh: diff --git a/testing2extra b/testing2extra deleted file mode 100755 index 9b62788..0000000 --- a/testing2extra +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/bash - -if [ $# -le 0 ]; then - echo "usage: $(basename 0) <packagename> [<packagename> [<packagename ...]]" - exit 0 -fi - -for pkg in $@; do - echo "==> Moving package '$pkg'" - $(dirname $0)/db-move "$pkg" 'testing' 'extra' 'i686' -done - -# vim: set ts=4 sw=4 noet ft=sh: diff --git a/testing2extra-any b/testing2extra-any deleted file mode 100755 index 5bbee58..0000000 --- a/testing2extra-any +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/bash - -if [ $# -le 0 ]; then - echo "usage: $(basename 0) <packagename> [<packagename> [<packagename ...]]" - exit 0 -fi - -for pkg in $@; do - echo "==> Moving package '$pkg'" - $(dirname $0)/db-move "$pkg" 'testing' 'extra' 'any' -done - -# vim: set ts=4 sw=4 noet ft=sh: diff --git a/testing2extra64 b/testing2extra64 deleted file mode 100755 index 25d91f6..0000000 --- a/testing2extra64 +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/bash - -if [ $# -le 0 ]; then - echo "usage: $(basename 0) <packagename> [<packagename> [<packagename ...]]" - exit 0 -fi - -for pkg in $@; do - echo "==> Moving package '$pkg'" - $(dirname $0)/db-move "$pkg" 'testing' 'extra' 'x86_64' -done - -# vim: set ts=4 sw=4 noet ft=sh: diff --git a/testing2x b/testing2x deleted file mode 100755 index 3a60da2..0000000 --- a/testing2x +++ /dev/null @@ -1,57 +0,0 @@ -#!/bin/bash - -. "$(dirname $0)/db-functions" -. "$(dirname $0)/config" - -case "$0" in - *64) - _arch='x86_64' - ;; - *) - _arch='i686' - ;; -esac -WORKDIR="$TMPDIR/testing2x.$UID" - -cleanup() { - trap '' 0 2 - rm -rf "${WORKDIR}" - [ -n "$1" ] && exit $1 -} - -ctrl_c() { - echo 'Interrupted' >&2 - cleanup 0 -} - -trap ctrl_c 2 -trap cleanup 0 - -/bin/mkdir "${WORKDIR}" -cd "${WORKDIR}" -/usr/bin/svn checkout -N $SVNREPO checkout -cd checkout - -for pkg in $*; do - moved=0 - /usr/bin/svn up -q ${pkg} - if [ -f "${pkg}/repos/testing-${_arch}/${BUILDSCRIPT}" ]; then - for repo in core extra; do - if [ -f "${pkg}/repos/${repo}-${_arch}/${BUILDSCRIPT}" ]; then - echo "===> Moving package '${pkg}': testing-${_arch} -> ${repo}-${_arch}" - $(dirname $0)/db-move "${pkg}" "testing" "${repo}" "${_arch}" - moved=1 - break - fi - done - if [ ${moved} -eq 0 ]; then - echo "===> Warning: ${pkg} is only in testing-${_arch}, cannot determine where to move it" - fi - else - echo "===> Warning: ${pkg} is not in testing-${_arch}" - fi -done - -cleanup - -# vim: set ts=4 sw=4 noet ft=sh: diff --git a/testing2x64 b/testing2x64 deleted file mode 120000 index ff08aa7..0000000 --- a/testing2x64 +++ /dev/null @@ -1 +0,0 @@ -testing2x \ No newline at end of file -- 1.7.0.2 --
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit? Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important. -Dan
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively. --
On Thu, Mar 11, 2010 at 4:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively.
No they're not. My branch has text there: http://code.phraktured.net/cgit.cgi/dbscripts/log/?h=working See http://code.phraktured.net/cgit.cgi/dbscripts/commit/?h=working&id=d2a61d7e695b8c956897c42464f39dbbdb39fb5e
On 03/11/10 at 04:26pm, Aaron Griffin wrote:
On Thu, Mar 11, 2010 at 4:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively.
No they're not. My branch has text there: http://code.phraktured.net/cgit.cgi/dbscripts/log/?h=working
See http://code.phraktured.net/cgit.cgi/dbscripts/commit/?h=working&id=d2a61d7e695b8c956897c42464f39dbbdb39fb5e Oops... sorry about that. Looks like I missed a few notes. --
On Thu, Mar 11, 2010 at 4:29 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:26pm, Aaron Griffin wrote:
On Thu, Mar 11, 2010 at 4:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively.
No they're not. My branch has text there: http://code.phraktured.net/cgit.cgi/dbscripts/log/?h=working
See http://code.phraktured.net/cgit.cgi/dbscripts/commit/?h=working&id=d2a61d7e695b8c956897c42464f39dbbdb39fb5e Oops... sorry about that. Looks like I missed a few notes.
If you added my git repo as a remote and cherry-picked them in, not only would the full commit messages be preserved, but authorship info too
On 03/11/10 at 04:33pm, Aaron Griffin wrote:
On Thu, Mar 11, 2010 at 4:29 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:26pm, Aaron Griffin wrote:
On Thu, Mar 11, 2010 at 4:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively.
No they're not. My branch has text there: http://code.phraktured.net/cgit.cgi/dbscripts/log/?h=working
See http://code.phraktured.net/cgit.cgi/dbscripts/commit/?h=working&id=d2a61d7e695b8c956897c42464f39dbbdb39fb5e Oops... sorry about that. Looks like I missed a few notes.
If you added my git repo as a remote and cherry-picked them in, not only would the full commit messages be preserved, but authorship info too Learning experience! Still working on learning how much git can do... --
On Thu, Mar 11, 2010 at 4:40 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:33pm, Aaron Griffin wrote:
On Thu, Mar 11, 2010 at 4:29 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:26pm, Aaron Griffin wrote:
On Thu, Mar 11, 2010 at 4:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote: > ---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively.
No they're not. My branch has text there: http://code.phraktured.net/cgit.cgi/dbscripts/log/?h=working
See http://code.phraktured.net/cgit.cgi/dbscripts/commit/?h=working&id=d2a61d7e695b8c956897c42464f39dbbdb39fb5e Oops... sorry about that. Looks like I missed a few notes.
If you added my git repo as a remote and cherry-picked them in, not only would the full commit messages be preserved, but authorship info too Learning experience! Still working on learning how much git can do...
I updated my branch against master, and had to re-jigger the dbmove patch: http://code.phraktured.net/cgit.cgi/dbscripts/log/?h=working If you want me to push it to master, I can from here. I am absolutely NOT confident with the cleanup script changes. Be warned
On Thu, Mar 11, 2010 at 5:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively. --
What would be the new command to move packages out of testing?
On 03/11/10 at 06:00pm, Eric Bélanger wrote:
On Thu, Mar 11, 2010 at 5:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively. --
What would be the new command to move packages out of testing db-move testing {extra,core,community} <arch> --
On Thu, Mar 11, 2010 at 5:00 PM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively. --
What would be the new command to move packages out of testing?
db-move has always been the workhorse here. db-move just did the extra steps of allowing multiple packages specified AND figuring out the target repo. This patch covers the first case, but not the later
On Thu, Mar 11, 2010 at 6:07 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:00 PM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively. --
What would be the new command to move packages out of testing?
db-move has always been the workhorse here. db-move just did the extra steps of allowing multiple packages specified AND figuring out the target repo.
This patch covers the first case, but not the later
Personnally, I would prefer keeping the testing2* scripts. They are more convenient (especially with tab completion) than using db-move directly with all its arguments.
On Thu, Mar 11, 2010 at 5:15 PM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 6:07 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:00 PM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote:
---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively. --
What would be the new command to move packages out of testing?
db-move has always been the workhorse here. db-move just did the extra steps of allowing multiple packages specified AND figuring out the target repo.
This patch covers the first case, but not the later
Personnally, I would prefer keeping the testing2* scripts. They are more convenient (especially with tab completion) than using db-move directly with all its arguments.
Do you have any sane way to simplify or combine all the testing2* scripts? There's a LOT of them
On Thu, Mar 11, 2010 at 6:21 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:15 PM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 6:07 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:00 PM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote:
On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227 <ghost1227@archlinux.us> wrote: > ---
Why do none of your patches have commit messages outside of the subject? Why are these getting removed? What is the new command? How, 6 months from now, am I going to make sense of this commit?
Sorry for sounding like I'm coming down with a hammer on your patches here, but I think this things are truly important.
-Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively. --
What would be the new command to move packages out of testing?
db-move has always been the workhorse here. db-move just did the extra steps of allowing multiple packages specified AND figuring out the target repo.
This patch covers the first case, but not the later
Personnally, I would prefer keeping the testing2* scripts. They are more convenient (especially with tab completion) than using db-move directly with all its arguments.
Do you have any sane way to simplify or combine all the testing2* scripts? There's a LOT of them
I can think about 2 methods right now: 1) We use the same method as with commitpkg, i.e. a single script with a bunch of symlinks. The script check how it has been called and set the target repo and arch accordingly. 2) We currently have 3 testing2extra* script (one for each arch). We could merge them all into a single smarter testing2extra script that would handle all arches. As we usually move both arches out of testing at the same time, that will be more efficient and will reduce by a factor of 3 the number of testing2* scripts. For cases where we only want to move one of the arch out of testing, we will need to use the db-move script directly. These 2 methods could be combined together as well.
On 12/03/10 11:37, Eric Bélanger wrote:
On Thu, Mar 11, 2010 at 6:21 PM, Aaron Griffin<aaronmgriffin@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:15 PM, Eric Bélanger<snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 6:07 PM, Aaron Griffin<aaronmgriffin@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:00 PM, Eric Bélanger<snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote:
On 03/11/10 at 04:06pm, Dan McGee wrote: > On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227<ghost1227@archlinux.us> wrote: >> --- > > Why do none of your patches have commit messages outside of the > subject? Why are these getting removed? What is the new command? How, > 6 months from now, am I going to make sense of this commit? > > Sorry for sounding like I'm coming down with a hammer on your patches > here, but I think this things are truly important. > > -Dan Not a problem, the commit messages (with the exception of the first) are taken directly from the commit messages on Aaron's dbscripts branch. The testing2* scripts are being removed because the db-move script can now handle multiple packages in any repo natively. --
What would be the new command to move packages out of testing?
db-move has always been the workhorse here. db-move just did the extra steps of allowing multiple packages specified AND figuring out the target repo.
This patch covers the first case, but not the later
Personnally, I would prefer keeping the testing2* scripts. They are more convenient (especially with tab completion) than using db-move directly with all its arguments.
Do you have any sane way to simplify or combine all the testing2* scripts? There's a LOT of them
I can think about 2 methods right now:
1) We use the same method as with commitpkg, i.e. a single script with a bunch of symlinks. The script check how it has been called and set the target repo and arch accordingly.
2) We currently have 3 testing2extra* script (one for each arch). We could merge them all into a single smarter testing2extra script that would handle all arches. As we usually move both arches out of testing at the same time, that will be more efficient and will reduce by a factor of 3 the number of testing2* scripts. For cases where we only want to move one of the arch out of testing, we will need to use the db-move script directly.
I think there is no need for any testing2* script apart from testing2x. Has anybody ever used the other scripts directly apart from moving a new package? db-move should take care of that rare case. Allan
On Thu, Mar 11, 2010 at 9:42 PM, Allan McRae <allan@archlinux.org> wrote:
On 12/03/10 11:37, Eric Bélanger wrote:
On Thu, Mar 11, 2010 at 6:21 PM, Aaron Griffin<aaronmgriffin@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:15 PM, Eric Bélanger<snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 6:07 PM, Aaron Griffin<aaronmgriffin@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:00 PM, Eric Bélanger<snowmaniscool@gmail.com> wrote:
On Thu, Mar 11, 2010 at 5:13 PM, Daniel J Griffiths (Ghost1227) <ghost1227@archlinux.us> wrote: > > On 03/11/10 at 04:06pm, Dan McGee wrote: >> >> On Thu, Mar 11, 2010 at 4:03 PM, Ghost1227<ghost1227@archlinux.us> >> wrote: >>> >>> --- >> >> Why do none of your patches have commit messages outside of the >> subject? Why are these getting removed? What is the new command? >> How, >> 6 months from now, am I going to make sense of this commit? >> >> Sorry for sounding like I'm coming down with a hammer on your >> patches >> here, but I think this things are truly important. >> >> -Dan > > Not a problem, the commit messages (with the exception of the first) > are taken directly from the commit messages on Aaron's dbscripts > branch. > The testing2* scripts are being removed because the db-move script > can now handle multiple packages in any repo natively. > -- >
What would be the new command to move packages out of testing?
db-move has always been the workhorse here. db-move just did the extra steps of allowing multiple packages specified AND figuring out the target repo.
This patch covers the first case, but not the later
Personnally, I would prefer keeping the testing2* scripts. They are more convenient (especially with tab completion) than using db-move directly with all its arguments.
Do you have any sane way to simplify or combine all the testing2* scripts? There's a LOT of them
I can think about 2 methods right now:
1) We use the same method as with commitpkg, i.e. a single script with a bunch of symlinks. The script check how it has been called and set the target repo and arch accordingly.
2) We currently have 3 testing2extra* script (one for each arch). We could merge them all into a single smarter testing2extra script that would handle all arches. As we usually move both arches out of testing at the same time, that will be more efficient and will reduce by a factor of 3 the number of testing2* scripts. For cases where we only want to move one of the arch out of testing, we will need to use the db-move script directly.
I think there is no need for any testing2* script apart from testing2x. Has anybody ever used the other scripts directly apart from moving a new package? db-move should take care of that rare case.
Allan
I believe I only used testing2x once because the other scripts didn't had support for something (any arch?). As for the other testing2* scripts, I use them all the time probably because of habit. I checked testing2x again and it might be a suitable replacement but it is missing 2 things: - community repo support. Shoud be easy to implement. Just check on what host the script is run and checkout the appropriate svn repo. The sourceballs patches I submitted added some community repo support to the config file which might be helpfull here. - 'any' arch support. Unless we want to implement my idea #2, looks trivial. I think we only need to add a symlink and to update the case statement at beginning.
On 12/03/10 08:03, Ghost1227 wrote:
--- testing2community | 13 ----------- testing2community-any | 13 ----------- testing2community64 | 13 ----------- testing2core | 11 --------- testing2core-any | 13 ----------- testing2core64 | 13 ----------- testing2extra | 13 ----------- testing2extra-any | 13 ----------- testing2extra64 | 13 ----------- testing2x | 57 ------------------------------------------------- testing2x64 | 1 - 11 files changed, 0 insertions(+), 173 deletions(-) delete mode 100755 testing2community delete mode 100755 testing2community-any delete mode 100755 testing2community64 delete mode 100755 testing2core delete mode 100755 testing2core-any delete mode 100755 testing2core64 delete mode 100755 testing2extra delete mode 100755 testing2extra-any delete mode 100755 testing2extra64 delete mode 100755 testing2x delete mode 120000 testing2x64
Unless db-move got a lot smarter, I strong object to the testing2x script being removed. The rest are fine to remove with the patch that makes db-move handle multiple packages. As an aside... testing2x should really do both architectures at once. Allan
participants (6)
-
Aaron Griffin
-
Allan McRae
-
Dan McGee
-
Daniel J Griffiths (Ghost1227)
-
Eric Bélanger
-
Ghost1227