Aaron Griffin schrieb:

So I made a handful of changes to the dbscripts, and wanted to get a quick review from people before I push them live.

If you get a chance, please look over the recent patches here: http://projects.archlinux.org/?p=dbscripts.git;a=summary

This include's Xavier's new-and-improved check_archlinux script too.

Thanks, Aaron :wq

Starting to review your changes now. Could we please tag the "releases" that are used on gerolde in the future? I was guessing that f404689fc11bbeace243779305ede5b7d7270ae8 is what we are using now but it seems that there is a commit in /arch/.git which is not on the projects.archlinux repo. What's wrong here?

Aaron Griffin schrieb:

So I made a handful of changes to the dbscripts, and wanted to get a quick review from people before I push them live.

If you get a chance, please look over the recent patches here: http://projects.archlinux.org/?p=dbscripts.git;a=summary

This include's Xavier's new-and-improved check_archlinux script too.

Thanks, Aaron :wq

I didn't look at check_archlinux, as it's too long for me now: http://projects.archlinux.org/?p=dbscripts.git;a=commit;h=909b017c08109bda40... Now my remarks on the rest: http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=afc6b5b5977fe7... The db-functions has not been added here, so I can't really check if it is fine, the rest looks good though. http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=06194a8691f50f... There is a problem here: rm -f "$srcpath/${pkgname}-*-*${SRCEXT}" If you run this with mplayer, this will not only remove old mplayer packages, but also mplayer-plugin (think of more examples if you want). That's the reason I am using the ugly getpkgname in the cleanup scripts (or was using it, dunno if it is still there). http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=e1ad729fd49c63... This includes unstable and lacks community. Couldn't see more problems now, but there probably are more.

On Sun, Aug 31, 2008 at 3:49 AM, Thomas Bächler wrote:

http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=afc6b5b5977fe7... The db-functions has not been added here, so I can't really check if it is fine, the rest looks good though.

Oh man, my fault. Committed and pushed now. The big issue here is that I was stupidly locking some of the things NOT based on the repo, but based on the script. I wanted to unify the locking so that db-remove will fail for a repo that has a db-update in progress, etc

http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=06194a8691f50f... There is a problem here: rm -f "$srcpath/${pkgname}-*-*${SRCEXT}" If you run this with mplayer, this will not only remove old mplayer packages, but also mplayer-plugin (think of more examples if you want). That's the reason I am using the ugly getpkgname in the cleanup scripts (or was using it, dunno if it is still there).

That's a very good point. Could you suggest a cleaner way to clean up existing tarballs? How about: for srcpkg in $pkgname*; do [ "$(getpkgname $srcpkg)" == "$pkgname" ] && rm -f "$srcpkg" done

http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=e1ad729fd49c63... This includes unstable and lacks community.

Removed unstable... community, however, is another beast that I wanted to avoid thinking about for now... adding that might tip us over the disk space limit on gerolde. For the record, I have not moved existing source tarballs to /home/ftp/sources/ yet, because I fear it may force our mirrors to sync those as well... does anyone with more rsync knowledge want to check to see if this will happen? I'd like to add a stanza for JUST the sources and exclude if from elsewhere, making it optional...

Aaron Griffin schrieb:

...

http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=06194a8691f50f... There is a problem here: rm -f "$srcpath/${pkgname}-*-*${SRCEXT}" If you run this with mplayer, this will not only remove old mplayer packages, but also mplayer-plugin (think of more examples if you want). That's the reason I am using the ugly getpkgname in the cleanup scripts (or was using it, dunno if it is still there).

That's a very good point. Could you suggest a cleaner way to clean up existing tarballs? How about: for srcpkg in $pkgname*; do [ "$(getpkgname $srcpkg)" == "$pkgname" ] && rm -f "$srcpkg" done

That should work, if we make sure the getpkgname function parses the filename properly.

...

http://projects.archlinux.org/?p=dbscripts.git;a=commitdiff;h=e1ad729fd49c63... This includes unstable and lacks community.

Removed unstable... community, however, is another beast that I wanted to avoid thinking about for now... adding that might tip us over the disk space limit on gerolde.

I thought we had enough donation money left, if so, just get another hard drive.

For the record, I have not moved existing source tarballs to /home/ftp/sources/ yet, because I fear it may force our mirrors to sync those as well... does anyone with more rsync knowledge want to check to see if this will happen? I'd like to add a stanza for JUST the sources and exclude if from elsewhere, making it optional...

Depends on what they sync. The "ftp" module contains "exclude = /archive/ /other/", while the "ftpfull"/"kitchensink" module doesn't have an exclude line. We could add exclude = /sources to kitchensink, ftpfull and ftp, so that they'd have to explicitly sync the "sources" module.