[arch-dev-public] Fwd: FS#17503: [unzip] zsh completion missing for unzip patches
Hoping for some feedback here from more experienced devs on this one: At some point we began patching unzip with additional flags, allowing it to properly extract UTF-encoded zip files made on the win32 platform. Apparently this has broken zsh autocompletion features. Similar unzip patches have been submitted upstream and all have been rejected. Upstream has considered adding proper support, but has stopped short of committing to it. The question is do we keep the patch and make this a zsh issue, or do we remove the patch, fixing zsh in the process and screwing some win32 zip files? More info: http://bugs.archlinux.org/task/17503 http://bugs.archlinux.org/task/15256
On Tue, Jan 19, 2010 at 2:06 PM, Thayer Williams <thayerw@gmail.com> wrote:
Hoping for some feedback here from more experienced devs on this one:
At some point we began patching unzip with additional flags, allowing it to properly extract UTF-encoded zip files made on the win32 platform. Apparently this has broken zsh autocompletion features. Similar unzip patches have been submitted upstream and all have been rejected. Upstream has considered adding proper support, but has stopped short of committing to it.
The question is do we keep the patch and make this a zsh issue, or do we remove the patch, fixing zsh in the process and screwing some win32 zip files?
More info:
http://bugs.archlinux.org/task/17503 http://bugs.archlinux.org/task/15256
Can we get one of the broken win32 zip files to verify? I wonder if bsdtar can extract them. If so, then I say we remove the patch as we then have an alternative
On Jan 19, 2010 at 12:20 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Tue, Jan 19, 2010 at 2:06 PM, Thayer Williams <thayerw@gmail.com> wrote:
The question is do we keep the patch and make this a zsh issue, or do we remove the patch, fixing zsh in the process and screwing some win32 zip files?
More info:
http://bugs.archlinux.org/task/17503 http://bugs.archlinux.org/task/15256
Can we get one of the broken win32 zip files to verify? I wonder if bsdtar can extract them. If so, then I say we remove the patch as we then have an alternative
I was wondering the same because p7zip can unzip too and its GPLed. I'll see what I can find.
On Jan 19, 2010 at 12:26 PM, Thayer Williams <thayerw@gmail.com> wrote:
On Jan 19, 2010 at 12:20 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Tue, Jan 19, 2010 at 2:06 PM, Thayer Williams <thayerw@gmail.com> wrote:
The question is do we keep the patch and make this a zsh issue, or do we remove the patch, fixing zsh in the process and screwing some win32 zip files?
More info:
http://bugs.archlinux.org/task/17503 http://bugs.archlinux.org/task/15256
Can we get one of the broken win32 zip files to verify? I wonder if bsdtar can extract them. If so, then I say we remove the patch as we then have an alternative
I was wondering the same because p7zip can unzip too and its GPLed. I'll see what I can find.
Attached is a test archive grabbed from Ubuntu launchpad: "This file is compressed with a hungarian localized windows with iso-8859-2 character encoding, and it cannot be extracted using file-roller. The error message is caution: filename not matched: 01_KB_eln\?k.pdf . The name of the file should be 01_KB_elnök.pdf (with double accented o)" It extracts correctly with 7z, but not with bsdtar or unzip. If that's good enough for you I'll pull the unzip patch.
On Jan 19, 2010 at 12:35 PM, Thayer Williams <thayerw@gmail.com> wrote:
It extracts correctly with 7z, but not with bsdtar or unzip. If that's good enough for you I'll pull the unzip patch.
OMG apologies for the file size...I didn't realize how big that sucker was until I sent it.
On Tue, Jan 19, 2010 at 2:36 PM, Thayer Williams <thayerw@gmail.com> wrote:
On Jan 19, 2010 at 12:35 PM, Thayer Williams <thayerw@gmail.com> wrote:
It extracts correctly with 7z, but not with bsdtar or unzip. If that's good enough for you I'll pull the unzip patch.
OMG apologies for the file size...I didn't realize how big that sucker was until I sent it.
T'was blocked :)
On Tue, Jan 19, 2010 at 12:35 PM, Thayer Williams <thayerw@gmail.com> wrote:
On Jan 19, 2010 at 12:26 PM, Thayer Williams <thayerw@gmail.com> wrote:
On Jan 19, 2010 at 12:20 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Tue, Jan 19, 2010 at 2:06 PM, Thayer Williams <thayerw@gmail.com> wrote:
The question is do we keep the patch and make this a zsh issue, or do we remove the patch, fixing zsh in the process and screwing some win32 zip files?
More info:
http://bugs.archlinux.org/task/17503 http://bugs.archlinux.org/task/15256
Can we get one of the broken win32 zip files to verify? I wonder if bsdtar can extract them. If so, then I say we remove the patch as we then have an alternative
I was wondering the same because p7zip can unzip too and its GPLed. I'll see what I can find.
Attached is a test archive grabbed from Ubuntu launchpad:
"This file is compressed with a hungarian localized windows with iso-8859-2 character encoding, and it cannot be extracted using file-roller. The error message is caution: filename not matched: 01_KB_eln\?k.pdf . The name of the file should be 01_KB_elnök.pdf (with double accented o)"
It extracts correctly with 7z, but not with bsdtar or unzip. If that's good enough for you I'll pull the unzip patch.
Bumping this for feedback. 7z correctly unzips localized win32 zip files, but bsdtar/unzip cannot. Is that good enough to remove the conflicting win32 patches from unzip?
participants (2)
-
Aaron Griffin
-
Thayer Williams