Am Mittwoch 09 September 2009 schrieb Jan de Groot:

On Wed, 2009-09-09 at 09:36 +0200, Tobias Powalowski wrote:

...

Hi guys, http://ubuntuforums.org/showthread.php?t=1199797&page=1 http://mabene.icomedias.com/coretemp.patch got a mail about this kernel patch, i think it looks safe.

Any objections in adding it before releasing 2.6.30.6? It will be not included in the .31 series.

The patch has been made against 2.6.28. Reason for not including it in 2.6.29 and 2.6.30 could be that this is a patch against the Ubuntu kernel, but what's the reason for not implementing this in 2.6.31?

I don't know, the patch would apply to the current kernel because there were no changes in those files since january http://git.kernel.org/?p=linux/kernel/git/next/linux- next.git;a=commit;h=57de16e612d63138bd2c618449af9d8312466e25 We don't need to add it, it was just a user request. greetings tpowa -- Tobias Powalowski Archlinux Developer & Package Maintainer (tpowa) http://www.archlinux.org tpowa@archlinux.org

On Wed, 2009-09-09 at 10:18 +0200, Xavier wrote:

On Wed, Sep 9, 2009 at 9:36 AM, Tobias Powalowski wrote:

...

Hi guys, http://ubuntuforums.org/showthread.php?t=1199797&page=1 http://mabene.icomedias.com/coretemp.patch got a mail about this kernel patch, i think it looks safe.

Any objections in adding it before releasing 2.6.30.6? It will be not included in the .31 series.

I looked for an upstream submission. It might help in the decision : http://patchwork.kernel.org/patch/18577/ especially this message : http://lkml.org/lkml/2009/6/18/385

So basically the patch isn't a bad thing, but the values are just guessed, which means the core temperatures reported are not actually the values that intel intended. If upstream doesn't apply it, I don't feel comfortable with applying such a patch either, for the same reasons. Temperature display is nice, but it's useless if the scale is just a guessed value.