[arch-dev-public] Proper commit messages
Recently we had some package updates in the repositories where just the pkgrel was upped and nothing else was changed, and committed with "upgpkg: subversion 1.6.2-3" or "upgpkg: mplayer 29318-1.1". Both examples are worthless commit messages, as there's nothing in there that describes why it was bumped. Could we please make sane commit messages in the near future, so we have an idea why a package has been bumped? Thanks.
On Sun, May 24, 2009 at 09:26, Jan de Groot <jan@jgc.homeip.net> wrote:
Recently we had some package updates in the repositories where just the pkgrel was upped and nothing else was changed, and committed with "upgpkg: subversion 1.6.2-3" or "upgpkg: mplayer 29318-1.1". Both examples are worthless commit messages, as there's nothing in there that describes why it was bumped. Could we please make sane commit messages in the near future, so we have an idea why a package has been bumped?
Thanks.
Perhaps devtools could take a flag that would allow you to customize your commit message?
Daenyth Blank wrote:
On Sun, May 24, 2009 at 09:26, Jan de Groot <jan@jgc.homeip.net> wrote:
Recently we had some package updates in the repositories where just the pkgrel was upped and nothing else was changed, and committed with "upgpkg: subversion 1.6.2-3" or "upgpkg: mplayer 29318-1.1". Both examples are worthless commit messages, as there's nothing in there that describes why it was bumped. Could we please make sane commit messages in the near future, so we have an idea why a package has been bumped?
Thanks.
Perhaps devtools could take a flag that would allow you to customize your commit message?
Ummm.... what? extrapkg "this is a commit message"
On Sun, May 24, 2009 at 10:23, Allan McRae <allan@archlinux.org> wrote:
Ummm.... what?
extrapkg "this is a commit message"
Learn something new every day... :P Can communitypkg do this as well?
Daenyth Blank wrote:
On Sun, May 24, 2009 at 10:23, Allan McRae <allan@archlinux.org> wrote:
Ummm.... what?
extrapkg "this is a commit message"
Learn something new every day... :P
Can communitypkg do this as well?
Yes. Thinking about this some more, maybe the upload scripts should fail if there is no commit message. Even if it is just "upstream update". Allan
Jan de Groot wrote:
Recently we had some package updates in the repositories where just the pkgrel was upped and nothing else was changed, and committed with "upgpkg: subversion 1.6.2-3" or "upgpkg: mplayer 29318-1.1". Both examples are worthless commit messages, as there's nothing in there that describes why it was bumped. Could we please make sane commit messages in the near future, so we have an idea why a package has been bumped?
Thanks.
Mea culpa concerning subversion. I should have put the following message: "Rebuilt to solve http://bugs.archlinux.org/task/14738" I'll do better next time. F
On 24/05/2009, Jan de Groot <jan@jgc.homeip.net> wrote:
Could we please make sane commit messages in the near future, so we have an idea why a package has been bumped? Yeah, this would be wonderful
-- Andrea `BaSh` Scarpino Arch Linux Developer
On Sun, May 24, 2009 at 12:24 PM, Andrea Scarpino<andrea@archlinux.org> wrote:
On 24/05/2009, Jan de Groot <jan@jgc.homeip.net> wrote:
Could we please make sane commit messages in the near future, so we have an idea why a package has been bumped? Yeah, this would be wonderful
http://projects.archlinux.org/?p=devtools.git;a=commitdiff;h=360fcd2f0ecaba3...
2009/5/24, Jan de Groot <jan@jgc.homeip.net>:
Could we please make sane commit messages in the near future, so we have an idea why a package has been bumped?
Sorry, my wrong. I had rebuilt mplayer 29318-1.1 fixing FS#12897 (http://bugs.archlinux.org/task/12897). I've built subversion 1.6.2-3 but only for x86_64 arch. I cannot know why it has been bumped by François Charette. I will be making sane commit messages in the near future. -- Arch Linux Developer http://www.archlinux.org
Giovanni Scafora wrote:
2009/5/24, Jan de Groot <jan@jgc.homeip.net>:
Could we please make sane commit messages in the near future, so we have an idea why a package has been bumped?
Sorry, my wrong. I had rebuilt mplayer 29318-1.1 fixing FS#12897 (http://bugs.archlinux.org/task/12897). I've built subversion 1.6.2-3 but only for x86_64 arch. I cannot know why it has been bumped by François Charette. I will be making sane commit messages in the near future.
It doesn't matter when just doing a build for a package already in one architecture, because the commit message should already be on trunk. Allan
participants (7)
-
Aaron Griffin
-
Allan McRae
-
Andrea Scarpino
-
Daenyth Blank
-
Firmicus
-
Giovanni Scafora
-
Jan de Groot