[arch-dev-public] [signoffs] openvpn, mkinitcpio, cryptsetup, initscripts

Thomas Bächler

30 Jul 2009 30 Jul '09

5:17 p.m.

All of these packages should be moved to core so they can be included in the ISOs: mkinitcpio: Just a one-commit change, has been in testing for a while, just no signoff thread (was waiting for full -any support) cryptsetup: nobody ever replied, works fine here openvpn: Paul tested -1, -2 fixed the URL and one bug in the new init script, but I never got a reply on the signoff. initscripts: no idea, but gerbra says he needs a fix that is included here.

Attachments:

signature.asc (application/pgp-signature — 260 bytes)

Show replies by date

Aaron Griffin

30 Jul 30 Jul

5:21 p.m.

On Thu, Jul 30, 2009 at 12:17 PM, Thomas Bächler wrote:

...

All of these packages should be moved to core so they can be included in the ISOs:

mkinitcpio: Just a one-commit change, has been in testing for a while, just no signoff thread (was waiting for full -any support)

I don't know if I fully tested this or not, so I don't want to jump into the signoff.

...

cryptsetup: nobody ever replied, works fine here

Here, have my signoff :)

...

openvpn: Paul tested -1, -2 fixed the URL and one bug in the new init script, but I never got a reply on the signoff.

Go ahead and have my signoff here too

...

initscripts: no idea, but gerbra says he needs a fix that is included here.

I think we should put out a new release with the 3 commits in there, and get that moved quickly. Opinions?

Allan McRae

5:27 p.m.

New subject: [arch-dev-public] [signoffs] openvpn, mkinitcpio, cryptsetup, initscripts

Aaron Griffin wrote:

...

On Thu, Jul 30, 2009 at 12:17 PM, Thomas Bächler wrote:

...
All of these packages should be moved to core so they can be included in the ISOs:

mkinitcpio: Just a one-commit change, has been in testing for a while, just no signoff thread (was waiting for full -any support)

I don't know if I fully tested this or not, so I don't want to jump into the signoff.

...
cryptsetup: nobody ever replied, works fine here

Here, have my signoff :)

...
openvpn: Paul tested -1, -2 fixed the URL and one bug in the new init script, but I never got a reply on the signoff.

Go ahead and have my signoff here too

...
initscripts: no idea, but gerbra says he needs a fix that is included here.

I think we should put out a new release with the 3 commits in there, and get that moved quickly. Opinions?

Those commits look fine to me. If you do that, then it would be good to alter the install file slightly too. I just looked at the install file and I used vercmp to restrict the sed usage in inittab, but it should probably be surrounded in an [ -f /etc/inittab.pacsave ] too. Allan

Thomas Bächler

5:28 p.m.

New subject: [arch-dev-public] [signoffs] openvpn, mkinitcpio, cryptsetup, initscripts

Aaron Griffin schrieb:

...

On Thu, Jul 30, 2009 at 12:17 PM, Thomas Bächler wrote:

...
All of these packages should be moved to core so they can be included in the ISOs:

mkinitcpio: Just a one-commit change, has been in testing for a while, just no signoff thread (was waiting for full -any support)

I don't know if I fully tested this or not, so I don't want to jump into the signoff.

For your convenience: http://projects.archlinux.org/?p=mkinitcpio.git;a=commitdiff;h=2c1570f8a4f5b... This is necessary for 2.6.30 users that have strange usb mass storage extensions. It is also necessary for providing an all-powerful Arch USB installation that will boot anywhere (needs autodetect disabled).

...

...
cryptsetup: nobody ever replied, works fine here

Here, have my signoff :)

Just because you don't use it.

...

...
initscripts: no idea, but gerbra says he needs a fix that is included here.

I think we should put out a new release with the 3 commits in there, and get that moved quickly. Opinions?

If we do it quickly, then yes. Otherwise I'd say let Allan move out his stuff, and then move the new stuff to testing.

Aaron Griffin

5:31 p.m.

On Thu, Jul 30, 2009 at 12:28 PM, Thomas Bächler wrote:

...

Aaron Griffin schrieb:

...
On Thu, Jul 30, 2009 at 12:17 PM, Thomas Bächler wrote:

...
All of these packages should be moved to core so they can be included in the ISOs:

mkinitcpio: Just a one-commit change, has been in testing for a while, just no signoff thread (was waiting for full -any support)

I don't know if I fully tested this or not, so I don't want to jump into the signoff.

For your convenience: http://projects.archlinux.org/?p=mkinitcpio.git;a=commitdiff;h=2c1570f8a4f5b...

This is necessary for 2.6.30 users that have strange usb mass storage extensions. It is also necessary for providing an all-powerful Arch USB installation that will boot anywhere (needs autodetect disabled).

...
...
cryptsetup: nobody ever replied, works fine here

Here, have my signoff :)

Just because you don't use it.

...
...
initscripts: no idea, but gerbra says he needs a fix that is included here.

I think we should put out a new release with the 3 commits in there, and get that moved quickly. Opinions?

If we do it quickly, then yes. Otherwise I'd say let Allan move out his stuff, and then move the new stuff to testing.

I'm just wondering if the console stuff and the printf not playign nicely with netcfg issues shoud be on the ISO

Gerhard Brauer

5:44 p.m.

New subject: [arch-dev-public] [signoffs] openvpn, mkinitcpio, cryptsetup, initscripts

Am Donnerstag, den 30.07.2009, 12:31 -0500 schrieb Aaron Griffin:

...

On Thu, Jul 30, 2009 at 12:28 PM, Thomas Bächler wrote:

...
...
...
initscripts: no idea, but gerbra says he needs a fix that is included here.

I think we should put out a new release with the 3 commits in there, and get that moved quickly. Opinions?

If we do it quickly, then yes. Otherwise I'd say let Allan move out his stuff, and then move the new stuff to testing.

I'm just wondering if the console stuff and the printf not playign nicely with netcfg issues shoud be on the ISO

The initscripts 2009.07-3 are not really a MUST, we use currently a patched version of 2009.03-2 on the iso/images. Gerhard

Roman Kyrylych

6:38 p.m.

On Thu, Jul 30, 2009 at 20:44, Gerhard Brauer wrote:

...

Am Donnerstag, den 30.07.2009, 12:31 -0500 schrieb Aaron Griffin:

...
On Thu, Jul 30, 2009 at 12:28 PM, Thomas Bächler wrote:

...
...
...
initscripts: no idea, but gerbra says he needs a fix that is included here.

I think we should put out a new release with the 3 commits in there, and get that moved quickly. Opinions?

If we do it quickly, then yes. Otherwise I'd say let Allan move out his stuff, and then move the new stuff to testing.

I'm just wondering if the console stuff and the printf not playign nicely with netcfg issues shoud be on the ISO

The initscripts 2009.07-3 are not really a MUST, we use currently a patched version of 2009.03-2 on the iso/images.

IMO using any package specifically patched for iso image is not a good idea. -- Roman Kyrylych (Роман Кирилич)

Gerhard Brauer

8:22 p.m.

New subject: [arch-dev-public] [signoffs] openvpn, mkinitcpio, cryptsetup, initscripts

Am Donnerstag, den 30.07.2009, 21:38 +0300 schrieb Roman Kyrylych:

...

On Thu, Jul 30, 2009 at 20:44, Gerhard Brauer wrote:

...
The initscripts 2009.07-3 are not really a MUST, we use currently a patched version of 2009.03-2 on the iso/images.

IMO using any package specifically patched for iso image is not a good idea.

Generally you're right, but this package contains only this commit: http://projects.archlinux.org/?p=initscripts.git;a=commit;h=92cbc62e1c1b22c6... We prevent only that the hwclock is changed by rc.shutdown after the installer has set the time correctly. Without this patch UTC bios clock users will flood us with bugreports ;-) A LiveCd has never, never, ever to change anything on users hardware... Gerhard

Roman Kyrylych

10:31 p.m.

On Thu, Jul 30, 2009 at 23:22, Gerhard Brauer wrote:

...

Am Donnerstag, den 30.07.2009, 21:38 +0300 schrieb Roman Kyrylych:

...
On Thu, Jul 30, 2009 at 20:44, Gerhard Brauer wrote:

...
The initscripts 2009.07-3 are not really a MUST, we use currently a patched version of 2009.03-2 on the iso/images.

IMO using any package specifically patched for iso image is not a good idea.

Generally you're right, but this package contains only this commit: http://projects.archlinux.org/?p=initscripts.git;a=commit;h=92cbc62e1c1b22c6...

I hope this commit was added too: http://projects.archlinux.org/?p=initscripts.git;a=commitdiff;h=28d34292a9a8... ;-) I don't get it - the change exists in the core package anyway. What am I missing? -- Roman Kyrylych (Роман Кирилич)

Gerhard Brauer

31 Jul 31 Jul

8:26 a.m.

New subject: [arch-dev-public] [signoffs] openvpn, mkinitcpio, cryptsetup, initscripts

Am Freitag, den 31.07.2009, 01:31 +0300 schrieb Roman Kyrylych:

...

On Thu, Jul 30, 2009 at 23:22, Gerhard Brauer wrote:

...
Generally you're right, but this package contains only this commit: http://projects.archlinux.org/?p=initscripts.git;a=commit;h=92cbc62e1c1b22c6...

I hope this commit was added too: http://projects.archlinux.org/?p=initscripts.git;a=commitdiff;h=28d34292a9a8... ;-)

That is a little confusing ;-) I never committed to initscripts, i sent a patch in FS#15263. I think Aaron wrote the commit and had a typo. In the modified initscripts 2009.03-2 we use my patch from the flyspray report.

...

I don't get it - the change exists in the core package anyway. What am I missing?

No, it's not in core (initscripts 2009.03-2). Therein we have: -------- HWCLOCK_PARAMS="--systohc" if [ "$HARDWARECLOCK" = "UTC" ]; then HWCLOCK_PARAMS="$HWCLOCK_PARAMS --utc" else HWCLOCK_PARAMS="$HWCLOCK_PARAMS --localtime" fi ------------- And this is the problem: We assume automatic localtime if $HARDWARECLOCK is not UTC. But during boot of the LiveCD $HARDWARECLOCK isn't set to any value by default - only the user could set it by cmdline. This lead to the problem for UTC bios clock users... initscripts 2009.07-3 handle this now better (also for normal use in a normal system): It changes hwclock *only* if a defined value got parsed from rc.conf - either localtime or UTC. Otherwise bios clock is not touched. And the live CD benefits most from this change: it avoids that a user found his hardware was modified against the state it was before using the LiveCD. Gerhard

Roman Kyrylych

8:36 a.m.

On Fri, Jul 31, 2009 at 11:26, Gerhard Brauer wrote:

...

Am Freitag, den 31.07.2009, 01:31 +0300 schrieb Roman Kyrylych:

...
On Thu, Jul 30, 2009 at 23:22, Gerhard Brauer wrote:

...
Generally you're right, but this package contains only this commit: http://projects.archlinux.org/?p=initscripts.git;a=commit;h=92cbc62e1c1b22c6...

I hope this commit was added too: http://projects.archlinux.org/?p=initscripts.git;a=commitdiff;h=28d34292a9a8... ;-)

That is a little confusing ;-) I never committed to initscripts, i sent a patch in FS#15263. I think Aaron wrote the commit and had a typo. In the modified initscripts 2009.03-2 we use my patch from the flyspray report.

...
I don't get it - the change exists in the core package anyway. What am I missing?

No, it's not in core (initscripts 2009.03-2).

Ah, I confused 2009.07 with 2009.03, Yeah, initscripts should move to core. I don't remember if I gave signoffs for the latest versions, but mkinitcpio, cryptsetup and initscripts are working fine here on x86_64. So here are my signoffs for them. -- Roman Kyrylych (Роман Кирилич)

Gerhard Brauer

9:04 a.m.

New subject: [arch-dev-public] [signoffs] openvpn, mkinitcpio, cryptsetup, initscripts

Am Donnerstag, den 30.07.2009, 19:44 +0200 schrieb Gerhard Brauer:

...

Am Donnerstag, den 30.07.2009, 12:31 -0500 schrieb Aaron Griffin:

...
I'm just wondering if the console stuff and the printf not playign nicely with netcfg issues shoud be on the ISO

The initscripts 2009.07-3 are not really a MUST, we use currently a patched version of 2009.03-2 on the iso/images.

I must invent here again: If there are issues with the vc->tty transition/printf on netcfg when the new packages move from testing to core then we shouldn't move them so fast. We currently don't have netcfg (which seems a popular package for wireless stuff) on the ISO (Q: Should we have it?, IMHO iwconfig and wpa_supplicant is enough for wireless installations). But if new core packages break something which could not fix in netcfg then we should delay the move testing->core until problems fixed. Again: We don't need initscripts/filesystem/udev/... from testing for the ISO, we could release fine with packages currently in core - only the hwclock patch is needed for us. And that we have... So: Don't panic! Gerhard

Roman Kyrylych

2:45 p.m.

On Fri, Jul 31, 2009 at 12:04, Gerhard Brauer wrote:

...

Am Donnerstag, den 30.07.2009, 19:44 +0200 schrieb Gerhard Brauer:

...
Am Donnerstag, den 30.07.2009, 12:31 -0500 schrieb Aaron Griffin:

...
I'm just wondering if the console stuff and the printf not playign nicely with netcfg issues shoud be on the ISO

The initscripts 2009.07-3 are not really a MUST, we use currently a patched version of 2009.03-2 on the iso/images.

I must invent here again: If there are issues with the vc->tty transition/printf on netcfg when the new packages move from testing to core then we shouldn't move them so fast. We currently don't have netcfg (which seems a popular package for wireless stuff) on the ISO (Q: Should we have it?, IMHO iwconfig and wpa_supplicant is enough for wireless installations). But if new core packages break something which could not fix in netcfg then we should delay the move testing->core until problems fixed.

The printf bug is fixed in git, so it may be better to just release a new initscripts package. -- Roman Kyrylych (Роман Кирилич)

5391

Age (days ago)

5392

Last active (days ago)

List overview

Download

12 comments

5 participants

participants (5)

Aaron Griffin
Allan McRae
Gerhard Brauer
Roman Kyrylych
Thomas Bächler