[arch-dev-public] extrapkg fail
$ extrapkg git-1.6.4.3-1-x86_64.pkg.tar.gz 100% 7010KB 70.8KB/s 01:39 File integrity okay. ===> Uploaded /home/makepkg/packages/git-1.6.4.3-1-x86_64.pkg.tar.gz Vim: Warning: Output is not to a terminal [1]+ Stopped extrapkg Well that didn't work so well. There is a lot of weird going on in the current version of the script, including all sorts of interesting things when you don't supply a commit message (like it lying to you about what message it used). I'd like to patch it back to using a default message if you don't specify one. What was the original objection to that? -Dan
On Sun, Sep 13, 2009 at 9:15 AM, Dan McGee <dpmcgee@gmail.com> wrote:
$ extrapkg git-1.6.4.3-1-x86_64.pkg.tar.gz 100% 7010KB 70.8KB/s 01:39 File integrity okay. ===> Uploaded /home/makepkg/packages/git-1.6.4.3-1-x86_64.pkg.tar.gz Vim: Warning: Output is not to a terminal
[1]+ Stopped extrapkg
Well that didn't work so well. There is a lot of weird going on in the current version of the script, including all sorts of interesting things when you don't supply a commit message (like it lying to you about what message it used).
I'd like to patch it back to using a default message if you don't specify one. What was the original objection to that?
I dont think this is your bug... http://projects.archlinux.org/?p=devtools.git;a=commitdiff;h=360fcd2f0ecaba3... There's the change. It almost looks like your vim is hanging. Try "EDITOR=nano" and extrapkg. As for the objection to the commit message, it's the fact that people don't enter one, and I feel they should, so we have legitimate changelogs
On Sun, Sep 13, 2009 at 14:08, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Sun, Sep 13, 2009 at 9:15 AM, Dan McGee <dpmcgee@gmail.com> wrote: I dont think this is your bug...
http://projects.archlinux.org/?p=devtools.git;a=commitdiff;h=360fcd2f0ecaba3...
There's the change.
It almost looks like your vim is hanging. Try "EDITOR=nano" and extrapkg.
As for the objection to the commit message, it's the fact that people don't enter one, and I feel they should, so we have legitimate changelogs
It looks like it's hanging because of the >/dev/null, redirecting all of vim's output (hence the error message). If you try, you'll notice that you can still :q and so forth.
--- commitpkg | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/commitpkg b/commitpkg index edff666..0bbe15c 100755 --- a/commitpkg +++ b/commitpkg @@ -101,12 +101,12 @@ if [ "$1" != "" ]; then echo "===> Commited with \"upgpkg: $pkgbase $pkgver-$pkgrel $1\" message" else - svn commit >/dev/null + svn commit if [ $? -ne 0 ]; then echo "Cancelled" exit 1 fi - echo "===> Commited with \"upgpkg: $pkgbase $pkgver-$pkgrel\" message" + echo "===> Commited" fi archrelease $repo-$CARCH -- 1.6.4.3
On Mon, Sep 14, 2009 at 22:02, Dan McGee <dan@archlinux.org> wrote:
--- commitpkg | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Looks clean to me. I've had such a change manually added in my copy and it seems fine. TU signoff I suppose?
On Mon, Sep 14, 2009 at 9:02 PM, Dan McGee <dan@archlinux.org> wrote:
--- commitpkg | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/commitpkg b/commitpkg index edff666..0bbe15c 100755 --- a/commitpkg +++ b/commitpkg @@ -101,12 +101,12 @@ if [ "$1" != "" ]; then echo "===> Commited with \"upgpkg: $pkgbase $pkgver-$pkgrel $1\" message" else - svn commit >/dev/null + svn commit if [ $? -ne 0 ]; then echo "Cancelled" exit 1 fi - echo "===> Commited with \"upgpkg: $pkgbase $pkgver-$pkgrel\" message" + echo "===> Commited" fi
archrelease $repo-$CARCH
Thanks Dan. Feel free to push this to the devtools repo (still a bit busy today)
On Tue, Sep 15, 2009 at 11:03 AM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Mon, Sep 14, 2009 at 9:02 PM, Dan McGee <dan@archlinux.org> wrote:
--- commitpkg | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/commitpkg b/commitpkg index edff666..0bbe15c 100755 --- a/commitpkg +++ b/commitpkg @@ -101,12 +101,12 @@ if [ "$1" != "" ]; then echo "===> Commited with \"upgpkg: $pkgbase $pkgver-$pkgrel $1\" message" else - svn commit >/dev/null + svn commit if [ $? -ne 0 ]; then echo "Cancelled" exit 1 fi - echo "===> Commited with \"upgpkg: $pkgbase $pkgver-$pkgrel\" message" + echo "===> Commited" fi
archrelease $repo-$CARCH
Thanks Dan. Feel free to push this to the devtools repo (still a bit busy today)
Pushed.
participants (4)
-
Aaron Griffin
-
Daenyth Blank
-
Dan McGee
-
Dan McGee