[arch-dev-public] [PATCH 1/2] Change msg "uploading to" to smthg less ambiguous
--- commitpkg | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/commitpkg b/commitpkg index 8413058..e805b47 100755 --- a/commitpkg +++ b/commitpkg @@ -68,7 +68,7 @@ if [ "$1" = "-l" ]; then fi for CARCH in ${arch[@]}; do - echo "===> Uploading to $repo-$CARCH" + echo "===> Uploading to staging/$repo for arch=$CARCH" for _pkgname in ${pkgname[@]}; do pkgfile=$_pkgname-$pkgver-$pkgrel-$CARCH$PKGEXT -- 1.6.5
This is just better practice, as CARCH means something else in makepkg.conf --- commitpkg | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/commitpkg b/commitpkg index e805b47..10f58d9 100755 --- a/commitpkg +++ b/commitpkg @@ -67,10 +67,10 @@ if [ "$1" = "-l" ]; then shift 2 fi -for CARCH in ${arch[@]}; do - echo "===> Uploading to staging/$repo for arch=$CARCH" +for _arch in ${arch[@]}; do + echo "===> Uploading to staging/$repo for arch=${_arch}" for _pkgname in ${pkgname[@]}; do - pkgfile=$_pkgname-$pkgver-$pkgrel-$CARCH$PKGEXT + pkgfile=$_pkgname-$pkgver-$pkgrel-${_arch}$PKGEXT if [ ! -f $pkgfile -a -f "$PKGDEST/$pkgfile" ]; then pkgfile="$PKGDEST/$pkgfile" @@ -105,7 +105,7 @@ for CARCH in ${arch[@]}; do echo "===> Commited" fi - archrelease $repo-$CARCH || abort + archrelease $repo-${_arch} || abort done if [ "${arch[*]}" == "any" ]; then -- 1.6.5
On Wed, Oct 21, 2009 at 9:20 AM, Francois Charette
This is just better practice, as CARCH means something else in makepkg.conf --- commitpkg | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/commitpkg b/commitpkg index e805b47..10f58d9 100755 --- a/commitpkg +++ b/commitpkg @@ -67,10 +67,10 @@ if [ "$1" = "-l" ]; then shift 2 fi
-for CARCH in ${arch[@]}; do - echo "===> Uploading to staging/$repo for arch=$CARCH" +for _arch in ${arch[@]}; do + echo "===> Uploading to staging/$repo for arch=${_arch}" for _pkgname in ${pkgname[@]}; do - pkgfile=$_pkgname-$pkgver-$pkgrel-$CARCH$PKGEXT + pkgfile=$_pkgname-$pkgver-$pkgrel-${_arch}$PKGEXT
if [ ! -f $pkgfile -a -f "$PKGDEST/$pkgfile" ]; then pkgfile="$PKGDEST/$pkgfile" @@ -105,7 +105,7 @@ for CARCH in ${arch[@]}; do echo "===> Commited" fi
- archrelease $repo-$CARCH || abort + archrelease $repo-${_arch} || abort done
if [ "${arch[*]}" == "any" ]; then -- 1.6.5
Not a big deal but I thought _arch was not a good practice either because it could be defined in the pkgbuild. Why not local_arch ?
participants (2)
-
Francois Charette
-
Xavier