Git submodules in PKGBUILDs are broken as of git 2.38.1 update
Hey! As of git 2.38.1 [0], the handling of submodules in PKGBUILDS is broken due to CVE-2022-39253 [1]. This situation affects the packages that use the following command for updating the submodules:
git submodule update
This will result in "fatal: transport 'file' not allowed" error since the value of `protocol.file.allow` is changed to be "user" by default. It means that `file://` clones are considered unsafe by default. Currently, there are two possible fixes available: 1. git -c protocol.file.allow=always submodule update 2. git submodule--helper update The latter seems to be an internal command which does not have any public facing documentation whereas the former option is more explicit. There is a related bug report [2] and a TODO list draft [3] for updating the affected packages. I will be updating the VCS guidelines [4] to use the first proposed solution if it all looks good. [0] https://lore.kernel.org/lkml/xmqq4jw1uku5.fsf@gitster.g/ [1] https://www.cve.org/CVERecord?id=CVE-2022-39253 [2] https://bugs.archlinux.org/task/76255 [3] https://md.archlinux.org/YVwV_wIKQfG5obcNLNlCjg [4] https://wiki.archlinux.org/title/VCS_package_guidelines#Git_submodules Let's make some gains, Orhun
On Wed, Oct 26, 2022 at 09:52:02PM +0300, Orhun Parmaksiz wrote:
Hey!
Thanks for taking care of this!
Currently, there are two possible fixes available:
1. git -c protocol.file.allow=always submodule update 2. git submodule--helper update
The latter seems to be an internal command which does not have any public facing documentation whereas the former option is more explicit.
There is a related bug report [2] and a TODO list draft [3] for updating the affected packages.
I will be updating the VCS guidelines [4] to use the first proposed solution if it all looks good.
I think option 1 is fine. Staying clear of internal implementation details is generally a good idea! -- Morten Linderud PGP: 9C02FF419FECBE16
participants (2)
-
Morten Linderud
-
Orhun Parmaksiz