[arch-dev-public] [signoff] bash-4.1.009-4
Clean-up of our configuration files: - add all configuration files used by bash to the package and make sure they are backed up - do not source /etc/bash.bashrc.local as it is non-standard (Suse specific???) and /etc/bash.bashrc can be directly edited now backed up... - check for interactive session before sourcing bashrc (sort of FS#20717) - more generic terminal matching for PROMPT_COMMAND (FS#20429) and do not overwrite if already set (FS#22161) Signoff both, Allan
Am 02.02.2011 06:33, schrieb Allan McRae:
- do not source /etc/bash.bashrc.local as it is non-standard (Suse specific???) and /etc/bash.bashrc can be directly edited now backed up...
Why? We explicitly added this feature just a year ago, so we would have a system-wide .bashrc. The idea was that we can update our arch-defaults while a user-specific configuration stays in place. This was the sanest possibility in my eyes.
On 02/02/11 18:49, Thomas Bächler wrote:
Am 02.02.2011 06:33, schrieb Allan McRae:
- do not source /etc/bash.bashrc.local as it is non-standard (Suse specific???) and /etc/bash.bashrc can be directly edited now backed up...
Why? We explicitly added this feature just a year ago, so we would have a system-wide .bashrc. The idea was that we can update our arch-defaults while a user-specific configuration stays in place. This was the sanest possibility in my eyes.
Mainly because every other distro except Suse does not use this and so many people would adjust /etc/bash.bashrc anyway. As that was not a backup file, these changes would get overridden each update. Also, I really would not want my system-wide bashrc updated at the whim of my distribution packager. I would find it much better to manually merge the file. Allan
Le 2 février 2011 00:33:59, Allan McRae a écrit :
Clean-up of our configuration files:
- add all configuration files used by bash to the package and make sure they are backed up
- do not source /etc/bash.bashrc.local as it is non-standard (Suse specific???) and /etc/bash.bashrc can be directly edited now backed up...
- check for interactive session before sourcing bashrc (sort of FS#20717)
- more generic terminal matching for PROMPT_COMMAND (FS#20429) and do not overwrite if already set (FS#22161)
Signoff both, Allan
Tested interacively and with some bash script. Signoff x86_64 Stéphane
[2011-02-02 15:33:59 +1000] Allan McRae:
Clean-up of our configuration files:
- add all configuration files used by bash to the package and make sure they are backed up
- do not source /etc/bash.bashrc.local as it is non-standard (Suse specific???) and /etc/bash.bashrc can be directly edited now backed up...
- check for interactive session before sourcing bashrc (sort of FS#20717)
- more generic terminal matching for PROMPT_COMMAND (FS#20429) and do not overwrite if already set (FS#22161)
signoff i686 -- Gaetan
On Thu, Feb 3, 2011 at 8:21 AM, Gaetan Bisson <bisson@archlinux.org> wrote:
[2011-02-02 15:33:59 +1000] Allan McRae:
Clean-up of our configuration files:
- add all configuration files used by bash to the package and make sure they are backed up
- do not source /etc/bash.bashrc.local as it is non-standard (Suse specific???) and /etc/bash.bashrc can be directly edited now backed up...
- check for interactive session before sourcing bashrc (sort of FS#20717)
- more generic terminal matching for PROMPT_COMMAND (FS#20429) and do not overwrite if already set (FS#22161)
signoff i686
I haven't noticed any problems. signoff x86_64
participants (5)
-
Allan McRae
-
Eric Bélanger
-
Gaetan Bisson
-
Stéphane Gaudreault
-
Thomas Bächler