On Wednesday 10 March 2010 03:10:39 Dan McGee wrote:
Seems sane; but maybe do the chmod before copying it into that directory rather than after? That way files never set foot in there with the wrong permissions (even if only for almost zero time). It's ok. I forwarded the output too.
From a9545a8d51f7f236aa2b18f70aaad8f997751ea9 Mon Sep 17 00:00:00 2001 From: Andrea Scarpino <andrea@archlinux.org> Date: Wed, 10 Mar 2010 03:42:05 +0100 Subject: [PATCH] fix permissions of incoming packages --- db-update | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/db-update b/db-update index 0973bf3..36e168f 100755 --- a/db-update +++ b/db-update @@ -219,6 +219,7 @@ for current_arch in ${ARCHES[@]}; do if [ $(getpkgfiles "$WORKDIR/build/"*-$current_arch$PKGEXT 2>/dev/null | wc -l) != 0 ]; then echo "Copying new files to '$ftppath'" for f in "$WORKDIR/build/"*-$current_arch$PKGEXT; do + chmod 664 $f &> /dev/null if ! /bin/cp "$f" "$ftppath/"; then die "error: failure while copying files to $ftppath" fi @@ -227,6 +228,7 @@ for current_arch in ${ARCHES[@]}; do if [ $(getpkgfiles "$WORKDIR/build/"*-any$PKGEXT 2>/dev/null | wc -l) != 0 ]; then echo "Copying new files to '$ftppath_any' and symlinking" for f in "$WORKDIR/build/"*-any$PKGEXT; do + chmod 644 $f &> /dev/null if ! /bin/cp "$f" "$ftppath_any"; then die "error: failure while copying files to $ftppath_any" fi -- 1.7.0.2 -- Andrea