The 09/05/12, Kevin Chadwick wrote:
On Wed, 9 May 2012 12:30:34 +0200 Nicolas Sebrecht wrote:
You should turn them all in things like:
mkdir /sys 2> /dev/null 2>&1 cd /sys || { ewarn "<the error message>" return 1 }
That's just a little less racy and certainly not atomic, /usr/bin/install would be atomic. As you have said your race point doesn't actually matter. You call it plain wrong and admit there is nothing wrong at the same time?
The way used to handle conditions is wrong. And I admit that for /this/ particular case, this is not much relevant.
There's another point, shell is easily editable and understandable and that's a good thing and not a bad one and also one of arches values I believe, hence pacman uses so much shell!
I don't find pacman much editable, sorry. I've given examples of nice features not easy to implement, here in the past. ,-p -- Nicolas Sebrecht