On Tue, Sep 07, 2010 at 09:51:59PM -0500, Victor Lowther wrote:
On Tue, Sep 7, 2010 at 3:32 PM, Thomas Bächler <thomas@archlinux.org> wrote:
Am 30.06.2010 23:47, schrieb Victor Lowther:
Despite efforts to make the initscripts POSIX, we use bash 4.0 features.
Bashifying this framework should result in about a 30% speedup, assuming no IO latency and that all programs we call also take zero time. :)
I just pushed the patches - I was going to do more review of some of them, but I am apparently too busy. Please post any patches (especially if a correction of patch 21 is needed, I haven't finished reading the discussion) rebased on the current initscripts.git.
Your last patch has a typo (missed close paren):
-snip-
There's a typo in the network script from commit a334b36b: diff --git a/network b/network index 20ff9c7..5abb824 100755 --- a/network +++ b/network @@ -96,7 +96,7 @@ rtup() rtdown() { - if [[ ! $1 ]; then + if [[ ! $1 ]]; then echo "usage: $0 rtdown <route_name>" return 1 fi