2009/12/15, Xavier <shiningxc@gmail.com>:

If you need any help/testing, just ask.

I don't know how I should fix FS#10959. The line || grep "$governor" /sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors > /dev/null 2>&1 where should I put? -- Arch Linux Developer http://www.archlinux.org http://www.archlinux.it

Giovanni Scafora schrieb:

modprobe $mod || grep "$governor" /sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors > /dev/null 2>&1

or

grep "$governor" /sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors || modprobe $mod > /dev/null 2>&1

The second one doesn't make sense. Don't use >/dev/null in combination with grep, use grep -q: grep -qw "$governor" sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors || modprobe -q $mod

Giovanni Scafora schrieb:

2009/12/15, Thomas Bächler <thomas@archlinux.org>:

...

The second one doesn't make sense. Don't use >/dev/null in combination with grep, use grep -q:

Stupid me: The first one doesn't make sense the second one does. But it seems you understood me correctly.

...

grep -qw "$governor" sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors || modprobe -q $mod

OK, then I put the following line:

grep -qw "$governor" sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors || modprobe -q $mod

I hope that works, look good though.

2009/12/15, Thomas Bächler <thomas@archlinux.org>:

grep -qw "$governor" sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors || modprobe -q $mod

Maybe a / before sys/ is missing? grep -qw "$governor" /sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors || modprobe -q $mod -- Arch Linux Developer http://www.archlinux.org http://www.archlinux.it

On Tue, Dec 15, 2009 at 8:27 AM, Andrea Scarpino <andrea@archlinux.org> wrote:

On 15/12/2009, Giovanni Scafora <giovanni@archlinux.org> wrote:

...

2009/12/15, Thomas Bächler <thomas@archlinux.org>:

...

 grep -qw "$governor" sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors || modprobe -q $mod

Maybe a /  before sys/ is missing? grep -qw "$governor" /sys/devices/system/cpu/cpu*/cpufreq/scaling_available_governors || modprobe -q $mod If you put that line into a .install file you do not need the /

If you put that line in an install file you're doing it wrong...

On 15/12/2009, Giovanni Scafora <giovanni@archlinux.org> wrote:

That line is not in an install file. That line is in a script of /etc/rc.d/

So, the / is missing. -- Andrea `bash` Scarpino Arch Linux Developer

Andrea Scarpino schrieb:

On 15/12/2009, Giovanni Scafora <giovanni@archlinux.org> wrote:

...

That line is not in an install file. That line is in a script of /etc/rc.d/

So, the / is missing.

Indeed.

On Tue, Dec 15, 2009 at 3:42 PM, Giovanni Scafora <giovanni@archlinux.org> wrote:

2009/12/15, Thomas Bächler <thomas@archlinux.org>:

...

 Indeed.

OK, I just fixed FS10959 and FS14083. I hope that works. Let me know.

Thanks, almost :) You made one other change : you commented out governor by default in the config. Then starting cpufreq daemon with default settings does this : ... cpufreq-set: option requires an argument -- 'g' <snip whole cpufreq help> That is because the following test does not work correctly : if [ -n $governor ]; then So that branch is executed anyway, even though governor is not set, and cpufreq-set is called with invalid parameter. Adding quotes to the test seems to work : if [ -n "$governor" ]; then So the result with default config will be instead : :: Setting cpufreq governing rules [BUSY] :: Invalid configuration in /etc/conf./cpufreq [FAIL] Other than that, it looks fine.