Re: [arch-general] [arch-dev-public] [PATCH 1/2] checkpkg: Use temporary working directory
On 05/07/10 04:18, Eric Bélanger wrote:
Signed-off-by: Eric Bélanger<snowmaniscool@gmail.com> --- checkpkg | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/checkpkg b/checkpkg index 47fb672..7765d80 100755 --- a/checkpkg +++ b/checkpkg @@ -27,6 +27,12 @@ if [ "$arch" == 'any' ]; then CARCH='any' fi
+TEMPDIR=$(mktemp /tmp/checkpkg-script.XXXX) +rm $TEMPDIR +mkdir -p $TEMPDIR
mktemp can be called with the -d switch and it will create a directory instead of a file. I believe that's the preferable way to go about it.
+ +cd $TEMPDIR + for _pkgname in ${pkgname[@]}; do pkgfile=${_pkgname}-${pkgver}-${pkgrel}-${CARCH}${PKGEXT} oldstylepkgfile=${_pkgname}-${pkgver}-${pkgrel}${PKGEXT} @@ -90,3 +96,5 @@ for _pkgname in ${pkgname[@]}; do echo "No filename differences for $_pkgname." fi done + +echo "Files saved to $TEMPDIR"
On Sun, Jul 4, 2010 at 9:25 PM, Evangelos Foutras <foutrelis@gmail.com> wrote:
On 05/07/10 04:18, Eric Bélanger wrote:
Signed-off-by: Eric Bélanger<snowmaniscool@gmail.com> --- checkpkg | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/checkpkg b/checkpkg index 47fb672..7765d80 100755 --- a/checkpkg +++ b/checkpkg @@ -27,6 +27,12 @@ if [ "$arch" == 'any' ]; then CARCH='any' fi
+TEMPDIR=$(mktemp /tmp/checkpkg-script.XXXX) +rm $TEMPDIR +mkdir -p $TEMPDIR
mktemp can be called with the -d switch and it will create a directory instead of a file. I believe that's the preferable way to go about it.
Agree. I had just copied that snippet from the lddd script. If this patch is accepted, I'll sumbit another patch to use the -d option in both scripts.
participants (2)
-
Eric Bélanger
-
Evangelos Foutras