[arch-general] [PATCH] [initscripts] drop custom support for persistent net/cd symlinks
Hi all, As of the next udev release, /dev/.udev has moved to /dev/.run/udev. So, since we have to update this anyway, I thought this was a good opportunity to review our persistent net/cd rules functionality. If I understand correctly, udev allready has support for creating persistent net/cd symlinks (that we disable by default), and no other distro does anything beyond that. Furthermore, the udev devs explicitly say that /dev/.udev should only be used by udev itself. It is therefore not clear to me why we need this at all. The attached patch removes it alltogether. Any comments? Cheers, Tom
udev contains rules to generate persistent symlinks, if they do not work as intendend this should be reported upstream. Furthermore, upstream discourages using /dev/.udev as its format might change at any time. As of upstream commit 5f59fa0900a5 the location has changed to /dev/.run/udev, so we would have to make a change either way. Signed-off-by: Tom Gundersen <teg@jklm.no> --- rc.sysinit | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/rc.sysinit b/rc.sysinit index 4b24098..ef8077a 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -371,14 +371,6 @@ fi # Set console font if required set_consolefont -# Adding persistent network/cdrom generated rules -for f in cd net; do - [[ -f /dev/.udev/tmp-rules--70-persistent-$f.rules ]] || continue - stat_busy "Adding persistent $f udev rules" - /bin/cat "/dev/.udev/tmp-rules--70-persistent-$f.rules" >> "/etc/udev/rules.d/70-persistent-$f.rules" - stat_done -done - /bin/dmesg >| /var/log/dmesg.log # final hwclock setting needs to be done at this point -- 1.7.4.1
On 15 March 2011 18:31, Tom Gundersen <teg@jklm.no> wrote:
Hi all,
As of the next udev release, /dev/.udev has moved to /dev/.run/udev. So, since we have to update this anyway, I thought this was a good opportunity to review our persistent net/cd rules functionality.
If I understand correctly, udev allready has support for creating persistent net/cd symlinks (that we disable by default), and no other distro does anything beyond that. Furthermore, the udev devs explicitly say that /dev/.udev should only be used by udev itself.
It is therefore not clear to me why we need this at all. The attached patch removes it alltogether.
Any comments?
Cheers,
Tom
Attachments are filtered on this list. -- Tavian Barnes
On Thu, Mar 17, 2011 at 9:08 PM, Tavian Barnes <tavianator@tavianator.com> wrote:
It is therefore not clear to me why we need this at all. The attached patch removes it alltogether.
Attachments are filtered on this list.
Sorry, that was a typo. The patch came as a separate email with subject "[PATCH] udev: do not automatically save persistent net/cd udev rules to /etc on boot". Any other comments? Cheers, Tom
participants (2)
-
Tavian Barnes
-
Tom Gundersen