Re: [arch-general] [arch-dev-public] Let's agree on a common coding style
On 13/02/2010 08:57 μμ, Thomas Bächler wrote:
Never use `...`, always $(...), always use the braces for variable names and always quote paths that contain variables.
I do not agree with your view that braces should always be used around variable names. While I would like to read any justification about that, my opinion is that they should only be used when necessary. For example, in a PKGBUILD I would write ${pkgname}_$pkgver, because _ can be part of a variable name, but I'd much rather prefer to use $pkgname-$pkgver, since hyphens are not allowed in variable names. Less typing, less ugliness. :)
On Sat, Feb 13, 2010 at 15:12, Evangelos Foutras <foutrelis@gmail.com> wrote:
For example, in a PKGBUILD I would write ${pkgname}_$pkgver, because _ can be part of a variable name, but I'd much rather prefer to use $pkgname-$pkgver, since hyphens are not allowed in variable names.
Less typing, less ugliness. :)
This is the way I've always done it and it's much nicer to read. Same for quoting, use only when needed.
On Sat, 13 Feb 2010 15:16:01 -0500 Daenyth Blank <daenyth+arch@gmail.com> wrote:
On Sat, Feb 13, 2010 at 15:12, Evangelos Foutras <foutrelis@gmail.com> wrote:
For example, in a PKGBUILD I would write ${pkgname}_$pkgver, because _ can be part of a variable name, but I'd much rather prefer to use $pkgname-$pkgver, since hyphens are not allowed in variable names.
Less typing, less ugliness. :)
This is the way I've always done it and it's much nicer to read. Same for quoting, use only when needed.
+1 for braces around vars only when needed. for quoting I'm not so sure. I personally also only quote when I know it's needed, but when your code is shared with a lot of people it can be useful that other people immediately know that stuff is safe (without them having to know all possible values a certain variable can have)
Am 13.02.2010 21:57, schrieb Dieter Plaetinck:
For example, in a PKGBUILD I would write ${pkgname}_$pkgver, because _ can be part of a variable name, but I'd much rather prefer to use $pkgname-$pkgver, since hyphens are not allowed in variable names.
Less typing, less ugliness. :)
This is the way I've always done it and it's much nicer to read. Same for quoting, use only when needed.
+1 for braces around vars only when needed.
If you use braces only when necessary, it will not be consistent - you have braces sometimes and other times you don't. I thought coding style was about consistency.
On Sat, 13 Feb 2010 22:11:01 +0100 Thomas Bächler <thomas@archlinux.org> wrote:
Am 13.02.2010 21:57, schrieb Dieter Plaetinck:
For example, in a PKGBUILD I would write ${pkgname}_$pkgver, because _ can be part of a variable name, but I'd much rather prefer to use $pkgname-$pkgver, since hyphens are not allowed in variable names.
Less typing, less ugliness. :)
This is the way I've always done it and it's much nicer to read. Same for quoting, use only when needed.
+1 for braces around vars only when needed.
If you use braces only when necessary, it will not be consistent - you have braces sometimes and other times you don't. I thought coding style was about consistency.
you can apply "only when needed" consistently.
Am 13.02.2010 22:13, schrieb Dieter Plaetinck:
If you use braces only when necessary, it will not be consistent - you have braces sometimes and other times you don't. I thought coding style was about consistency.
you can apply "only when needed" consistently.
This is very unintuitive. "only when needed" can even depend on the context, I am strictly against it.
On 13/02/2010 11:11 μμ, Thomas Bächler wrote:
Am 13.02.2010 21:57, schrieb Dieter Plaetinck:
For example, in a PKGBUILD I would write ${pkgname}_$pkgver, because _ can be part of a variable name, but I'd much rather prefer to use $pkgname-$pkgver, since hyphens are not allowed in variable names.
Less typing, less ugliness. :)
This is the way I've always done it and it's much nicer to read. Same for quoting, use only when needed.
+1 for braces around vars only when needed.
If you use braces only when necessary, it will not be consistent - you have braces sometimes and other times you don't. I thought coding style was about consistency.
As Dieter mentioned, we can use braces when needed and be consistent in this regard. Most of the time they are not needed and I think using them everywhere hinders readability with no obvious benefit.
On Sat, Feb 13, 2010 at 2:12 PM, Evangelos Foutras <foutrelis@gmail.com> wrote:
On 13/02/2010 08:57 μμ, Thomas Bächler wrote:
Never use `...`, always $(...), always use the braces for variable names and always quote paths that contain variables.
I do not agree with your view that braces should always be used around variable names. While I would like to read any justification about that, my opinion is that they should only be used when necessary.
It's a safety net. It will ALWAYS work if you use braces. Not everyone knows what character ends a variable name and what doesn't.
participants (5)
-
Aaron Griffin
-
Daenyth Blank
-
Dieter Plaetinck
-
Evangelos Foutras
-
Thomas Bächler