-- Jude <jdashiel at panix dot com> "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." Ed Howdershelt 1940. On Thu, 23 Nov 2023, Jelle van der Waa wrote:

On 23/11/2023 11:26, Jude DaShiell wrote:

...

I failed to install edbrowse-git and in doing so one of the failure messages was some warnings being treated as errors. man makepkg didn't show me any switch to prevent warnings being treated as errors unless maybe force does that. Even with force the package didn't install. Did anyone manage to get that to install correctly who could share some ideas what I'm doing wrong? Usually when I run makepkg I do: makepkg --needed -cimrs and very often that actually works.

What errors are we talking about? GCC errors during compilation? Can you share an example.

I ran: makepkg --needed -cimrs 2>&1 |tee edbrowse.err Edbrowse.err was okay for the first 18 lines but not after that. cut here. cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -Wall -Wno-unused -D_FILE_OFFSET_BITS=64 -DEDBROWSE_ON_LINUX -c -o main.o main.c main.c: In function ‘main’: main.c:507:25: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 507 | write(fh, ebrc_string, strlen(ebrc_string)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ main.c: In function ‘mailRedirect’: main.c:411:28: warning: ‘mlen’ may be used uninitialized [-Wmaybe-uninitialized] 411 | if (mlen > slen) | ^ main.c:377:13: note: ‘mlen’ was declared here 377 | int mlen; // length of match string | ^~~~ main.c:422:29: warning: ‘m’ may be used uninitialized [-Wmaybe-uninitialized] 422 | if (memEqualCI(m, subj, mlen)) | ^~~~~~~~~~~~~~~~~~~~~~~~~ main.c:381:21: note: ‘m’ was declared here 381 | const char *m, *r; // match and redirect | ^ main.c:394:40: warning: ‘r’ may be used uninitialized [-Wmaybe-uninitialized] 394 | return r; | ^ main.c:381:25: note: ‘r’ was declared here 381 | const char *m, *r; // match and redirect | ^ main.c: In function ‘readConfigFile’: main.c:2120:41: warning: ‘act’ may be used uninitialized [-Wmaybe-uninitialized] 2120 | if (!act->inport) { | ~~~^~~~~~~~ main.c:1592:26: note: ‘act’ was declared here 1592 | struct MACCOUNT *act; | ^~~ main.c:2098:38: warning: ‘mt’ may be used uninitialized [-Wmaybe-uninitialized] 2098 | mt->down_url = true; main.c:1593:26: note: ‘mt’ was declared here 1593 | struct MIMETYPE *mt; | ^~ main.c:1837:31: warning: ‘td’ may be used uninitialized [-Wmaybe-uninitialized] 1837 | if (td->key1 > td->ncols || td->key2 > td->ncols) | ~~^~~~~~ main.c:1594:25: note: ‘td’ was declared here 1594 | struct DBTABLE *td; | ^~ cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -Wall -Wno-unused -D_FILE_OFFSET_BITS=64 -DEDBROWSE_ON_LINUX -c -o buffers.o buffers.c buffers.c: In function ‘runCommand’: buffers.c:7356:33: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 7356 | asprintf(&wrapline, "( %s ) > %s", newline, wrc_file); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ buffers.c: In function ‘apostropheMacros’: buffers.c:2824:43: warning: ‘newline’ may be used uninitialized [-Wmaybe-uninitialized] 2824 | *s++ = '"'; | ~^~ buffers.c:2757:15: note: ‘newline’ was declared here 2757 | char *newline, *s; | ^~~~~~~ buffers.c: In function ‘atPartCracker’: buffers.c:2946:26: warning: ‘lno1’ may be used uninitialized [-Wmaybe-uninitialized] 2946 | if((lno1 == 0 || lno2 == 0) && !writeMode) { | ~~~~~^~~~ buffers.c:2883:13: note: ‘lno1’ was declared here 2883 | int lno1, lno2 = -1; // line numbers | ^~~~ In function ‘findOpenTA’, inlined from ‘findField’ at buffers.c:3973:8: buffers.c:3876:19: warning: ‘tag’ may be used uninitialized [-Wmaybe-uninitialized] 3876 | if(tag > 0) return tag; | ^ buffers.c: In function ‘findField’: buffers.c:3849:13: note: ‘tag’ was declared here 3849 | int tag, lev = 0; | ^~~ buffers.c: In function ‘twoLetter’: buffers.c:5329:20: warning: ‘s’ may be used uninitialized [-Wmaybe-uninitialized] 5329 | if (s) | ^ buffers.c:5310:29: note: ‘s’ was declared here 5310 | const char *s; | ^ buffers.c: In function ‘substituteText’: buffers.c:4426:38: warning: ‘dol2’ may be used uninitialized [-Wmaybe-uninitialized] 4426 | dol2 += linecount; | ~~~~~^~~~~~~~~~~~ buffers.c:4137:13: note: ‘dol2’ was declared here 4137 | int dol2, alloc2; | ^~~~ buffers.c:4427:35: warning: ‘alloc2’ may be used uninitialized [-Wmaybe-uninitialized] 4427 | if(dol2 + 2 > alloc2) { | ^ buffers.c:4137:19: note: ‘alloc2’ was declared here 4137 | int dol2, alloc2; | ^~~~~~ In file included from /usr/include/stdio.h:964, from eb.h:24, from buffers.c:3: In function ‘asprintf’, inlined from ‘runCommand’ at buffers.c:7356:5: /usr/include/bits/stdio2.h:137:10: warning: ‘wrc_file’ may be used uninitialized [-Wmaybe-uninitialized] 137 | return __asprintf_chk (__ptr, __USE_FORTIFY_LEVEL - 1, __fmt, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 138 | __va_arg_pack ()); | ~~~~~~~~~~~~~~~~~ buffers.c: In function ‘runCommand’: buffers.c:6480:21: note: ‘wrc_file’ was declared here 6480 | const char *wrc_file; | ^~~~~~~~ cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -Wall -Wno-unused -D_FILE_OFFSET_BITS=64 -DEDBROWSE_ON_LINUX -c -o sendmail.o sendmail.c sendmail.c: In function ‘encodeAttachment’: sendmail.c:493:41: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 493 | read(fd, buf + buflen, n); | ^~~~~~~~~~~~~~~~~~~~~~~~~ sendmail.c:697:20: warning: ‘flowed’ may be used uninitialized [-Wmaybe-uninitialized] 697 | if(long_p) *long_p = flowed; | ~~~~~~~~^~~~~~~~ sendmail.c:365:52: note: ‘flowed’ was declared here 365 | bool longline, longword, cr, endlinespace, flowed; | ^~~~~~ In file included from eb.h:28, from sendmail.c:6: In function ‘newSendmailHandle’, inlined from ‘sendMailSMTP’ at sendmail.c:972:11, inlined from ‘sendMail’ at sendmail.c:1284:21: sendmail.c:912:9: warning: call to ‘_curl_easy_setopt_err_debug_cb’ declared with attribute warning: curl_easy_setopt expects a curl_debug_callback argument for this option [-Wattribute-warning] 912 | curl_easy_setopt(handle, CURLOPT_DEBUGFUNCTION, ebcurl_debug_handler); | ^~~~~~~~~~~~~~~~ In function ‘sendMailSMTP’, inlined from ‘sendMail’ at sendmail.c:1284:21: sendmail.c:977:9: warning: call to ‘_curl_easy_setopt_err_read_cb’ declared with attribute warning: curl_easy_setopt expects a curl_read_callback argument for this option [-Wattribute-warning] 977 | curl_easy_setopt(handle, CURLOPT_READFUNCTION, smtp_upload_callback); | ^~~~~~~~~~~~~~~~ cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -Wall -Wno-unused -D_FILE_OFFSET_BITS=64 -DEDBROWSE_ON_LINUX -c -o fetchmail.o fetchmail.c fetchmail.c: In function ‘scanFolder’: fetchmail.c:859:51: error: format not a string literal and no format arguments [-Werror=format-security] 859 | if(!isInteractive) printf(inputline); | ^~~~~~~~~ fetchmail.c:1016:59: error: format not a string literal and no format arguments [-Werror=format-security] 1016 | if(!isInteractive) printf(inputline); | ^~~~~~~~~ fetchmail.c:1081:51: error: format not a string literal and no format arguments [-Werror=format-security] 1081 | if(!isInteractive) printf(inputline); | ^~~~~~~~~ fetchmail.c: In function ‘presentMail’: fetchmail.c:2222:17: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 2222 | write(fh, | ^~~~~~~~~ 2223 | "======================================================================\n", | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2224 | 71); | ~~~ fetchmail.c: In function ‘writeReplyInfo’: fetchmail.c:3631:9: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 3631 | write(rfh, addstring, 12); | ^~~~~~~~~~~~~~~~~~~~~~~~~ fetchmail.c:3632:9: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 3632 | write(rfh, cw->mailInfo, strlen(cw->mailInfo)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fetchmail.c:3633:9: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 3633 | write(rfh, "\n", 1); | ^~~~~~~~~~~~~~~~~~~ fetchmail.c: In function ‘formatMail’: fetchmail.c:3223:51: warning: ‘ attachments’ directive writing 12 bytes into a region of size between 10 and 19 [-Wformat-overflow=] 3223 | sprintf(atbuf, "%d attachments", | ^~~~~~~~~~~~ In file included from /usr/include/stdio.h:964, from eb.h:24, from fetchmail.c:7: In function ‘sprintf’, inlined from ‘headerShow’ at fetchmail.c:3223:5, inlined from ‘formatMail’ at fetchmail.c:3321:30: /usr/include/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 14 and 23 bytes into a destination of size 20 30 | return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 31 | __glibc_objsize (__s), __fmt, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 32 | __va_arg_pack ()); | ~~~~~~~~~~~~~~~~~ In file included from eb.h:28: In function ‘newFetchmailHandle’, inlined from ‘fetchMail’ at fetchmail.c:1915:16: fetchmail.c:1612:9: warning: call to ‘_curl_easy_setopt_err_write_callback’ declared with attribute warning: curl_easy_setopt expects a curl_write_callback argument for this option [-Wattribute-warning] 1612 | curl_easy_setopt(handle, CURLOPT_WRITEFUNCTION, eb_curl_callback); | ^~~~~~~~~~~~~~~~ fetchmail.c:1615:9: warning: call to ‘_curl_easy_setopt_err_debug_cb’ declared with attribute warning: curl_easy_setopt expects a curl_debug_callback argument for this option [-Wattribute-warning] 1615 | curl_easy_setopt(handle, CURLOPT_DEBUGFUNCTION, ebcurl_debug_handler); | ^~~~~~~~~~~~~~~~ In function ‘count_messages’, inlined from ‘fetchMail’ at fetchmail.c:1916:8: fetchmail.c:1740:25: warning: call to ‘_curl_easy_setopt_err_string’ declared with attribute warning: curl_easy_setopt expects a string ('char *' or char[]) argument for this option [-Wattribute-warning] 1740 | curl_easy_setopt(handle, CURLOPT_CUSTOMREQUEST, 0); | ^~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[1]: *** [<builtin>: fetchmail.o] Error 1 make[1]: Leaving directory '/home/jude/builds/edbrowse-git/src/edbrowse-git/src' make: *** [makefile:5: all] Error 2 ==> ERROR: A failure occurred in build(). Aborting... cut here.

That export patch failed and generated more error lines than the original PKGBUILD had. I put that export line as the first line of the prepare section in the PKGBUILD as a test. -- Jude <jdashiel at panix dot com> "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." Ed Howdershelt 1940. On Thu, 23 Nov 2023, Jelle van der Waa wrote:

Hi,

On 23/11/2023 14:39, Jude DaShiell wrote:

...

cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -Wall -Wno-unused -D_FILE_OFFSET_BITS=64 -DEDBROWSE_ON_LINUX -c -o fetchmail.o fetchmail.c fetchmail.c: In function ‘scanFolder’: fetchmail.c:859:51: error: format not a string literal and no format arguments [-Werror=format-security] 859 | if(!isInteractive) printf(inputline); | ^~~~~~~~~ fetchmail.c:1016:59: error: format not a string literal and no format arguments [-Werror=format-security] 1016 | if(!isInteractive) printf(inputline); | ^~~~~~~~~ fetchmail.c:1081:51: error: format not a string literal and no format arguments [-Werror=format-security] 1081 | if(!isInteractive) printf(inputline); | ^~~~~~~~~

Bad advice:

[jelle@t14s][~/projects/cockpit/main]%grep "Werror=format-security" /etc/makepkg.conf -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security \

Change that, but it will affect all packages build locally of course which is undesired.

Better advice:

export CFLAGS="${CFLAGS} -Wno-format-security" in the PKGBUILD

Best advice:

Report this issue upstream, it should be a trivial patch to write.