On 06/04/2018 03:52 AM, Bennett Piater wrote:

On 06/04/2018 10:49 AM, Tinu Weber wrote:

...

...

$ git commit -am "console-blanking-0.0.1-2"

On Mon, Jun 04, 2018 at 03:38:08 -0500, David C. Rankin wrote:

It appears you've committed also the built package files into the repo.>

never git commit -a.

always manually track files using git add - in your case, git add .SRCINFO PKGBUILD LICENSE *.service and then commit without the a.

That way, you will always only push what is needed.

Cheers, Bennett

Well I tried without `-a` and no changes to .SRCINFO or PKGBUILD were incorporated. I also removed the package and signature files. The push is trying to push exactly what it should, e.g.: $ tar -tzf console-blanking-0.0.1-4.src.tar.gz tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/ tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/PKGBUILD tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/LICENSE tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/.SRCINFO tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/console-blanking.service But git still throws the error: $ git push -u origin master Counting objects: 36, done. Delta compression using up to 8 threads. Compressing objects: 100% (36/36), done. Writing objects: 100% (36/36), 43.60 KiB | 10.90 MiB/s, done. Total 36 (delta 14), reused 0 (delta 0) remote: error: The following error occurred when parsing commit remote: error: 93a539f81d7d0f001dd5522781ebeabf7cf73f9d: remote: error: missing source file: LICENSE remote: error: hook declined to update refs/heads/master To ssh://aur.archlinux.org/console-blanking.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'ssh://aur@aur.archlinux.org/console-blanking.git' I'll have to play with this more tomorrow. I've not had any other problems with my other 3 packages, and I followed the same archwiki Aur page to clone the empty repository and then attempt to create the .SRCINFO, sign, commit and push. Strange I welcome any other thoughts. -- David C. Rankin, J.D.,P.E.

On 06/04/2018 04:30 AM, Bennett Piater wrote:

This is a different error, is it not? Does your most recent commit contain the LICENSE file, or did you only add PKGBUILD and .SRCINFO?

Oh, it's there... $ tar -tzf console-blanking-0.0.1-4.src.tar.gz tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/ tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/PKGBUILD tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/LICENSE ^^^^^^^^^^^^^^^^^^^^^^^^^^^ tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/.SRCINFO tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/console-blanking.service -- David C. Rankin, J.D.,P.E.

On 06/04/2018 11:39 AM, David C. Rankin wrote:

On 06/04/2018 04:30 AM, Bennett Piater wrote:

...

This is a different error, is it not? Does your most recent commit contain the LICENSE file, or did you only add PKGBUILD and .SRCINFO?

Oh, it's there...

$ tar -tzf console-blanking-0.0.1-4.src.tar.gz tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/ tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/PKGBUILD tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/LICENSE ^^^^^^^^^^^^^^^^^^^^^^^^^^^ tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/.SRCINFO tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/console-blanking.service

Where does that tarball come from? What I am asking is if the commit contains the files. If you got that tarball from the aur, then it obviously doesn't contain what the rejected commit does since that is not online yet :) Or are you trying to push a commit containing the tarball? That's not going to work, the aur expects flat files. Also feel free to ping me on irc if you think that's more productive, just be aware that my timezone is CEST, GMT+2 :) That is the tarball generated by: $ makepkg --printsrcinfo > .SRCINFO $ makepkg -S --sign -f That results in the two untracked files: console-blanking-0.0.1-4.src.tar.gz console-blanking-0.0.1-4.src.tar.gz.sig The tarballs are the source package for the console-blanking package I am trying to push. The flat files are there as well. $ git ls-files .SRCINFO LICENSE PKGBUILD console-blanking.service and show the files that are currently being tracked in the repo. There must be some other strange issue that isn't readily apparent -- at least to me.

On June 4, 2018 12:58 PM, Bennett Piater wrote:

Do you have an unpushed commit that may not pass muster, even if it is not the last?

If so, you could try squashing all unpushed commits together to one using git rebase.

On June 4, 2018 1:04 PM, Eli Schwartz via arch-general wrote:

That's saying that in commit 93a539f81d7d0f001dd5522781ebeabf7cf73f9d

you had committed a .SRCINFO file which listed a LICENSE file, but you did not commit the LICENSE file itself. You've got corrupted history, adding a new commit with the LICENSE file does not fix the old commit. Use --amend if you need to fix up old commits.

If I read this thread correctly, your git history isn't corrupt in the sense that it would break git, but your git history is not conforming with AUR rules. To obey those, reading up about git rebase [0] is the way to go. Keep in mind that you have to give git rebase a commit behind the one you intend to edit, eg. git rebase -i 93a539f~1 so you can edit (using git add and git commit --amend) the commit in question so it becomes acceptable. One way to go would be to remove LICENSE from the .SRCINFO for 93a539f so it becomes consistent. You can read about the details in the footnote. cheers! mar77i [0] https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History ​Sent with ProtonMail Secure Email.​

On 06/04/2018 05:27 AM, David C. Rankin wrote:

Well I tried without `-a` and no changes to .SRCINFO or PKGBUILD were incorporated. I also removed the package and signature files. The push is trying to push exactly what it should, e.g.:

$ tar -tzf console-blanking-0.0.1-4.src.tar.gz tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/ tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/PKGBUILD tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/LICENSE tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/.SRCINFO tar: Ignoring unknown extended header keyword 'SCHILY.fflags' console-blanking/console-blanking.service

The push may be trying to push exactly what you intended to push, but it most certainly is not pushing what you are supposed to push by the rules of submission. Do not commit tarballs to the AUR. That is a source package, which contains an extra copy of the PKGBUILD and .SRCINFO... but why do you think anyone needs that? Moreover, tarballs do not compress well in git(1), so by using tarballs you put unnecessary burden on the AUR which will result in the size of the AUR growing much faster than it was expected to, and becoming unwieldy. Do *not* commit tarballs to git repositories, in the general sense! It's almost certainly not what you want. The AUR contains code to detect files larger than 250KB and refuse your package with the message "maximum blob size (250.00KiB) exceeded". But just because you can *get away* with uploading tarballs small enough to trick our "abusive file" detector, does not mean I advocate doing so!

But git still throws the error:

$ git push -u origin master Counting objects: 36, done. Delta compression using up to 8 threads. Compressing objects: 100% (36/36), done. Writing objects: 100% (36/36), 43.60 KiB | 10.90 MiB/s, done. Total 36 (delta 14), reused 0 (delta 0) remote: error: The following error occurred when parsing commit remote: error: 93a539f81d7d0f001dd5522781ebeabf7cf73f9d: remote: error: missing source file: LICENSE

That's saying that in commit 93a539f81d7d0f001dd5522781ebeabf7cf73f9d you had committed a .SRCINFO file which listed a LICENSE file, but you did not commit the LICENSE file itself. You've got corrupted history, adding a new commit with the LICENSE file does not fix the old commit. Use --amend if you need to fix up old commits.

remote: error: hook declined to update refs/heads/master To ssh://aur.archlinux.org/console-blanking.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'ssh://aur@aur.archlinux.org/console-blanking.git'

I'll have to play with this more tomorrow. I've not had any other problems with my other 3 packages, and I followed the same archwiki Aur page to clone the empty repository and then attempt to create the .SRCINFO, sign, commit and push. Strange

List of packages so I can perform AUR administration and remove those *.src.tar.gz using sekrit TU powers? :p -- Eli Schwartz Bug Wrangler and Trusted User

On 06/04/2018 01:29 PM, David C. Rankin wrote:

On 06/04/2018 06:04 AM, Eli Schwartz via arch-general wrote:

...

List of packages so I can perform AUR administration and remove those *.src.tar.gz using sekrit TU powers? :p

Thank you Eli, my existing packages are:

https://aur.archlinux.org/packages/cflow/ https://aur.archlinux.org/packages/gtkwrite_git/ https://aur.archlinux.org/packages/gtkwrite/

Ignore my little joke, your packages are fine. :) Well, except for one which contained two versions of a very small tarball but doesn't anymore, and is not really worth fixing.

I was trying to add a new 'console-blanking', but apparently I've got the git/Aur history so Fsck'ed up there is little hope. I have a love-hate relationship with git. I love it when it works, I hate it when it doesn't...

The -amend, rebase verbiage is Greek at the moment. If you can zero out whatever I did so I can simply push a new package, that would be greatly appreciated. If not, I'll try and stumble through the documentation on -amend and rebase later tonight.

There's currently no history to zero out, until you can successfully push to the AUR without the .SRCINFO hook declining you, nothing will be uploaded at all. If you're uncomfortable with git amend/rebase, then you could simply switch to a new directory, init a new repository, and cp over the PKGBUILD and .SRCINFO and any other files in the source array which are not remotely downloaded, then begin the history from scratch. As long as you commit all files in the first commit it should be fine. -- Eli Schwartz Bug Wrangler and Trusted User

I've got a couple of complaints regarding your existing packages On 06/04/2018 07:29 PM, David C. Rankin wrote:

https://aur.archlinux.org/packages/cflow/

provides=("${pkgname") is implicit; url= & source= can be reached via https - update them!

https://aur.archlinux.org/packages/gtkwrite_git/

The license is invalid, and please don't call it `foo_git` - instead use the common `foo-git`; You're also missing `git` as makedep, and `gtksourceview2` as normal dep

https://aur.archlinux.org/packages/gtkwrite/

The license is invalid Don't conflicts=() with the -git version or whatever, that's what the other packages providing your pkgname should do, not the other way around; You're also missing `gtksourceview2` as normal dep In general, cd "${srcdir}" is redundant, stop (ab)using msg() and msg2(), & get rid of the unused assignments. Regarding the actual issue though,

I was trying to add a new 'console-blanking', but apparently I've got the git/Aur history so Fsck'ed up there is little hope. I have a love-hate relationship with git. I love it when it works, I hate it when it doesn't...

The -amend, rebase verbiage is Greek at the moment. If you can zero out whatever I did so I can simply push a new package, that would be greatly appreciated. If not, I'll try and stumble through the documentation on -amend and rebase later tonight.

You haven't pushed anything under that name to the AUR yet, just fix your local history. -- Rob (coderobe) O< ascii ribbon campaign - stop html mail - www.asciiribbon.org

On 06/04/2018 05:21 PM, David C. Rankin wrote:

On 06/04/2018 12:50 PM, Robin Broda via arch-general wrote: <snip>

...

...

https://aur.archlinux.org/packages/gtkwrite_git/ The license is invalid, and please don't call it `foo_git` - instead use the common `foo-git`; You're also missing `git` as makedep, and `gtksourceview2` as normal dep

I changed the name, but when a user builds with the new name gtkwrite-git, instead of gtkwrite_git and attempts an install -- will there be a problem that requires manual intervention due to the name change? Is there anything else I need to do to change gtkwrite_git to gtkwrite-git -- other than change the name (and update the parameter expansions)?

It looks like I will have to remove the gtkwrite_git package completely and create a new gtkwrite-git. Attempting a name change fails due to an unexpected pkgbase being rejected, e.g. remote: error: invalid pkgbase: gtkwrite-git, expected gtkwrite_git remote: error: hook declined to update refs/heads/master To ssh://aur.archlinux.org/gtkwrite_git.git ! [remote rejected] master -> master (hook declined) error: failed to push some refs to 'ssh://aur@aur.archlinux.org/gtkwrite_git.git' What is the best way to fix this? clone a new repo with the -git name and then -- how do I completely remove the old _git package? -- David C. Rankin, J.D.,P.E.

On 06/04/2018 10:41 PM, Eli Schwartz via arch-general wrote:

You'd need to resubmit a new package in order to rename.

You can use the replaces=() field to indicate that this package should be installed instead of the former package, but the AUR doesn't really implement replaces metadata and no AUR helper even tries AFAIK.

Done, new package '-git' created and delete request submitted on old '_git' package.

Also in general, you seem to include gcc in the makedepends, and recently added pkgconf and make as well. This is incorrect. All three are in the base-devel group, which is *mandatory* for using makepkg, so anyone who does not have them is doing the wrong thing.

The AUR does *not* cater to people who try building packages without base-devel installed.

Which means that as makedepends they're totally unnecessary and therefore clutter which should be removed.

Removed on all. Thank you for your help and tutelage. -- David C. Rankin, J.D.,P.E.