Loui Chang wrote:

On Tue 27 Oct 2009 04:39 +0200, Evangelos Foutras wrote:

...

Hello,

The $Id$ keyword came up while talking with Angel and I realized that the svn:keywords property doesn't get set on PKGBUILD for new packages, and thus $Id$ doesn't get updated on commit. I believe we should fix this, as this information is useful when determining when a PKGBUILD was last modified and by whom.

May I suggest we do the following:

1) Edit the "Adding a package" section [1] of the packaging instructions in the DeveloperWiki to include this step. (Adding `svn propset svn:keywords "Id" new-package/trunk/PKGBUILD' below the $EDITOR line perhaps?) 2) Add this property to all packages (this has been done once before by Aaron, if I remember correctly).

What's your view on this?

I don't see why we need to taint the source files with these ID tags. Isn't SVN enough to give us information about our revision history?

Files from ABS don't contain any revision history. Besides, it's faster and easier to obtain this information by glancing at the first line when you're editing a PKGBUILD, than by doing `svn info PKGBUILD' from the terminal. You may have a point regarding the purposefulness (or lack of thereof) of these tags. However, please note that I'm focusing on the fact that right now we have several PKGBUILDs with empty $Id$ lines and not whether these tags should exist at all or not.

On Tue, Oct 27, 2009 at 1:18 AM, Eric Bélanger wrote:

On Mon, Oct 26, 2009 at 10:39 PM, Evangelos Foutras wrote:

...

Hello,

The $Id$ keyword came up while talking with Angel and I realized that the svn:keywords property doesn't get set on PKGBUILD for new packages, and thus $Id$ doesn't get updated on commit. I believe we should fix this, as this information is useful when determining when a PKGBUILD was last modified and by whom.

May I suggest we do the following:

1) Edit the "Adding a package" section [1] of the packaging instructions in the DeveloperWiki to include this step. (Adding `svn propset svn:keywords "Id" new-package/trunk/PKGBUILD' below the $EDITOR line perhaps?) 2) Add this property to all packages (this has been done once before by Aaron, if I remember correctly).

What's your view on this?

---- [1] http://wiki.archlinux.org/index.php/DeveloperWiki:HOWTO_Be_A_Packager#Adding...

We should  do #1.  The Id tag should be set when a package is added to the repo.  As for option #2, it has already been done.

Done. I've edited the how-to.

On Tue, Oct 27, 2009 at 1:38 AM, Evangelos Foutras wrote:

Eric Bélanger wrote:

...

On Mon, Oct 26, 2009 at 10:39 PM, Evangelos Foutras wrote:

...

Hello,

The $Id$ keyword came up while talking with Angel and I realized that the svn:keywords property doesn't get set on PKGBUILD for new packages, and thus $Id$ doesn't get updated on commit. I believe we should fix this, as this information is useful when determining when a PKGBUILD was last modified and by whom.

May I suggest we do the following:

1) Edit the "Adding a package" section [1] of the packaging instructions in the DeveloperWiki to include this step. (Adding `svn propset svn:keywords "Id" new-package/trunk/PKGBUILD' below the $EDITOR line perhaps?) 2) Add this property to all packages (this has been done once before by Aaron, if I remember correctly).

What's your view on this?

---- [1]

http://wiki.archlinux.org/index.php/DeveloperWiki:HOWTO_Be_A_Packager#Adding...

We should  do #1.  The Id tag should be set when a package is added to the repo.  As for option #2, it has already been done.

Unless I'm missing something, it has only been done once, on 2008-04-18. Packages added after that point do not have the svn:keywords property set (e.g.: aufs2).

Yes, that's what I meant. It was done once on the whole repos when it was moved to svn. Devs and TUs who adds packages need to run the svn propset command to set the Id tag.

(Thanks for amending the developer wiki, by the way.)

Flavio Costa wrote:

On Tue, Oct 27, 2009 at 4:13 AM, Eric Bélanger wrote:

...

On Tue, Oct 27, 2009 at 1:38 AM, Evangelos Foutras wrote:

...

Eric Bélanger wrote:

...

On Mon, Oct 26, 2009 at 10:39 PM, Evangelos Foutras <

foutrelis@gmail.com>

...

...

wrote:

...

Hello,

The $Id$ keyword came up while talking with Angel and I realized that

the

...

...

...

svn:keywords property doesn't get set on PKGBUILD for new packages, and thus $Id$ doesn't get updated on commit. I believe we should fix this, as

this

...

...

...

information is useful when determining when a PKGBUILD was last

modified

...

...

...

and by whom.

May I suggest we do the following:

1) Edit the "Adding a package" section [1] of the packaging

instructions

...

...

...

in the DeveloperWiki to include this step. (Adding `svn propset

svn:keywords

...

...

...

"Id" new-package/trunk/PKGBUILD' below the $EDITOR line perhaps?) 2) Add this property to all packages (this has been done once before by Aaron, if I remember correctly).

What's your view on this?

---- [1]

http://wiki.archlinux.org/index.php/DeveloperWiki:HOWTO_Be_A_Packager#Adding...

...

...

...

We should do #1. The Id tag should be set when a package is added to the repo. As for option #2, it has already been done.

Unless I'm missing something, it has only been done once, on 2008-04-18. Packages added after that point do not have the svn:keywords property set (e.g.: aufs2).

Yes, that's what I meant. It was done once on the whole repos when it was moved to svn. Devs and TUs who adds packages need to run the svn propset command to set the Id tag.

...

(Thanks for amending the developer wiki, by the way.)

What about SVN autoprops, can't you just attach a "pre-made" '~/.subversion/config' in the wiki and people can grab it from there.

That's one nifty feature. Thanks for mentioning it.

On Tue, Oct 27, 2009 at 9:26 PM, Aaron Griffin wrote:

...

On Tue, Oct 27, 2009 at 4:13 AM, Eric Bélanger

...

On Tue, Oct 27, 2009 at 1:38 AM, Evangelos Foutras

...

wrote:

...

Eric Bélanger wrote:

...

On Mon, Oct 26, 2009 at 10:39 PM, Evangelos Foutras <

foutrelis@gmail.com>

...

wrote:

...

Hello,

The $Id$ keyword came up while talking with Angel and I realized

On Tue, Oct 27, 2009 at 6:01 AM, Flavio Costa wrote: that

...

...

...

...

...

svn:keywords property doesn't get set on PKGBUILD for new packages, and thus $Id$ doesn't get updated on commit. I believe we should fix this, as

the this

...

...

...

information is useful when determining when a PKGBUILD was last modified and by whom.

May I suggest we do the following:

1) Edit the "Adding a package" section [1] of the packaging instructions in the DeveloperWiki to include this step. (Adding `svn propset svn:keywords "Id" new-package/trunk/PKGBUILD' below the $EDITOR line perhaps?) 2) Add this property to all packages (this has been done once before by Aaron, if I remember correctly).

What's your view on this?

---- [1]

http://wiki.archlinux.org/index.php/DeveloperWiki:HOWTO_Be_A_Packager#Adding...

...

...

...

...

We should do #1. The Id tag should be set when a package is added to the repo. As for option #2, it has already been done.

Unless I'm missing something, it has only been done once, on 2008-04-18. Packages added after that point do not have the svn:keywords property set (e.g.: aufs2).

Yes, that's what I meant. It was done once on the whole repos when it was moved to svn. Devs and TUs who adds packages need to run the svn propset command to set the Id tag.

...

(Thanks for amending the developer wiki, by the way.)

What about SVN autoprops, can't you just attach a "pre-made" '~/.subversion/config' in the wiki and people can grab it from there.

I was going to suggest this too. I don't recall the syntax, though, but we should be able to match PKGBUILD files and set autoprops for that.

It's so lame that svn doesn't let you set properties like this at the directory level...

Indeed! -- Flávio Coutinho da Costa