[arch-general] http://bugs.archlinux.org/task/14873
This bug was closed with "It is not a bug " and BTW you solution is wrong. Flac fails with "command not found line 20" when built under clean chroot This is line 20: patch -p1 < ../flac-1.2.1-gcc-4.3-includes.patch || return 1 Please fix As a side note which is correct ${startdir}/patch.file or ${srcdir}/patch.file I have be disciplined for both
Baho Utot wrote:
This bug was closed with "It is not a bug " and BTW you solution is wrong.
Flac fails with "command not found line 20" when built under clean chroot
This is line 20:
patch -p1 < ../flac-1.2.1-gcc-4.3-includes.patch || return 1
Please fix
Do you have patch in your chroot?
As a side note which is correct ${startdir}/patch.file or ${srcdir}/patch.file
I have be disciplined for both
As a general rule, you never should use $startdir in a PKGBUILD. Allan
Allan McRae wrote: [..]
As a general rule, you never should use $startdir in a PKGBUILD.
Is that written down somewhere? It'd be nice to have a place to refer to when arguing some changes to PKGBUILDs. /M -- Magnus Therning (OpenPGP: 0xAB4DFBA4) magnus＠therning．org Jabber: magnus＠therning．org http://therning.org/magnus identi.ca|twitter: magthe
Magnus Therning wrote:
Allan McRae wrote: [..]
As a general rule, you never should use $startdir in a PKGBUILD.
Is that written down somewhere? It'd be nice to have a place to refer to when arguing some changes to PKGBUILDs.
man PKGBUILD: startdir was most often used in combination with /src or /pkg postfixes, but use of the srcdir and pkgdir variables is preferred. The wording has been made even stronger about not using $startdir for the next pacman release. Allan
Allan McRae wrote:
Magnus Therning wrote:
Allan McRae wrote: [..]
As a general rule, you never should use $startdir in a PKGBUILD.
Is that written down somewhere? It'd be nice to have a place to refer to when arguing some changes to PKGBUILDs.
man PKGBUILD: startdir was most often used in combination with /src or /pkg postfixes, but use of the srcdir and pkgdir variables is preferred.
The wording has been made even stronger about not using $startdir for the next pacman release.
Ah, excellent, I wasn't aware of the existence of that man-page. Another thing that I've been wondering about is the relationship between 'depends' and 'makedepends'. The description in the man-page is fairly clear, but just to check I'm wondering if it's correct to say that 1. a dependency should _never_ be mentioned in both 'depends' and 'makedepends'? 2. the packages required to build a package is the union of 'depends' and 'makedepends'? /M -- Magnus Therning (OpenPGP: 0xAB4DFBA4) magnus＠therning．org Jabber: magnus＠therning．org http://therning.org/magnus identi.ca|twitter: magthe
Magnus Therning wrote:
Allan McRae wrote:
Magnus Therning wrote:
Allan McRae wrote: [..]
As a general rule, you never should use $startdir in a PKGBUILD.
Is that written down somewhere? It'd be nice to have a place to refer to when arguing some changes to PKGBUILDs.
man PKGBUILD: startdir was most often used in combination with /src or /pkg postfixes, but use of the srcdir and pkgdir variables is preferred.
The wording has been made even stronger about not using $startdir for the next pacman release.
Ah, excellent, I wasn't aware of the existence of that man-page.
Another thing that I've been wondering about is the relationship between 'depends' and 'makedepends'. The description in the man-page is fairly clear, but just to check I'm wondering if it's correct to say that
1. a dependency should _never_ be mentioned in both 'depends' and 'makedepends'?
2. the packages required to build a package is the union of 'depends' and 'makedepends'?
Yes. They way I think about it is "depends" are needed to run a package and "makedepends" are extras needed to build the package. Allan
Magnus Therning schrieb:
Allan McRae wrote: [..]
As a general rule, you never should use $startdir in a PKGBUILD.
Is that written down somewhere? It'd be nice to have a place to refer to when arguing some changes to PKGBUILDs.
/M
You can regularly refer to the prototypes in /usr/share/pacman. Those have $srcdir and $pkgdir now (which are also necessary for the split package building in pacman 3.3). Other than that, I only noticed because the other devs started using them instead of $startdir. There is one reason to refer to $startdir, maybe we should think about that: The .install file is never included in source=(), but we sometimes sed stuff inside it, refering to $startdir.
participants (4)
-
Allan McRae
-
Baho Utot
-
Magnus Therning
-
Thomas Bächler