[arch-general] /arch/setup -> grub '#-*' marker in menu.lst
Hi, seen in http://projects.archlinux.org/?p=installer.git;a=blob_plain;f=setup;hb=HEAD : # remove default entries by truncating file at our little tag (#-*) sed -i -e '/#-\*/q' Shouldn't it be: sed -i -e '/#-\*/q' $grubmenu instead of just: sed -i -e '/#-\*/q' ? ( $grubmenu == $DESTDIR/boot/grub/menu.lst ) Also, where does the '#-*' tag come from? I can't find any reference to this (no other occurrences in install script). Thanks, Dieter
On Wed, Nov 12, 2008 at 6:47 AM, Dieter Plaetinck <dieter@plaetinck.be> wrote:
Hi, seen in http://projects.archlinux.org/?p=installer.git;a=blob_plain;f=setup;hb=HEAD : # remove default entries by truncating file at our little tag (#-*) sed -i -e '/#-\*/q'
Shouldn't it be: sed -i -e '/#-\*/q' $grubmenu instead of just: sed -i -e '/#-\*/q'
Yes, it should. Good catch.
Also, where does the '#-*' tag come from? I can't find any reference to this (no other occurrences in install script). http://repos.archlinux.org/viewvc.cgi/grub/trunk/menu.lst?view=markup
Dan McGee wrote:
On Wed, Nov 12, 2008 at 6:47 AM, Dieter Plaetinck <dieter@plaetinck.be> wrote:
Also, where does the '#-*' tag come from? I can't find any reference to this (no other occurrences in install script).
http://repos.archlinux.org/viewvc.cgi/grub/trunk/menu.lst?view=markup
Ah.. that explains. Is there any reason for using "root=/dev/sda3 ro" is the (0) entry? I mean, isn't this just a "maybe we're lucky and it will work, otherwise it will fail"-entry? Shouldn't we clarify this a bit more? Eg by setting the title to "Arch Linux [/boot/vmlinuz26] (Default entry. Might work, might not)" or something? (If this entry is even present in a users menu.lst it means something went badly wrong during the arch install process) PS: Let me know if you want a bug ticket for this and/or the sed $grubmenu thing.
participants (2)
-
Dan McGee
-
Dieter Plaetinck