Baho Utot schrieb:

Thorsten Toepper wrote:

...

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224

On Sat, 10 Oct 2009 16:08:02 -0400 Baho Utot <baho-utot@columbus.rr.com> wrote:

...

I am constructing a PKGBUILD for a package and I know some of the variables have been depreciated

Has $startdir been removed if so what is it new equiv.

Thanks

Using $pkgdir and $srcdir is more welcome than using $startdir/{src,pkg}

Not if you're writing a log file and makepkg -c is used.

If all these variables are defined, they all can be used. The question is, for what purpose. Having a logfile in $startdir sounds reasonable to me. Files which are needed to compile a package should go to $srcdir, files that should be in the resulting package should got to $pkgdir. Regards Stefan

Allan McRae wrote:

Stefan Husmann wrote:

...

Baho Utot schrieb:

...

Thorsten Toepper wrote:

...

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224

On Sat, 10 Oct 2009 16:08:02 -0400 Baho Utot <baho-utot@columbus.rr.com> wrote:

...

I am constructing a PKGBUILD for a package and I know some of the variables have been depreciated

Has $startdir been removed if so what is it new equiv.

Thanks

Using $pkgdir and $srcdir is more welcome than using $startdir/{src,pkg}

Not if you're writing a log file and makepkg -c is used.

If all these variables are defined, they all can be used. The question is, for what purpose. Having a logfile in $startdir sounds reasonable to me.

Files which are needed to compile a package should go to $srcdir, files that should be in the resulting package should got to $pkgdir.

In general, you should never use $startdir. There is no guarantee that $stardir/src = $srcdir or similarly with $pkgdir. In fact that definitely does not hold with split packages. If you want to log the build, use "makepkg -L".

I can not think of a valid reason to use $startdir.

Allan

Ok here is your valid reason ./configure --prefix=/usr --shared --libdir=/lib || return 1 make || return 1 make check 2>&1 | tee $startdir/check-log make DESTDIR=${pkgdir} install || return 1 rm -v $pkgdir/lib/libz.so || return 1 install -d -m 0755 $pkgdir/usr/lib || return 1 ln -sfv ../../lib/libz.so.1.2.3 $pkgdir/usr/lib/libz.so || return 1

Allan McRae wrote:

Baho Utot wrote:

...

Allan McRae wrote:

...

Stefan Husmann wrote:

...

Baho Utot schrieb:

...

Thorsten Toepper wrote:

...

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224

On Sat, 10 Oct 2009 16:08:02 -0400 Baho Utot <baho-utot@columbus.rr.com> wrote:

> I am constructing a PKGBUILD for a package and I know some of > the variables have been depreciated > > Has $startdir been removed if so what is it new equiv. > > Thanks >

Using $pkgdir and $srcdir is more welcome than using $startdir/{src,pkg}

Not if you're writing a log file and makepkg -c is used.

If all these variables are defined, they all can be used. The question is, for what purpose. Having a logfile in $startdir sounds reasonable to me.

Files which are needed to compile a package should go to $srcdir, files that should be in the resulting package should got to $pkgdir.

In general, you should never use $startdir. There is no guarantee that $stardir/src = $srcdir or similarly with $pkgdir. In fact that definitely does not hold with split packages. If you want to log the build, use "makepkg -L".

I can not think of a valid reason to use $startdir.

Allan

Ok here is your valid reason

./configure --prefix=/usr --shared --libdir=/lib || return 1 make || return 1 make check 2>&1 | tee $startdir/check-log make DESTDIR=${pkgdir} install || return 1 rm -v $pkgdir/lib/libz.so || return 1 install -d -m 0755 $pkgdir/usr/lib || return 1 ln -sfv ../../lib/libz.so.1.2.3 $pkgdir/usr/lib/libz.so || return 1

Not valid. Use "makepkg -L" to log the entire build process. In the future, there will be a check() function, so you will then get separate logs for build(), check() and package().

It would do what I require to log the entire build... This is not the future, I am still stuck in "current time" make check is valid. I don't want to pollute the check log file with the build information. All I want to pick through is the testing info. On the example the build and check logs are small, care to look at the check log for glibc? Hint it is over 7800 lines just for the check, good luck looking at that plus the entire build in one file.

Aaron Griffin wrote:

On Sat, Oct 10, 2009 at 8:05 PM, Baho Utot <baho-utot@columbus.rr.com> wrote:

...

Allan McRae wrote:

...

Not valid. Â Use "makepkg -L" to log the entire build process. Â In the future, there will be a check() function, so you will then get separate logs for build(), check() and package().

It would do what I require to log the entire build...

This is not the future, I am still stuck in "current time"

make check is valid. I don't want to pollute the check log file with the build information. All I want to pick through is the testing info. On the example the build and check logs are small, care to look at the check log for glibc? Hint it is over 7800 lines just for the check, good luck looking at that plus the entire build in one file.

Why is this so snarky? makepkg -L was created for exactly this reason. If the log is large, most editors have a "search" function.

Creating a log in $startdir is just duplicating effort, if you ask me. makepkg can already do this.

I am very well informed about makepkg ability to generate a log file of the build. I want only the make check 2>&1 | tee "${startdir}/check-log" file, I don't need or want a log from the build. I need the file to be written to the dir with the PKGBUILD. I process the check-log to summarize the pass/fail/errors. Then when I awake in the morning I can see which of the packages built correctly and which ones need more help.

Xavier wrote:

On Sat, Oct 10, 2009 at 10:08 PM, Baho Utot <baho-utot@columbus.rr.com> wrote:

...

I am constructing a PKGBUILD for a package and I know some of the variables have been depreciated

Has $startdir been removed if so what is it new equiv.

Thanks

man PKGBUILD

BUILD() FUNCTION In addition to the above directives, the build() bash function comprises the remainder of the PKGBUILD. This is directly sourced and executed by makepkg, so anything that bash or the system has available is available for use here. Be sure any exotic commands used are covered by makedepends.

All of the above variables such as pkgname and pkgver are available for use in the build function. In addition, makepkg defines three variables for your use during the build and install process. These three variables are as follows:

startdir This contains the absolute path to the directory where the PKGBUILD was located, which is usually the output of $(pwd) when makepkg is started.

srcdir This points to the directory where makepkg extracts or copies all source files.

pkgdir This points to the directory where makepkg bundles the installed package (this directory will become the root directory of your built package).

If you create any variables of your own in the build function, it is recommended to use the bash local keyword to scope the variable to inside the build function.

Hmm, I thought we said here that srcdir and pkgdir should be preferred over startdir...

I need to write a log file where the PKGBUILD file lives so $startdir is golden.