[arch-general] Any objections to asking vim to fix PKGBUILD syntax highlighting?
I'd like to post the following issue at: https://github.com/vim/vim/issues/new Wanted to see if there were any objections from staff, like if even though the error highlighting is technically wrong, if it's desired to be left as-is to discourage 'pkgname' being a single element array or 'SKIP' usage when inappropriate, etc. (Below is in github markup.) Subject: Incorrect error highlighting in syntax/PKGBUILD.vim `vimfiles/syntax/PKGBUILD.vim` highlights two things as errors that it should not. As an example: the [valid official PKGBUILD file for gdb](https://git.archlinux.org/svntogit/packages.git/plain/trunk/PKGBUILD?h=packa...) pkgname=(gdb gdb-common) ... sha1sums=(... 'SKIP') Specifically, it highlights in: `pkgname` the `(`, ` `, and `)`; and `sha1sums` the `SKIP`. `pkgname` is usually not an array, but in the case of split packages, it can be an array. See https://wiki.archlinux.org/index.php/PKGBUILD#pkgname `sha1sums` is quite often a sha, but it can be `SKIP`, especially when given a `.sig` file or a git repo. See https://wiki.archlinux.org/index.php/PKGBUILD#Integrity `SKIP` is valid in: `md5sums`, `sha1sums`, `sha224sums`, `sha256sums`, `sha384sums`, and `sha512sums`.
(Tue, Mar 05, 2019 at 06:26:45AM -0500) james harvey via arch-general :
I'd like to post the following issue at: https://github.com/vim/vim/issues/new
Wanted to see if there were any objections from staff, like if even though the error highlighting is technically wrong, if it's desired to be left as-is to discourage 'pkgname' being a single element array or 'SKIP' usage when inappropriate, etc.
Hi James, I think you’re targetting the wrong project: immae@immae ~ $ pacman -Qo /usr/share/vim/vimfiles/syntax/PKGBUILD.vim /usr/share/vim/vimfiles/syntax/PKGBUILD.vim is owned by pacman-contrib 1.1.0-1 PKGBUILD probably doesn’t exist in vim’s project ;) -- Ismael
On Tue, Mar 05, 2019 at 12:30:54PM +0100, Ismael Bouya wrote:
(Tue, Mar 05, 2019 at 06:26:45AM -0500) james harvey via arch-general :
I'd like to post the following issue at: https://github.com/vim/vim/issues/new
Wanted to see if there were any objections from staff, like if even though the error highlighting is technically wrong, if it's desired to be left as-is to discourage 'pkgname' being a single element array or 'SKIP' usage when inappropriate, etc.
Hi James, I think you’re targetting the wrong project: immae@immae ~ $ pacman -Qo /usr/share/vim/vimfiles/syntax/PKGBUILD.vim /usr/share/vim/vimfiles/syntax/PKGBUILD.vim is owned by pacman-contrib 1.1.0-1
PKGBUILD probably doesn’t exist in vim’s project ;)
It does, but it's just a simple alias to set filetype to bash. I think some of us also discovered this recently and was pleasantly surprised :) https://github.com/vim/vim/blob/master/runtime/filetype.vim#L1470 -- Morten Linderud PGP: 9C02FF419FECBE16
(Tue, Mar 05, 2019 at 06:26:45AM -0500) james harvey via arch-general :
I'd like to post the following issue at: https://github.com/vim/vim/issues/new
Wanted to see if there were any objections from staff, like if even though the error highlighting is technically wrong, if it's desired to be left as-is to discourage 'pkgname' being a single element array or 'SKIP' usage when inappropriate, etc.
Hi James, I think you’re targetting the wrong project: immae at immae ~ $ pacman -Qo /usr/share/vim/vimfiles/syntax/PKGBUILD.vim /usr/share/vim/vimfiles/syntax/PKGBUILD.vim is owned by pacman-contrib 1.1.0-1
PKGBUILD probably doesn’t exist in vim’s project ;) -- Ismael
One of the team intends to do a complete rewrite the syntax file with a "Vim master". :) -- Best, polyzen
participants (4)
-
Daniel M. Capella
-
Ismael Bouya
-
james harvey
-
Morten Linderud