[arch-general] hylafax PKGBUILD contains typo - '$spkgdir' line 55
Guys, The hylafax pkgbuild needs to be fixed. (/var/abs/extra/hylafax/PKGBUILD) There is an extra 's' in $spkgdir on lines 54-55. Reads: install -D -m 755 $srcdir/${pkgname}-${pkgver}/util/notify.awk \ $spkgdir/var/spool/hylafax/bin/notify.awk Should read: install -D -m 755 $srcdir/${pkgname}-${pkgver}/util/notify.awk \ $pkgdir/var/spool/hylafax/bin/notify.awk Currently it tries to remove the real '/var/spool/hylafax/bin/notify.awk' resulting in the error: make[1]: Leaving directory `/home/david/tmp/hylafax/src/hylafax-6.0.5/po' install: cannot remove `/var/spool/hylafax/bin/notify.awk': Permission denied ==> ERROR: A failure occurred in package(). Aborting... If you build with write permission for /var/spool/hylafax (i.e. root) you would have removed the notify.awk file from the installed version of hylafax. (who builds as root :) -- David C. Rankin, J.D.,P.E.
On 10/08/11 07:21, David C. Rankin wrote:
Guys,
The hylafax pkgbuild needs to be fixed. (/var/abs/extra/hylafax/PKGBUILD) There is an extra 's' in $spkgdir on lines 54-55. Reads:
Reporting issues to the mailing list is a waste of time as the maintainer of the package is unlikely to see it. Use the bug tracker. Allan
On 08/09/2011 04:29 PM, Allan McRae wrote:
On 10/08/11 07:21, David C. Rankin wrote:
Guys,
The hylafax pkgbuild needs to be fixed. (/var/abs/extra/hylafax/PKGBUILD) There is an extra 's' in $spkgdir on lines 54-55. Reads:
Reporting issues to the mailing list is a waste of time as the maintainer of the package is unlikely to see it. Use the bug tracker.
Allan
Gotcha: https://bugs.archlinux.org/task/25484 -- David C. Rankin, J.D.,P.E.
On Tue, Aug 9, 2011 at 4:21 PM, David C. Rankin
...
install -D -m 755 $srcdir/${pkgname}-${pkgver}/util/notify.awk \ $spkgdir/var/spool/hylafax/bin/notify.awk
...
If you build with write permission for /var/spool/hylafax (i.e. root) you would have removed the notify.awk file from the installed version of hylafax. (who builds as root :)
100% unrelated, but this is why my dirs *always* have a trailing `/` ... better to fail trying to remove a nonexistent `var/...` then *gasp* the alternative `/var/<oops>` .... ... i wish everyone else did this too. make it very easy to detect/react when absolute fragments are appended (causes a double `//`), naturally relative, fails more gracefully, obviates the fact it's not a file, and avoids hacky code trying to remove PRECEDING `/`s that MAY or MAY NOT exist (very annoying). but yeah ... bugtracker ;-) -- C Anthony
participants (3)
-
Allan McRae
-
C Anthony Risinger
-
David C. Rankin