On Fri, Feb 26, 2010 at 12:34 PM, Xavier Chantry <chantry.xavier@gmail.com> wrote:

On Fri, Feb 26, 2010 at 8:20 PM, Thayer Williams <thayerw@gmail.com> wrote:

...

Bumping this for feedback.  7z correctly unzips localized win32 zip files, but bsdtar/unzip cannot.  Is that good enough to remove the conflicting win32 patches from unzip?

Links to feature request for adding support to bsdtar / unzip would be good. If I understand correctly, there should already be some for unzip. And what about bsdtar ?

Sorry Xavier, all of that info was in my original email, included below for reference. The patch we currently use for unzip has been rejected more than once upstream and it is conflicting with zsh autocompletion. bsdtar apparently doesn't support localized win32 zip files either, but p7zip does. If the bsdtar maintainer wants to take it upstream that's fine, but in the meantime I'd like to move forward with the unzip fix unless we have a reason not to. On Tue, Jan 19, 2010 at 12:06 PM, Thayer Williams <thayerw@gmail.com> wrote:

Hoping for some feedback here from more experienced devs on this one:

At some point we began patching unzip with additional flags, allowing it to properly extract UTF-encoded zip files made on the win32 platform. Apparently this has broken zsh autocompletion features. Similar unzip patches have been submitted upstream and all have been rejected. Upstream has considered adding proper support, but has stopped short of committing to it.

The question is do we keep the patch and make this a zsh issue, or do we remove the patch, fixing zsh in the process and screwing some win32 zip files?

More info:

http://bugs.archlinux.org/task/17503 http://bugs.archlinux.org/task/15256