On Sat, Mar 17, 2012 at 6:01 PM, Lukas Fleischer <archlinux@cryptocrack.de> wrote:
On Sat, Mar 17, 2012 at 11:44:27AM +0100, Tom Gundersen wrote:
# Check local filesystems fsck_all() { + [[ -f /forcefsck ]] || in_array forcefsck $(< /proc/cmdline) && FORCEFSCK="-f"
If you're trying to make things clearer, I'd probably convert this one into an if statement as well. The use of "||" and "&&" might be a bit confusing if you don't have a closer look here.
I'm not too bothered about this, but next time someone touches that line we could change it into an "if".
+ + if [[ ! -n $FORCEFSCK ]] && { [[ -f /fastboot ]] || in_array fastboot $(< /proc/cmdline); }; then + return
No return value? :) We use the return value of fsck_all() later so it might be worthwhile to explicitly return 0/1 here.
Thanks! Fixed.
Note that moving these checks into fsck_all() will also result in the "Checking Filesystems" being displayed even if the fastboot option is used (just saying, even though you were probably aware of that when writing this patch).
Yeah, I thought that was ok. We might add some message saying that it is being skipped, but let's keep it like it is for now. -t