I wrote these patches while reparing a new release of Parabola's dev tools. - The first 5 commits fix issues that I found. - The next 3 make it harder for future editors to accidentally break things, but make no real changes. - The final 5 commits add a "make check" target that runs shellcheck over the code, and then make minor changes to make shellcheck come back mostly clean. All of the changes should be pretty minor and non-controvercial; quoting strings and such. The things that shellcheck continues to warn about are things that might be *actual* issues. Happy hacking, ~ Luke Shumaker Luke Shumaker (13): makechrootpkg: delete_chroot: Fix the is-btrfs-subvolume check. makechrootpkg: sync_chroot: make usage easier to understand. makechrootpkg: sync_chroot: Make more general. lib/archroot.sh: subvolume_delete_recursive: support arbitrary recursion makechroot: download_sources: Accept makepkg_owner as an argument Makefile: add .DELETE_ON_ERROR: Makefile: m4_changequote([[[,]]]) to avoid accidental quoting. makechrootpkg: Add a comment warning about a bug in "sudo -i" Makefile: Add a simple 'check' target that runs shellcheck Make purely stylistic changes to make shellcheck happier. Quote strings that shellcheck warns about. Make slightly more involved changes to make shellcheck happy. Add `# shellcheck` directives to quiet shellcheck, add PKGBUILD.proto Makefile | 7 +++-- PKGBUILD.proto | 48 ++++++++++++++++++++++++++++++++ arch-nspawn.in | 22 ++++++++------- archrelease.in | 6 ++-- archrm.in | 2 +- bash_completion.in | 6 ++-- checkpkg.in | 13 +++++---- commitpkg.in | 41 +++++++++++++++------------ crossrepomove.in | 14 ++++++---- find-libdeps.in | 8 +++--- finddeps.in | 11 ++++---- lddd.in | 20 +++++++------- lib/archroot.sh | 30 +++++++++++++++++--- lib/common.sh | 42 ++++++++++++++++++---------- lib/valid-tags.sh | 3 ++ makechrootpkg.in | 80 +++++++++++++++++++++++++++++------------------------ makepkg-i686.conf | 3 ++ makepkg-x86_64.conf | 3 ++ mkarchroot.in | 6 ++-- rebuildpkgs.in | 12 +++++--- 20 files changed, 248 insertions(+), 129 deletions(-) create mode 100644 PKGBUILD.proto -- 2.12.2