On Saturday 26 March 2011 16:31:57 Dave Reisner wrote:
* adhere to a consistant vim modeline * use top-right/bottom-left braces for functions
Signed-off-by: Dave Reisner <d@falconindy.com> --- functions | 207 ++++++++++++++-------------- network | 445 +++++++++++++++++++++++++++++------------------------------ rc.multi | 12 +- rc.shutdown | 12 +- rc.single | 14 +- rc.sysinit | 40 +++--- 6 files changed, 359 insertions(+), 371 deletions(-)
[...]
-ifdown() -{ - if [[ ! $1 ]]; then - echo "usage: $0 ifdown <interface_name>" - return 1 - fi - eval ifcfg="\$${1}" - if [[ $ifcfg = dhcp && -f /var/run/dhcpcd-${1}.pid ]]; then - /sbin/dhcpcd -k ${1} >/dev/null 2>&1 - fi - # Always bring the interface itself down - /sbin/ifconfig ${1} down >/dev/null 2>&1 +ifdown() { + if [[ ! $1 ]]; then + echo "usage: $0 ifdown <interface_name>" + return 1 + fi + eval ifcfg="\$${1}" + if [[ $ifcfg = dhcp && -f /var/run/dhcpcd-${1}.pid ]]; then + /sbin/dhcpcd -k ${1} >/dev/null 2>&1
Here you introduced a whitespace error at the end of the line. In general: Any reason why the vim modeline was not added to all the files (netfs/minilog.c)? I guess someone might complain that this will cause lots of conflicts if they have lots of pending patches, except for that it looked fine by me. Cheers, Tom