On 05/18/2012 05:50 PM, Tom Gundersen wrote:
On Fri, May 18, 2012 at 6:22 PM, Matthew Monaco <dgbaley27@0x01b.net> wrote:
From: Matthew Monaco <matthew.monaco@0x01b.net>
We'll have the late hook in the initrd automatically map all volumes with an %early tag. Skipping them here is up for discussion though, as they should be skipped if they're mapped anyway.
I don't like this patch.
Actually, not sure if I like the %early tag in the first place (is this the syntax other distro's use as well?). I don't think there is any need for marking things as %early, the only time the initrd might read the real crypttab is after the rootfs has been mounted, and then it's only job is to set up whatever is needed to mount /usr. Or am I missing some setup we want to support where the initrd can not figure out which volumes to map? Notice that encrypting /usr is almost entirely pointless, so we should be very hesitant to add syntax just to support this.
I did this in response for two feature requests asking for more flexibility in the initrd. Without much code the %early tag allows for an arbitrary number of mounts. Others are not using tags like this, but sysd ignores unknown options so it should be safe.