On Tue, Sep 27, 2011 at 11:41:31AM +0200, Tom Gundersen wrote:
On Tue, Sep 27, 2011 at 3:22 AM, Dave Reisner <d@falconindy.com> wrote:
This is a constant which will never vary based on setup. Do it during the build to save the forks at runtime.
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
Acked-by: Tom Gundersen <teg@jklm.no>
BUT:
Not that this might cause issues with the next release of busybox. They have changed things in evil ways and don't seem to want to revert it.
A foolproof way to solve the problem is to loop over the list of apps (which busybox will give you) and create the symlinks manually.
The downside of that is that all links will end up in the same dir, but the distinctions between {,/usr}/{,s}bin don't make any sense in an initramfs anyway, so that should be fine.
Yeah, I recall you mentioning this. I don't want to make a change that's going to potentially break in the future because of upstream. I'm inclined to sit on this bit of patchwork and push it to my working branch until busybox figures out wtf it is they're going to mangle next. We're not making any radical changes here -- what we have right now works, and this is really only to avoid a few forks at bootstrap. Regardless, you're right that looping over the included applet list is a better way to do this. I think that it's also advantageous because then we can symlink everything into /bin and let user overrides take place in /usr, without having to involve /usr/local (which is a bit odd, imo). d