Eli Schwartz wrote:
if [[ -n ${BUILDDIR} ]]; then cache=${BUILDDIR}/$(__getCheckSum PKGBUILD) - if [[ -d ${cache} ]]; then + if __isGlobfile "${cache}"/*"${PKGEXT}"; then cp -Lv ${cache}/*${PKGEXT}{,.sig} ${pkgdest} return 0 else
We're not testing whether or not globs work, we're testing whether or not check_pkgrepos properly detects pre-existing packages (which it does via globs). Using __isGlobfile() here will no longer be useful information once $PKGEXT is only ever something from makepkg. So it doesn't make sense to add code that will be almost immediately removed.
The glob I was using it for wasn't PKGEXT(s), it was the '*' that's right there in the argument!
Maybe: ... if cp -Lv ${cache}/*${PKGEXT}{,.sig} ${pkgdest} 2>/dev/null; then return 0 else
This would avoid the need for __isGlobfile function altogether.
I like that! Good idea!
I'd also like a more descriptive commit message. Don't tell me what you changed, tell me why you changed it. :p
Ok, I'll go in to that more. -- Happy hacking, ~ Luke Shumaker