On Tue, Jul 3, 2012 at 3:11 AM, Jouke Witteveen <j.witteveen@gmail.com> wrote:
On Tue, Jul 3, 2012 at 3:00 AM, Henrik Hallberg <henrik@k2h.se> wrote:
On Tue, Jul 03, 2012 at 01:16:07AM +0200, Jouke Witteveen wrote:
These changes look fine to me, but shitty code remains shitty code. I'm not a big fan of the current organization of the code and the distribution across connections/wireless and 8021x.
So far, it has seemed better to submit small patches rather than larger ones. I could very well have spent time doing a larger refactoring. It seems to me, however, that I am not yet enough versed in the code and its' style to make an attempt with reasonable chances to pass review.
This solves the problem of the extra calls only. A small, easily reviewable patch. The code behaves better with it, than without it.
/ H
There's some comments in lines 73-75. They were ignored in commit 0d4c3. Reverting said commit would solve this problem too. Any thoughts what would be better? I like the old code, but the commit message suggests that wpa_supplicant doesn't reassociate properly (at least, that it didn't back then). If wpa_supplicant has improved, I'm in favor of restoring the old code, which looks more reasonable to me. Otherwise, the proposed patch will do.
- Jouke
Hello all, After some code-shuffling without rewriting everything (something I don't have the time for), netcfg is in a new and exiting state that needs testing. I would like to just push 2.8.6 rc1 to [testing] for this, but Florian noted that we normally don't put release candidates in [testing]. Is this the case for arch-projects too? In that case, can people please test the new netcfg? There are two ways of installing: = Bleeding edge: git clone git://projects.archlinux.org/netcfg.git cd netcfg make install = 2.8.6 rc1 git clone git://projects.archlinux.org/netcfg.git cd netcfg git checkout tags/2.8.6rc1 make pkgbuild mv PKGBUILD netcfg-2.8.6rc1.tar.xz /tmp cd /tmp makepkg pacman -U netcfg-2.8.6rc1-1-any.pkg.tar.xz (the last step as root) Regards, - Jouke