Am 03.04.2012 12:00, schrieb Thomas Bächler:

Am 03.04.2012 11:47, schrieb Thomas Bächler:

...

Am 03.04.2012 11:32, schrieb Jouke Witteveen:

...

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "netcfg network scripts repository".

The annotated tag, 2.7.2 has been created at 6d5806b2797dbf7a95d2821d8fba80cb76e0c20c (tag) tagging 3fab6603d9e31b8887e2d7787edd3da32df425e9 (commit) replaces 2.7.1 tagged by Jouke Witteveen on Tue Apr 3 11:05:20 2012 +0200

I think you missed the patches I sent on March 27.

I nobody beats me to it, I'll package the 2.7.2 release tonight.

Okay, seems you just forgot to push before push --tags, nevermind :)

Oh, I am blind again, my patches are still missing. So do mind (this is the last confused mail, I swear).

On 03.04.2012 12:30, Jouke Witteveen wrote:

On Tue, Apr 3, 2012 at 11:47, Thomas Bächler wrote:

...

I think you missed the patches I sent on March 27.

I nobody beats me to it, I'll package the 2.7.2 release tonight.

Indeed I did, sorry! I presume it is too late to move the tag?

Yeah you can't move tags in git. Just merge them and release a 2.7.3 (better) or 2.7.2.1. Also don't top post and I can't find your gpg key on pgp.mit.edu [1]. [1]: http://pgp.mit.edu:11371/pks/lookup?search=j.witteveen%40gmail.com&op=index -- Florian Pritz

On Tue, Apr 3, 2012 at 12:39, Florian Pritz wrote:

On 03.04.2012 12:34, Florian Pritz wrote:

...

On 03.04.2012 12:30, Jouke Witteveen wrote:

...

On Tue, Apr 3, 2012 at 11:47, Thomas Bächler wrote:

...

I think you missed the patches I sent on March 27.

I nobody beats me to it, I'll package the 2.7.2 release tonight.

Indeed I did, sorry! I presume it is too late to move the tag?

Yeah you can't move tags in git. Just merge them and release a 2.7.3 (better) or 2.7.2.1.

Also don't top post and I can't find your gpg key on pgp.mit.edu [1].

[1]: http://pgp.mit.edu:11371/pks/lookup?search=j.witteveen%40gmail.com&op=index

You also didn't "git am" his patches so you squashed both into 1 and you lost the commit messages which can be quite important when trying to figure out why a certain change has been made.

-- Florian Pritz

Anymore patches for 2.7.3? Anyone? I have now published the key. The commits didn't am, so I did them manually. I added a debug line too.

Am 03.04.2012 12:39, schrieb Florian Pritz:

...

...

Indeed I did, sorry! I presume it is too late to move the tag?

Yeah you can't move tags in git. Just merge them and release a 2.7.3 (better) or 2.7.2.1.

Also don't top post and I can't find your gpg key on pgp.mit.edu [1].

[1]: http://pgp.mit.edu:11371/pks/lookup?search=j.witteveen%40gmail.com&op=index

You also didn't "git am" his patches so you squashed both into 1 and you lost the commit messages which can be quite important when trying to figure out why a certain change has been made.

Well yes, this is important. Emailed patches must be git-am'ed, not just applied and re-commited.