Re: [arch-projects] [tur-users] Proposal of changes for AUR
Sorry it's just a giant list, I basically just copy/pasted out of my chat with louipc on irc.
Thanks for creating this list!
I would like to request that folks test against the test site:
I have merged the pending changes for 1.4.0 into the git master. You can look at the detailed change list at:
http://projects.archlinux.org/git/?p=aur.git;a=shortlog;h=master
Please let me know if you see anything broken or not working. I plan to release 1.4.0 either tomorrow or Monday!
At this point, the only other things I will merge into master before the release are bigfixes or regressions to the current material. So send me a patch or a commit ID if you think there's a patch I should include before release.
Thanks! - P
Here's a bug: pages other than index.php show $Id$ instead of Version: 1.4.0
Category and Name are squashed together (table header in packages.php). Same for Votes Voted Description
On 9/29/07, Paul Mattal paul@mattal.com wrote:
Sorry it's just a giant list, I basically just copy/pasted out of my chat with louipc on irc.
Thanks for creating this list!
I would like to request that folks test against the test site:
I have merged the pending changes for 1.4.0 into the git master. You can look at the detailed change list at:
http://projects.archlinux.org/git/?p=aur.git;a=shortlog;h=master
Please let me know if you see anything broken or not working. I plan to release 1.4.0 either tomorrow or Monday!
At this point, the only other things I will merge into master before the release are bigfixes or regressions to the current material. So send me a patch or a commit ID if you think there's a patch I should include before release.
Thanks!
- P
arch-projects mailing list arch-projects@archlinux.org http://archlinux.org/mailman/listinfo/arch-projects
Here's a bug: pages other than index.php show $Id$ instead of Version: 1.4.0
Category and Name are squashed together (table header in packages.php). Same for Votes Voted Description
Fix version strings. Now you should only have to change AUR_VERSION in web/lib/config.inc and updates will be reflected across the site. KISS ftw. http://git.nagi-fanboi.net/?p=aur.git;a=commitdiff;h=6ec55dc3523a2cc5789f662...
About the second bug, I don't see it on my local install so I'm not sure how to fix it.
- tardo
tardo@nagi-fanboi.net wrote:
Here's a bug: pages other than index.php show $Id$ instead of Version: 1.4.0
Category and Name are squashed together (table header in packages.php). Same for Votes Voted Description
Fix version strings. Now you should only have to change AUR_VERSION in web/lib/config.inc and updates will be reflected across the site. KISS ftw. http://git.nagi-fanboi.net/?p=aur.git;a=commitdiff;h=6ec55dc3523a2cc5789f662...
The problem with this fix is that config.inc is intentionally NOT upgraded when we upgrade code, so it will fall to the user to have to remember to upgrade the version string which is exactly what we don't want.
So maybe we could put the define in aur.inc instead, or someplace else that always gets included? I think aur.inc is always included.
- P
On 9/30/07, Paul Mattal paul@mattal.com wrote:
tardo@nagi-fanboi.net wrote:
Here's a bug: pages other than index.php show $Id$ instead of Version: 1.4.0
Category and Name are squashed together (table header in packages.php). Same for Votes Voted Description
Fix version strings. Now you should only have to change AUR_VERSION in web/lib/config.inc and updates will be reflected across the site. KISS ftw. http://git.nagi-fanboi.net/?p=aur.git;a=commitdiff;h=6ec55dc3523a2cc5789f662...
The problem with this fix is that config.inc is intentionally NOT upgraded when we upgrade code, so it will fall to the user to have to remember to upgrade the version string which is exactly what we don't want.
So maybe we could put the define in aur.inc instead, or someplace else that always gets included? I think aur.inc is always included.
- P
How about we make a one time change to config.inc to include version.inc at the top. Then have a new file (version.inc) with nothing more than a define for the version variable.
aur.inc is messy enough. I would hate to start getting more random defines in there.
eliott wrote:
On 9/30/07, Paul Mattal paul@mattal.com wrote:
tardo@nagi-fanboi.net wrote:
Here's a bug: pages other than index.php show $Id$ instead of Version: 1.4.0
Category and Name are squashed together (table header in packages.php). Same for Votes Voted Description
Fix version strings. Now you should only have to change AUR_VERSION in web/lib/config.inc and updates will be reflected across the site. KISS ftw. http://git.nagi-fanboi.net/?p=aur.git;a=commitdiff;h=6ec55dc3523a2cc5789f662...
The problem with this fix is that config.inc is intentionally NOT upgraded when we upgrade code, so it will fall to the user to have to remember to upgrade the version string which is exactly what we don't want.
So maybe we could put the define in aur.inc instead, or someplace else that always gets included? I think aur.inc is always included.
- P
How about we make a one time change to config.inc to include version.inc at the top. Then have a new file (version.inc) with nothing more than a define for the version variable.
aur.inc is messy enough. I would hate to start getting more random defines in there.
arch-projects mailing list arch-projects@archlinux.org http://archlinux.org/mailman/listinfo/arch-projects
I'm not against either idea, but if a user checks out a copy of AUR and modifies then uses it, it should be his responsibility to change (or remove) the version number. Adding a version.inc still requires the user to modify it himself, and config.inc is ignored by git anyway, so it shouldn't affect the development process (i.e. only Paul should have to worry about changing the version number on the real AUR site).
Either way, if you come to a consensus, a patch is easy to write for either.
- tardo
How about we make a one time change to config.inc to include version.inc at the top. Then have a new file (version.inc) with nothing more than a define for the version variable.
aur.inc is messy enough. I would hate to start getting more random defines in there.
I'm thinking it should be version.php or something but I still don't think it should be in the config file. Maybe it could be in aur.inc. About aur.inc being messy, why not then clean it up? I have one commit that takes a step towards that goal.
2e27c1f695c42408efb6a77d464331ab9440e604
tardo wrote:
I'm not against either idea, but if a user checks out a copy of AUR and modifies then uses it, it should be his responsibility to change (or remove) the version number. Adding a version.inc still requires the user to modify it himself, and config.inc is ignored by git anyway, so it shouldn't affect the development process (i.e. only Paul should have to worry about changing the version number on the real AUR site).
Either way, if you come to a consensus, a patch is easy to write for either.
I've taken tardo's patch and then modified it to include a version.inc from aur.inc.
http://projects.archlinux.org/git/?p=aur.git;a=commit;h=22fcea238f0ede3def93...
I think this addresses everyone's concerns, but is perhaps the least elegant solution! But it does work.
This needn't be the end of this issue, but I didn't want bikeshed painting to stall this release. If we come up with something better, we can do it for next version.
- P
participants (6)
-
eliott
-
Loui
-
nesl247
-
Paul Mattal
-
tardo
-
tardo＠nagi-fanboi.net