As far as I can tell, this was never used.

In commit 9b56647abc8dc33bf138d4b260b103c8d9265b7d the parsepkgbuild script was switched from defining a PATH as a directory in /tmp, to actually passing in a PATH=/dummy to `env -i`... which makes sense as the defined PATH did not used to be used. However, even before that, it's not safe to use mkdir -p in order to define a restricted shell without access to the PATH, as it's not guaranteed to be owned by the creator.

In any event, the time for mkdir -p is long past.

Signed-off-by: Eli Schwartz eschwartz@archlinux.org --- parsepkgbuild | 2 -- 1 file changed, 2 deletions(-)

diff --git a/parsepkgbuild b/parsepkgbuild index 009e89e..bedb0de 100755 --- a/parsepkgbuild +++ b/parsepkgbuild @@ -1,7 +1,5 @@ #!/bin/bash

-mkdir -p /tmp/parsepkgbuild - source /etc/makepkg.conf

PARSE_PKGBUILD_PATH=${PARSE_PKGBUILD_PATH:-/usr/share/namcap}