[arch-projects] Fwd: [pacman-dev] [ABS] Add --verbose flag to gem in PKGBUILD-rubygem.proto
Forwarding. The arch-projects list is probably a better place for this these days. Allan -------- Original Message -------- Subject: [pacman-dev] [ABS] Add --verbose flag to gem in PKGBUILD-rubygem.proto Date: Thu, 21 Apr 2011 19:57:12 +0800 From: talki walki <lolilolicon@gmail.com> Reply-To: Discussion list for pacman development <pacman-dev@archlinux.org> To: pacman-dev@archlinux.org Without --verbose the `gem install` outputs way too little information about what is being done. I suggest this patch: --- PKGBUILD-rubygem.proto 2011-04-21 11:47:48.254153621 +0000 +++ PKGBUILD-rubygem.proto 2011-04-21 11:48:17.673994240 +0000 @@ -26,7 +26,7 @@ # makepkg will exit with an error when sourcing the PKGBUILD local _gemdir="$(ruby -rubygems -e'puts Gem.default_dir')" - gem install --ignore-dependencies -i "$pkgdir$_gemdir" GEMNAME-$pkgver.gem + gem install --ignore-dependencies --verbose -i "$pkgdir$_gemdir" -n "$pkgdir"/usr/bin GEMNAME-$pkgver.gem } # vim:set ts=2 sw=2 et: I've already updated the wiki: https://wiki.archlinux.org/index.php/Ruby_Gem_Package_Guidelines#Example_PKG...
On 21:44 Sun 24 Apr , Allan McRae wrote:
Forwarding. The arch-projects list is probably a better place for this these days.
Allan
-------- Original Message -------- Subject: [pacman-dev] [ABS] Add --verbose flag to gem in PKGBUILD-rubygem.proto Date: Thu, 21 Apr 2011 19:57:12 +0800 From: talki walki <lolilolicon@gmail.com> Reply-To: Discussion list for pacman development <pacman-dev@archlinux.org> To: pacman-dev@archlinux.org
Without --verbose the `gem install` outputs way too little information about what is being done. I suggest this patch:
Hmm, I think that I might have to disagree with you on the --verbose option. While useful to some, I do not believe it is a good default option. You lose sight of the bigger picture when using --verbose. Also, you failed to mention in the subject, or body, that this patch sets the binary directory with the -n option. Putting _all_ ruby gem scripts in /usr/bin is questionable, IMHO; however, since gem's default binary directory is /usr/bin and is unchanged in Arch, I will add the -n option. Not to mention, I see this is being done anyway in github-gem and this option is a much saner way of doing that. Thanks, matt
--- PKGBUILD-rubygem.proto 2011-04-21 11:47:48.254153621 +0000 +++ PKGBUILD-rubygem.proto 2011-04-21 11:48:17.673994240 +0000 @@ -26,7 +26,7 @@ # makepkg will exit with an error when sourcing the PKGBUILD local _gemdir="$(ruby -rubygems -e'puts Gem.default_dir')"
- gem install --ignore-dependencies -i "$pkgdir$_gemdir" GEMNAME-$pkgver.gem + gem install --ignore-dependencies --verbose -i "$pkgdir$_gemdir" -n "$pkgdir"/usr/bin GEMNAME-$pkgver.gem }
# vim:set ts=2 sw=2 et:
I've already updated the wiki: https://wiki.archlinux.org/index.php/Ruby_Gem_Package_Guidelines#Example_PKG...
participants (2)
-
Allan McRae
-
matt mooney