On Tue, May 3, 2011 at 7:53 PM, Grigorios Bouzakis wrote:

Kwpolska wrote:

...

(a reprint of FS#24074)

...

The initscripts' /etc/rc.d/functions uses colors with a black background. It does not look very nice on a transparent black terminal. A patch is included.

tomegun requested a git patch to be sent here.  It's in the attachments section.

See: https://bugs.archlinux.org/task/17225 https://bugs.archlinux.org/task/1186 https://bugs.archlinux.org/task/16996

Thanks for the pointers Greg! I guess this means we will not implement this feature. Cheers, Tom

Seblu wrote:

On Tue, May 3, 2011 at 7:53 PM, Grigorios Bouzakis wrote:

...

Kwpolska wrote:

...

(a reprint of FS#24074)

...

The initscripts' /etc/rc.d/functions uses colors with a black background. It does not look very nice on a transparent black terminal. A patch is included.

tomegun requested a git patch to be sent here.  It's in the attachments section.

See: https://bugs.archlinux.org/task/17225 Closed as duplicate.

...

https://bugs.archlinux.org/task/1186 Close because issue is resolved.

...

https://bugs.archlinux.org/task/16996 Closed bevause issue is not present.

But i agree with greg an issue present. Just run rc with a white term (what should be banned).

I don't have tested his patch, but it looks good. This is a well know error with coloring term.

The patch reverts the one from https://bugs.archlinux.org/task/1186 so it doesnt really look good. As Aaron said in https://bugs.archlinux.org/task/16996#comment53730 for a slightly different patch: https://bugs.archlinux.org/task/16996?getfile=4307 "The current choices are: unreadable text on white backgrounds, or an unattractive black block. I'll go with the unattractive and READABLE choice here." https://bugs.archlinux.org/task/16996#comment53730 which applies to this patch as well. ---- Greg

On Wed, May 4, 2011 at 12:44 AM, Grigorios Bouzakis wrote:

Grigorios Bouzakis wrote:

...

Seblu wrote:

...

On Tue, May 3, 2011 at 7:53 PM, Grigorios Bouzakis wrote:

...

Kwpolska wrote:

...

(a reprint of FS#24074)

...

The initscripts' /etc/rc.d/functions uses colors with a black background. It does not look very nice on a transparent black terminal. A patch is included.

tomegun requested a git patch to be sent here.  It's in the attachments section.

See: https://bugs.archlinux.org/task/17225 Closed as duplicate.

...

https://bugs.archlinux.org/task/1186 Close because issue is resolved.

...

https://bugs.archlinux.org/task/16996 Closed bevause issue is not present.

But i agree with greg an issue present. Just run rc with a white term (what should be banned).

I don't have tested his patch, but it looks good. This is a well know error with coloring term.

The patch reverts the one from https://bugs.archlinux.org/task/1186 so it doesnt really look good. As Aaron said in https://bugs.archlinux.org/task/16996#comment53730 for a slightly different patch: https://bugs.archlinux.org/task/16996?getfile=4307 "The current choices are: unreadable text on white backgrounds, or an unattractive black block. I'll go with the unattractive and READABLE choice here." https://bugs.archlinux.org/task/16996#comment53730 which applies to this patch as well.

Errm sorry got carried away. The proposed patch is not entirely the same as any of the previous ones.

But it's still doesn't solve the issue. I will propose one. -- Sébastien Luttringer www.seblu.net

On Wed, May 04, 2011 at 02:05:12AM +0300, Grigorios Bouzakis wrote:

But despite that the proposed scheme doesn't work in white terminals. See attached screenshot. Sorry for the multiple emails.

---- Greg

Well, this patch seems to be incorrect, but I think I can find a better one. The current way of rc.d scripts' display is *forcing* white bold text. But this is not the right way, we shall display the current text color in bold. This is possible thanks to this code: \033[1m The next thing to do with this one is to find a nice color that will work fine in $C_H2. It's (most of the time) a light cyan color, barely readable on a white terminal. A patch resolving *most* of the issues (expect $C_H2) is included. -- Cheers, -- Kwpolska (http://kwpolska.co.cc) O< ascii ribbon campaign - stop html mail - www.asciiribbon.org