This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official devtools repository". The branch, master has been updated via c1a056c9a8f42e1a8e1f66b265b7ccbd1a2cb1ee (commit) via 747e8ffc8d02bc8726d6f336ebbe7ecf05e9fd38 (commit) via fb40b587729a6f596e674da8d3ea8397c65a0060 (commit) via f9d9db474a68acee7fcb939b03b0a1db04017fe2 (commit) via 253bb4c8d4019d17f83632a196e233fa10e2bf9e (commit) via 189efd3bc0b4fe87aae088b6c46ebb8a172caf28 (commit) via cb35d74f8ce0e1ad489c59d608877e4d6b34ca85 (commit) via 14d5e1c21b69975a8d30aba059e1012595d48bba (commit) via ae82f88e51d9ec14d28b6e0d73675767af6aff75 (commit) via f55786b7a83a1f70920616d56231bb722f2888d9 (commit) via 8ff247de13ef9b9ff311f6eff46ba3a871984fae (commit) via d4f09b2c7b36c78500bec769c98ebc04c0a19e7d (commit) via d33344081006d3f653651f0895b143c305e9e7c7 (commit) via 997bc1dc0db12ee5791bfb74f07c91ce10ed7cfd (commit) from f73c1f172f93b734ec46e861ed1ba8fbb05e65cf (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c1a056c9a8f42e1a8e1f66b265b7ccbd1a2cb1ee Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sun Apr 2 04:10:02 2017 -0400 lib/common.sh: Make it safe to include multiple times. This is similar to common C #ifdef guards. I was tempted to wrap the entire thing in the if/fi, rather than use 'return' to bail early. However, that means it won't execute anything until after it reaches 'fi'. And if `shopt -s extglob` isn't executed before parsing, then it will syntax-error on the extended globs. One solution would have been to move `shopt -s extglob` up above the include-guard. But the committed solution is all-around simpler. commit 747e8ffc8d02bc8726d6f336ebbe7ecf05e9fd38 Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sun Apr 2 04:10:01 2017 -0400 lib/common.sh: Adjust to work properly with `set -u`. commit fb40b587729a6f596e674da8d3ea8397c65a0060 Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sun Apr 2 04:10:00 2017 -0400 makechrootpkg: install_pkg was an unused variable commit f9d9db474a68acee7fcb939b03b0a1db04017fe2 Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sun Apr 2 04:09:59 2017 -0400 makechrootpkg: Quote directory passed to `rm -rf`. commit 253bb4c8d4019d17f83632a196e233fa10e2bf9e Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sun Apr 2 04:09:58 2017 -0400 makechrootpkg: /chrootbuild: accept makepkg_args as arguments rather than embedding. commit 189efd3bc0b4fe87aae088b6c46ebb8a172caf28 Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sun Apr 2 04:09:56 2017 -0400 makechrootpkg: usage(): Display the actual default makepkg flags. It was displaing the value of the `makepkg_args` variable, which may have already been changed by the argument parsing by the time it gets to `-h`. Now there is a separate `default_makepkg_args` variable. commit cb35d74f8ce0e1ad489c59d608877e4d6b34ca85 Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sun Apr 2 04:09:55 2017 -0400 Avoid using string interpolation; use printf format strings instead. This involves extending the signature of lib/common.sh's `stat_busy()`, `lock()`, and `slock()`. The `mesg=$1; shift` in stat_busy even suggests that this is what was originally intended from it. commit 14d5e1c21b69975a8d30aba059e1012595d48bba Author: Luke Shumaker <lukeshu@parabola.nu> Date: Tue Mar 28 16:13:18 2017 -0400 Add a "License:" tag to all code files. In cases where there is no license specified, the file is tagged as "License: Unspecified". Obviously, that is not ideal, but it highlights the fact, and I hope that it encourages whoever has the authority to specify the license to do so. On that note, to anyone who may have the authority to specify the license of files in devtools: the current licence of many files is GPLv2 with no option for later versions; I impore you to re-license them to have the "or any later version" option. commit ae82f88e51d9ec14d28b6e0d73675767af6aff75 Author: Luke Shumaker <lukeshu@parabola.nu> Date: Tue Mar 28 15:41:33 2017 -0400 commitpkg: Adjust fancy quoting/escaping to not confuse Emacs. It was confusing Emacs and screwing up the syntax highlighting and auto-indentation for the rest of the file. commit f55786b7a83a1f70920616d56231bb722f2888d9 Author: Luke Shumaker <lukeshu@lukeshu.com> Date: Tue Mar 28 15:41:32 2017 -0400 Add '#!/hint/bash' headers to non-executable bash files. This provides a cross-editor hint that the syntax of the file is Bash. commit 8ff247de13ef9b9ff311f6eff46ba3a871984fae Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sat Mar 25 12:34:41 2017 -0400 lib/common.sh: Make setup_workdir()/cleanup() safe for programs to not use commit d4f09b2c7b36c78500bec769c98ebc04c0a19e7d Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sat Mar 25 12:34:40 2017 -0400 lib/common.sh: lock, slock: Create directories for locks if necessary. commit d33344081006d3f653651f0895b143c305e9e7c7 Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sat Mar 25 12:34:39 2017 -0400 lib/common.sh: lock, slock: Allow locks to be inherited. Allow for locks to be inherited. Inheriting the lock is something that mkarchroot could do previously, but has since lost the ability to do. This allows for the programs to be more compos-able. Do this by instead of unconditionally opening $file on $fd, first check if $file is already open on $fd; and go ahead use it if it is. The naive way of doing this would be to `$(readlink /dev/fd/$fd)` and compare that to `$file`. However, if `$file` is itself a symlink; or there is a symlink somewhere in the path to `$file`, then this could easily fail. Instead, check `[[ "/dev/fd/$fd" -ef "$file" ]]`. Even though the Bash documentation (`help test`) says that `-ef` checks for if the two files are hard links to eachother, because it uses stat(3) (which resolves symlinks) to do this check, it also works with the /dev/fd/ soft links. commit 997bc1dc0db12ee5791bfb74f07c91ce10ed7cfd Author: Luke Shumaker <lukeshu@parabola.nu> Date: Sat Mar 25 12:34:38 2017 -0400 lib/common.sh: add 'lock_close'; use it as appropriate. `lock_close FD` is easier to remember than 'exec FD>&-`; and is especially easier if FD is a variable (though that isn't actually taken advantage of here). This uses Bash 4.1+ `exec {var}>&-`, rather than the clunkier `eval exec "$var>&-"` that was necessary in older versions of Bash. Thanks to Dave Reisner for pointing this new bit of syntax out to me the last time I submitted this (back in 2014, 4.1 had just come out). ----------------------------------------------------------------------- Summary of changes: arch-nspawn.in | 4 +++- archbuild.in | 11 ++++++----- archco.in | 3 ++- archrelease.in | 3 ++- archrm.in | 1 + bash_completion.in | 3 +++ checkpkg.in | 5 +++-- commitpkg.in | 11 ++++++----- crossrepomove.in | 11 ++++++----- find-libdeps.in | 1 + finddeps.in | 1 + lddd.in | 5 +++-- lib/archroot.sh | 3 +++ lib/common.sh | 55 +++++++++++++++++++++++++++++++++++++++++------------- lib/valid-tags.sh | 3 +++ makechrootpkg.in | 24 ++++++++++++------------ mkarchroot.in | 4 +++- rebuildpkgs.in | 20 +++++++++++--------- zsh_completion.in | 1 + 19 files changed, 112 insertions(+), 57 deletions(-) hooks/post-receive -- The official devtools repository