Signed-off-by: Lukas Fleischer --- commitpkg | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/commitpkg b/commitpkg index 9856df1..999c35f 100755 --- a/commitpkg +++ b/commitpkg @@ -78,9 +78,9 @@ case "$repo" in esac # check if all local source files are under version control -for s in ${source[@]}; do - echo $s | grep -Fvq '://' && \ - svn status $s | grep -q '^\?' && \ +for s in "${source[@]}"; do + echo "$s" | grep -Fvq '://' && \ + svn status "$s" | grep -q '^\?' && \ abort "$s is not under version control" done @@ -90,7 +90,7 @@ for i in 'changelog' 'install'; do for file in $filelist; do # evaluate any bash variables used eval file=${file} - if svn status ${file} | grep -q '^\?'; then + if svn status "${file}" | grep -q '^\?'; then abort "${file} is not under version control" fi done -- 1.7.6

In addition to what we had before, this will also detect: * Non-existent files. * Files that are missing or scheduled for deletion. * Ignored files. Signed-off-by: Lukas Fleischer --- commitpkg | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/commitpkg b/commitpkg index 07c28d4..07b0994 100755 --- a/commitpkg +++ b/commitpkg @@ -79,7 +79,7 @@ esac # check if all local source files are under version control for s in "${source[@]}"; do - if [[ $s != *://* ]] && svn status "$s" | grep -q '^\?'; then + if [[ $s != *://* ]] && ! svn status -v "$s" | grep -q '^[ AMRX~]'; then abort "$s is not under version control" fi done @@ -90,7 +90,7 @@ for i in 'changelog' 'install'; do for file in $filelist; do # evaluate any bash variables used eval file=${file} - if svn status "${file}" | grep -q '^\?'; then + if ! svn status -v "${file}" | grep -q '^[ AMRX~]'; then abort "${file} is not under version control" fi done -- 1.7.6