[arch-projects] [DEVTOOLS][PATCH 1/3] archbuild: only use base-devel to new chroot
Since TODO [1] which state:
It would be good for base-devel to install everything needed for a build chroot
we can remove base and sudo
[1] https://www.archlinux.org/todo/add-more-to-base-devel/
Signed-off-by: Sébastien Luttringer
Add option -T to build in a temporary chroot. This apply to any kind of
filesytem and allow to easily parrallelize builds.
This patch also simplify how $default_copy and $copy are defined.
Signed-off-by: Sébastien Luttringer
Am 14.03.2013 03:55, schrieb Sébastien Luttringer:
Add option -T to build in a temporary chroot. This apply to any kind of filesytem and allow to easily parrallelize builds.
This patch also simplify how $default_copy and $copy are defined.
Signed-off-by: Sébastien Luttringer
--- makechrootpkg.in | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) + T) temp_chroot=true; copy+="-$RANDOM" ;;
Maybe use mktemp -d here. Otherwise it's possible to get random number twice. -- Pierre Schmitz, https://pierre-schmitz.com
On Sat, Mar 16, 2013 at 9:45 AM, Pierre Schmitz
Am 14.03.2013 03:55, schrieb Sébastien Luttringer:
Add option -T to build in a temporary chroot. This apply to any kind of filesytem and allow to easily parrallelize builds.
This patch also simplify how $default_copy and $copy are defined.
Signed-off-by: Sébastien Luttringer
--- makechrootpkg.in | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) + T) temp_chroot=true; copy+="-$RANDOM" ;;
Maybe use mktemp -d here. Otherwise it's possible to get random number twice.
As Jan suggested, we can use mktemp with -u get the directory name. It's unsafe too, so it's basically the same as using $RANDOM except the fork. The probability of getting the same number twice is so small and even not an issue (as we still have the lock mechanism). The penalty if a user generate twice the same number, is to wait the first build end before the second start. Cheers, -- Sébastien "Seblu" Luttringer https://www.seblu.net GPG: 0x2072D77A
Move detection of chrootdir type after have check if the directory exists.
This avoid the following messages when -r is not given
stat: cannot read file system information for '': No such file or directory
Signed-off-by: Sébastien Luttringer
Am 14.03.2013 03:55, schrieb Sébastien Luttringer:
Since TODO [1] which state: It would be good for base-devel to install everything needed for a build chroot we can remove base and sudo
sudo is still required by makepkg. -- Pierre Schmitz, https://pierre-schmitz.com
On Sat, Mar 16, 2013 at 9:37 AM, Pierre Schmitz
Am 14.03.2013 03:55, schrieb Sébastien Luttringer:
Since TODO [1] which state: It would be good for base-devel to install everything needed for a build chroot we can remove base and sudo
sudo is still required by makepkg.
yes. This patch is linked to this proposal[1] which add sudo in base-devel to be have everything needed to make a build in a chroot. [1] https://mailman.archlinux.org/pipermail/arch-dev-public/2013-March/024618.ht... [2] https://www.archlinux.org/todo/add-more-to-base-devel/ -- Sébastien "Seblu" Luttringer https://www.seblu.net GPG: 0x2072D77A
Am 16.03.2013 13:48, schrieb Sébastien Luttringer:
On Sat, Mar 16, 2013 at 9:37 AM, Pierre Schmitz
wrote: Am 14.03.2013 03:55, schrieb Sébastien Luttringer:
Since TODO [1] which state: It would be good for base-devel to install everything needed for a build chroot we can remove base and sudo
sudo is still required by makepkg.
yes. This patch is linked to this proposal[1] which add sudo in base-devel to be have everything needed to make a build in a chroot.
[1] https://mailman.archlinux.org/pipermail/arch-dev-public/2013-March/024618.ht... [2] https://www.archlinux.org/todo/add-more-to-base-devel/
OK, I did not really see that mail. I have applied this patch and replaced base,sudo in another place you had missed. We still have to wait for sudo entering core though. Greetings, Pierre -- Pierre Schmitz, https://pierre-schmitz.com
participants (2)
-
Pierre Schmitz
-
Sébastien Luttringer