[arch-projects] [initscripts] [PATCH 0/2] Introduce install_file() and fix add_daemons

older
[arch-projects] [mkinitcpio] [GIT]...

Kurt J. Bosch

26 Jun 2011 26 Jun '11

8 p.m.

Kurt J. Bosch (2): Introduce install_file() for better readability add_daemon: Fix redirection functions | 8 +++++++- rc.shutdown | 2 +- rc.sysinit | 12 ++++++------ 3 files changed, 14 insertions(+), 8 deletions(-)

Show replies by date

Kurt J. Bosch

26 Jun 26 Jun

8 p.m.

New subject: [arch-projects] [initscripts] [PATCH 1/2] Introduce install_file() for better readability

--- functions | 6 ++++++ rc.shutdown | 2 +- rc.sysinit | 12 ++++++------ 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/functions b/functions index ab7928f..9374827 100644 --- a/functions +++ b/functions @@ -422,6 +422,12 @@ mount_all() { stat_done } +install_file() { + local file=$1 content=$2 # remaining args go to install directly + shift 2 + install -T "$@" <(printf '%s' "$content") "$file" +} + bootlogd_stop() { [[ -f /run/bootlogd.pid ]] || return 0 touch /var/log/boot diff --git a/rc.shutdown b/rc.shutdown index d16c66a..e32a19c 100755 --- a/rc.shutdown +++ b/rc.shutdown @@ -21,7 +21,7 @@ kill_everything shutdown stat_busy "Saving Random Seed" RANDOM_SEED=/var/lib/misc/random-seed - install -TDm 0600 <(:) $RANDOM_SEED + install_file "$RANDOM_SEED" "" -m 0600 -D POOL_FILE=/proc/sys/kernel/random/poolsize if [[ -r $POOL_FILE ]]; then read POOL_SIZE < $POOL_FILE diff --git a/rc.sysinit b/rc.sysinit index 2d0fdc1..dcc88f5 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]] && status "Initializing Random Seed" \ - eval 'cat $RANDOM_SEED > /dev/urandom' + install_file /dev/urandom "$(< "$RANDOM_SEED" )" stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.* &>/dev/null @@ -218,18 +218,18 @@ stat_busy "Removing Leftover Files" [[ ! -L /var/run && ! -L /var/run/daemons ]] && rm -rf /var/run/daemons && ln -s /run/daemons /var/run/daemons - install -Tm 0664 -o root -g utmp <(:) /var/run/utmp + install_file /var/run/utmp "" -m 0664 -o root -g utmp # Keep {x,k,g}dm happy with xorg mkdir -m 1777 /tmp/.{X11,ICE}-unix stat_done [[ $HOSTNAME ]] && status "Setting Hostname: $HOSTNAME" \ - eval 'echo "$HOSTNAME" > /proc/sys/kernel/hostname' + install_file /proc/sys/kernel/hostname "$HOSTNAME" # Flush old locale settings and set user defined locale status "Setting Locale: ${LOCALE:=en_US}" \ - eval 'install -Tm 0755 <(echo "export LANG=$LOCALE") /etc/profile.d/locale.sh' + install_file /etc/profile.d/locale.sh "export LANG=$LOCALE"$'\n' -m 0755 if [[ ${LOCALE,,} =~ utf ]]; then stat_busy "Setting Consoles to UTF-8 mode" @@ -261,9 +261,9 @@ set_consolefont stat_busy "Saving dmesg Log" if [[ -e /proc/sys/kernel/dmesg_restrict ]] && (( $(< /proc/sys/kernel/dmesg_restrict) == 1 )); then - install -Tm 0600 <( dmesg ) /var/log/dmesg.log + install_file /var/log/dmesg.log "$( dmesg )" -m 0600 else - install -Tm 0644 <( dmesg ) /var/log/dmesg.log + install_file /var/log/dmesg.log "$( dmesg )" -m 0644 fi (( $? == 0 )) && stat_done || stat_fail -- 1.7.1

Kurt J. Bosch

9:55 p.m.

New subject: [arch-projects] [initscripts] [PATCH] rc.sysinit: Simplify Initializing Random Seed

--- rc.sysinit | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/rc.sysinit b/rc.sysinit index dcc88f5..844383a 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]] && status "Initializing Random Seed" \ - install_file /dev/urandom "$(< "$RANDOM_SEED" )" + install -T "$RANDOM_SEED" /dev/urandom stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.* &>/dev/null -- 1.7.1

Kurt J. Bosch

11:54 p.m.

New subject: [arch-projects] [initscripts] [PATCH] rc.sysinit: Simplify Initializing Random Seed

Kurt J. Bosch, 2011-06-26 21:55:

...

--- rc.sysinit | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rc.sysinit b/rc.sysinit index dcc88f5..844383a 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]]&& status "Initializing Random Seed" \ - install_file /dev/urandom "$(< "$RANDOM_SEED" )" + install -T "$RANDOM_SEED" /dev/urandom

stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.*&>/dev/null

Please ignore this one. -- Kurt

Kurt J. Bosch

11:51 p.m.

New subject: [arch-projects] [initscripts] [PATCH] Fix: don't use install where target file can't/shouldn't be removed

--- functions | 7 +++++++ rc.sysinit | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/functions b/functions index 43414c0..9ad75a9 100644 --- a/functions +++ b/functions @@ -428,6 +428,13 @@ install_file() { install -T "$@" <(printf '%s' "$content") "$file" } +# install would fail because files can't be removed from /proc +# moreover we don't want to remove nodes from /dev +write_file() { + local file=$1 content=$2 + printf '%s' "$content" >| "$file" +} + bootlogd_stop() { [[ -f /run/bootlogd.pid ]] || return 0 touch /var/log/boot diff --git a/rc.sysinit b/rc.sysinit index dcc88f5..2c08f02 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]] && status "Initializing Random Seed" \ - install_file /dev/urandom "$(< "$RANDOM_SEED" )" + cp "$RANDOM_SEED" /dev/urandom stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.* &>/dev/null @@ -225,7 +225,7 @@ stat_done [[ $HOSTNAME ]] && status "Setting Hostname: $HOSTNAME" \ - install_file /proc/sys/kernel/hostname "$HOSTNAME" + write_file /proc/sys/kernel/hostname "$HOSTNAME" # Flush old locale settings and set user defined locale status "Setting Locale: ${LOCALE:=en_US}" \ -- 1.7.1

Seblu

27 Jun 27 Jun

12:28 a.m.

New subject: [arch-projects] [initscripts] [PATCH] Fix: don't use install where target file can't/shouldn't be removed

On Sun, Jun 26, 2011 at 11:51 PM, Kurt J. Bosch wrote:

...

--- functions | 7 +++++++ rc.sysinit | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/functions b/functions index 43414c0..9ad75a9 100644 --- a/functions +++ b/functions @@ -428,6 +428,13 @@ install_file() { install -T "$@" <(printf '%s' "$content") "$file" }

+# install would fail because files can't be removed from /proc +# moreover we don't want to remove nodes from /dev +write_file() { + local file=$1 content=$2 + printf '%s' "$content" >| "$file" +} + bootlogd_stop() { [[ -f /run/bootlogd.pid ]] || return 0 touch /var/log/boot diff --git a/rc.sysinit b/rc.sysinit index dcc88f5..2c08f02 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]] && status "Initializing Random Seed" \ - install_file /dev/urandom "$(< "$RANDOM_SEED" )" + cp "$RANDOM_SEED" /dev/urandom

stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.* &>/dev/null @@ -225,7 +225,7 @@ stat_done

[[ $HOSTNAME ]] && status "Setting Hostname: $HOSTNAME" \ - install_file /proc/sys/kernel/hostname "$HOSTNAME" + write_file /proc/sys/kernel/hostname "$HOSTNAME"

Do you call a function to do the job of a redirection? -- Sébastien Luttringer www.seblu.net

Kurt J. Bosch

12:44 a.m.

New subject: [arch-projects] [initscripts] [PATCH] Fix: don't use install where target file can't/shouldn't be removed

Seblu, 2011-06-27 00:28:

...

On Sun, Jun 26, 2011 at 11:51 PM, Kurt J. Bosch wrote:

...
--- functions | 7 +++++++ rc.sysinit | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/functions b/functions index 43414c0..9ad75a9 100644 --- a/functions +++ b/functions @@ -428,6 +428,13 @@ install_file() { install -T "$@"<(printf '%s' "$content") "$file" }

+# install would fail because files can't be removed from /proc +# moreover we don't want to remove nodes from /dev +write_file() { + local file=$1 content=$2 + printf '%s' "$content">| "$file" +} + bootlogd_stop() { [[ -f /run/bootlogd.pid ]] || return 0 touch /var/log/boot diff --git a/rc.sysinit b/rc.sysinit index dcc88f5..2c08f02 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]]&& status "Initializing Random Seed" \ - install_file /dev/urandom "$(< "$RANDOM_SEED" )" + cp "$RANDOM_SEED" /dev/urandom

stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.*&>/dev/null @@ -225,7 +225,7 @@ stat_done

[[ $HOSTNAME ]]&& status "Setting Hostname: $HOSTNAME" \ - install_file /proc/sys/kernel/hostname "$HOSTNAME" + write_file /proc/sys/kernel/hostname "$HOSTNAME"

Do you call a function to do the job of a redirection?

Yep. We need to do it _within_ status. -- Kurt

Seblu

12:51 a.m.

New subject: [arch-projects] [initscripts] [PATCH] Fix: don't use install where target file can't/shouldn't be removed

On Mon, Jun 27, 2011 at 12:44 AM, Kurt J. Bosch wrote:

...

Seblu, 2011-06-27 00:28:

...
On Sun, Jun 26, 2011 at 11:51 PM, Kurt J. Bosch wrote:

...
--- functions | 7 +++++++ rc.sysinit | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/functions b/functions index 43414c0..9ad75a9 100644 --- a/functions +++ b/functions @@ -428,6 +428,13 @@ install_file() { install -T "$@"<(printf '%s' "$content") "$file" }

+# install would fail because files can't be removed from /proc +# moreover we don't want to remove nodes from /dev +write_file() { + local file=$1 content=$2 + printf '%s' "$content">| "$file" +} + bootlogd_stop() { [[ -f /run/bootlogd.pid ]] || return 0 touch /var/log/boot diff --git a/rc.sysinit b/rc.sysinit index dcc88f5..2c08f02 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]]&& status "Initializing Random Seed" \ - install_file /dev/urandom "$(< "$RANDOM_SEED" )" + cp "$RANDOM_SEED" /dev/urandom

stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.*&>/dev/null @@ -225,7 +225,7 @@ stat_done

[[ $HOSTNAME ]]&& status "Setting Hostname: $HOSTNAME" \ - install_file /proc/sys/kernel/hostname "$HOSTNAME" + write_file /proc/sys/kernel/hostname "$HOSTNAME"

Do you call a function to do the job of a redirection?

Yep. We need to do it _within_ status.

Reading (or not) your commit message I thought you wanted to do that. What do you think about doing you eval inside status? Or better, just rollback from your previous patch where you assert this write can be done in one line with status instead of a classic status_start / status_done? In this case, the use of status is not the best choice I think. -- Sébastien Luttringer www.seblu.net

Kurt J. Bosch

11:27 a.m.

New subject: [arch-projects] [initscripts] [PATCH] Fix: don't use install where target file can't/shouldn't be removed

Seblu, 2011-06-27 00:51:

...

On Mon, Jun 27, 2011 at 12:44 AM, Kurt J. Bosch wrote:

...
Seblu, 2011-06-27 00:28:

...
On Sun, Jun 26, 2011 at 11:51 PM, Kurt J. Bosch wrote:

...
--- functions | 7 +++++++ rc.sysinit | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/functions b/functions index 43414c0..9ad75a9 100644 --- a/functions +++ b/functions @@ -428,6 +428,13 @@ install_file() { install -T "$@"<(printf '%s' "$content") "$file" }

+# install would fail because files can't be removed from /proc +# moreover we don't want to remove nodes from /dev +write_file() { + local file=$1 content=$2 + printf '%s' "$content">| "$file" +} + bootlogd_stop() { [[ -f /run/bootlogd.pid ]] || return 0 touch /var/log/boot diff --git a/rc.sysinit b/rc.sysinit index dcc88f5..2c08f02 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]]&& status "Initializing Random Seed" \ - install_file /dev/urandom "$(< "$RANDOM_SEED" )" + cp "$RANDOM_SEED" /dev/urandom

stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.*&>/dev/null @@ -225,7 +225,7 @@ stat_done

[[ $HOSTNAME ]]&& status "Setting Hostname: $HOSTNAME" \ - install_file /proc/sys/kernel/hostname "$HOSTNAME" + write_file /proc/sys/kernel/hostname "$HOSTNAME"

Do you call a function to do the job of a redirection?

Yep. We need to do it _within_ status.

Reading (or not) your commit message I thought you wanted to do that. What do you think about doing you eval inside status?

Would be rather difficult because eval does word splitting.

...

Or better, just rollback from your previous patch where you assert this write can be done in one line with status instead of a classic status_start / status_done? In this case, the use of status is not the best choice I think.

Using status + write_file is better in this case IMHO for some reasons: * It provides DONE/FAIL handling. * We avoid the common pitfall of changing the from stat_busy/stat_done to the non working status with redirection later as happened for "Initializing Random Seed" two moths ago without beeing fixed until now. http://projects.archlinux.org/initscripts.git/commit/?id=1de599669a643f82ec0... (Would be fixed by "[PATCH] rc.sysinit: Fix Initializing Random Seed") -- Kurt

Seblu

8:40 p.m.

New subject: [arch-projects] [initscripts] [PATCH] Fix: don't use install where target file can't/shouldn't be removed

On Mon, Jun 27, 2011 at 11:27 AM, Kurt J. Bosch wrote:

...

Seblu, 2011-06-27 00:51:

...
On Mon, Jun 27, 2011 at 12:44 AM, Kurt J. Bosch wrote:

...
Seblu, 2011-06-27 00:28:

...
On Sun, Jun 26, 2011 at 11:51 PM, Kurt J. Bosch wrote:

...
--- functions | 7 +++++++ rc.sysinit | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/functions b/functions index 43414c0..9ad75a9 100644 --- a/functions +++ b/functions @@ -428,6 +428,13 @@ install_file() { install -T "$@"<(printf '%s' "$content") "$file" }

+# install would fail because files can't be removed from /proc +# moreover we don't want to remove nodes from /dev +write_file() { + local file=$1 content=$2 + printf '%s' "$content">| "$file" +} + bootlogd_stop() { [[ -f /run/bootlogd.pid ]] || return 0 touch /var/log/boot diff --git a/rc.sysinit b/rc.sysinit index dcc88f5..2c08f02 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]]&& status "Initializing Random Seed" \ - install_file /dev/urandom "$(< "$RANDOM_SEED" )" + cp "$RANDOM_SEED" /dev/urandom

stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.*&>/dev/null @@ -225,7 +225,7 @@ stat_done

[[ $HOSTNAME ]]&& status "Setting Hostname: $HOSTNAME" \ - install_file /proc/sys/kernel/hostname "$HOSTNAME" + write_file /proc/sys/kernel/hostname "$HOSTNAME"

Do you call a function to do the job of a redirection?

Yep. We need to do it _within_ status.

Reading (or not) your commit message I thought you wanted to do that. What do you think about doing you eval inside status?

Would be rather difficult because eval does word splitting. It was a joke, using eval should be avoided.

...

...
Or better, just rollback from your previous patch where you assert this write can be done in one line with status instead of a classic status_start / status_done? In this case, the use of status is not the best choice I think.

Using status + write_file is better in this case IMHO for some reasons: * It provides DONE/FAIL handling.

Nothing more than calling those 2 lines ? start_busy "Setting Hostname: $HOSTNAME" echo $HOSTNAME > /proc/sys/kernel/hostname && stat_done || stat_fail or in one line start_busy "Setting Hostname: $HOSTNAME"; echo $HOSTNAME > /proc/sys/kernel/hostname && stat_done || stat_fail

...

* We avoid the common pitfall of changing the from stat_busy/stat_done to the non working status with redirection later as happened for "Initializing Random Seed" two moths ago without beeing fixed until now. Thos doesn't avoid bad using of status... this just fix a bad status using by creating a function to write a file.

I see status as an helper for simple cases of stat_*. Here bash syntax doesn't allow it. Doesn't forget that initscripts syntax must be easily readable (i tell this about all your patchs, not only this one) -- Sébastien Luttringer www.seblu.net

Kurt J. Bosch

11:36 p.m.

New subject: [arch-projects] [initscripts] [PATCH] Fix: don't use install where target file can't/shouldn't be removed

Seblu, 2011-06-27 20:40:

...

On Mon, Jun 27, 2011 at 11:27 AM, Kurt J. Bosch wrote:

...
Seblu, 2011-06-27 00:51:

...
On Mon, Jun 27, 2011 at 12:44 AM, Kurt J. Bosch wrote:

...
Seblu, 2011-06-27 00:28:

...
On Sun, Jun 26, 2011 at 11:51 PM, Kurt J. Bosch wrote:

...
--- functions | 7 +++++++ rc.sysinit | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/functions b/functions index 43414c0..9ad75a9 100644 --- a/functions +++ b/functions @@ -428,6 +428,13 @@ install_file() { install -T "$@"<(printf '%s' "$content") "$file" }

+# install would fail because files can't be removed from /proc +# moreover we don't want to remove nodes from /dev +write_file() { + local file=$1 content=$2 + printf '%s' "$content">| "$file" +} + bootlogd_stop() { [[ -f /run/bootlogd.pid ]] || return 0 touch /var/log/boot diff --git a/rc.sysinit b/rc.sysinit index dcc88f5..2c08f02 100755 --- a/rc.sysinit +++ b/rc.sysinit @@ -209,7 +209,7 @@ status "Activating Swap" swapon -a RANDOM_SEED=/var/lib/misc/random-seed [[ -f $RANDOM_SEED ]]&& status "Initializing Random Seed" \ - install_file /dev/urandom "$(< "$RANDOM_SEED" )" + cp "$RANDOM_SEED" /dev/urandom

stat_busy "Removing Leftover Files" rm -rf /etc/{nologin,shutdownpid} /forcefsck /tmp/* /tmp/.*&>/dev/null @@ -225,7 +225,7 @@ stat_done

[[ $HOSTNAME ]]&& status "Setting Hostname: $HOSTNAME" \ - install_file /proc/sys/kernel/hostname "$HOSTNAME" + write_file /proc/sys/kernel/hostname "$HOSTNAME"

Do you call a function to do the job of a redirection?

Yep. We need to do it _within_ status.

Reading (or not) your commit message I thought you wanted to do that. What do you think about doing you eval inside status?

Would be rather difficult because eval does word splitting. It was a joke, using eval should be avoided.

...
...
Or better, just rollback from your previous patch where you assert this write can be done in one line with status instead of a classic status_start / status_done? In this case, the use of status is not the best choice I think.

Using status + write_file is better in this case IMHO for some reasons: * It provides DONE/FAIL handling.

Nothing more than calling those 2 lines ?

start_busy "Setting Hostname: $HOSTNAME" echo $HOSTNAME> /proc/sys/kernel/hostname&& stat_done || stat_fail

or in one line

start_busy "Setting Hostname: $HOSTNAME"; echo $HOSTNAME> /proc/sys/kernel/hostname&& stat_done || stat_fail

...
* We avoid the common pitfall of changing the from stat_busy/stat_done to the non working status with redirection later as happened for "Initializing Random Seed" two moths ago without beeing fixed until now. Thos doesn't avoid bad using of status... this just fix a bad status using by creating a function to write a file.

I see status as an helper for simple cases of stat_*. Here bash syntax doesn't allow it.

Doesn't forget that initscripts syntax must be easily readable (i tell this about all your patchs, not only this one)

OK, OK, OK, giving up. Fixed this in the rebased patches. -- Kurt

Kurt J. Bosch

26 Jun 26 Jun

8 p.m.

New subject: [arch-projects] [initscripts] [PATCH 2/2] add_daemon: Fix redirection

--- functions | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/functions b/functions index 9374827..43414c0 100644 --- a/functions +++ b/functions @@ -178,7 +178,7 @@ in_array() { add_daemon() { [[ -d /run/daemons ]] || /bin/mkdir -p /run/daemons - > /run/daemons/"$1" + >| /run/daemons/"$1" } rm_daemon() { -- 1.7.1

Seblu

9:24 p.m.

New subject: [arch-projects] [initscripts] [PATCH 2/2] add_daemon: Fix redirection

On Sun, Jun 26, 2011 at 8:00 PM, Kurt J. Bosch wrote:

...

--- functions | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/functions b/functions index 9374827..43414c0 100644 --- a/functions +++ b/functions @@ -178,7 +178,7 @@ in_array() {

add_daemon() { [[ -d /run/daemons ]] || /bin/mkdir -p /run/daemons - > /run/daemons/"$1" + >| /run/daemons/"$1" }

rm_daemon() { -- 1.7.1

Why you "never" make a message about your commit which explain why you choose to do this? I don't see why adding a clubber will fix something. Regards, -- Sébastien Luttringer www.seblu.net

Kurt J. Bosch

9:51 p.m.

New subject: [arch-projects] [initscripts] [PATCH 2/2] add_daemon: Fix redirection

Seblu, 2011-06-26 21:24:

...

On Sun, Jun 26, 2011 at 8:00 PM, Kurt J. Bosch wrote:

...
--- functions | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/functions b/functions index 9374827..43414c0 100644 --- a/functions +++ b/functions @@ -178,7 +178,7 @@ in_array() {

add_daemon() { [[ -d /run/daemons ]] || /bin/mkdir -p /run/daemons -> /run/daemons/"$1" +>| /run/daemons/"$1" }

rm_daemon() { -- 1.7.1

Why you "never" make a message about your commit which explain why you choose to do this? I don't see why adding a clubber will fix something.

Regards,

At least it fixes consistency. -- Kurt

Seblu

10:45 p.m.

New subject: [arch-projects] [initscripts] [PATCH 2/2] add_daemon: Fix redirection

On Sun, Jun 26, 2011 at 9:51 PM, Kurt J. Bosch wrote:

...

Seblu, 2011-06-26 21:24:

...
On Sun, Jun 26, 2011 at 8:00 PM, Kurt J. Bosch wrote:

...
--- functions | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/functions b/functions index 9374827..43414c0 100644 --- a/functions +++ b/functions @@ -178,7 +178,7 @@ in_array() {

add_daemon() { [[ -d /run/daemons ]] || /bin/mkdir -p /run/daemons -> /run/daemons/"$1" +>| /run/daemons/"$1" }

rm_daemon() { -- 1.7.1

Why you "never" make a message about your commit which explain why you choose to do this? I don't see why adding a clubber will fix something.

Regards,

At least it fixes consistency.

In this cases, this patch is incomplete and it could be done in others place in scripts. -- Sébastien Luttringer www.seblu.net

4693

Age (days ago)

4694

Last active (days ago)

List overview

Download

14 comments

2 participants

participants (2)

Kurt J. Bosch
Seblu