[arch-projects] [initscripts][PATCH] arch-sysctl: suppress errors about unknown

newer
[arch-projects] [devtools][PATCH]...

older
[arch-projects] [mkinitcpio] [GIT]...

lolilolicon

13 Dec 2011 13 Dec '11

4:52 p.m.

The errors about unknown keys in boot messages are harmless, but annoying. Some keys may become unknown when some modules are disabled, yet the user may want to keep the sysctl.conf entries so they can take effect when the modules are subsequently (re)enabled. One example is the IPv6 module and the net.ipv6.conf.all.use_tempaddr key. Signed-off-by: lolilolicon --- arch-sysctl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch-sysctl b/arch-sysctl index 4856df6..028fba7 100755 --- a/arch-sysctl +++ b/arch-sysctl @@ -23,7 +23,7 @@ for path in "${sysctl_d[@]}"; do done for path in "${fragments[@]}"; do - sysctl -q -p "$path" + sysctl -e -q -p "$path" done # vim: set ts=2 sw=2 noet: -- 1.7.8

Show replies by date

lolilolicon

13 Dec 13 Dec

4:55 p.m.

New subject: [arch-projects] [initscripts][PATCH] arch-sysctl: suppress errors about unknown keys

Tom Gundersen

6:26 p.m.

New subject: [arch-projects] [initscripts][PATCH] arch-sysctl: suppress errors about unknown keys

On Tue, Dec 13, 2011 at 5:55 PM, lolilolicon wrote:

...

The errors about unknown keys in boot messages are harmless, but annoying. Some keys may become unknown when some modules are disabled, yet the user may want to keep the sysctl.conf entries so they can take effect when the modules are subsequently (re)enabled. One example is the IPv6 module and the net.ipv6.conf.all.use_tempaddr key.

Thanks for the patch. However, I don't think this is what we want. As a general rule we don't hide any error/warning messages from the user. It might be that the user does not care, but it might also be that s/he misspelled the name of the key, or that there is some other error where action needs to be taken. Alternatively, you could keep all your ipv6 (or whatever) settings in a separate file in /etc/sysctl.d/ipv6.conf, and rename it to ipv6.conf.backup when you don't want them to be used...

...

Signed-off-by: lolilolicon

Signed-off-by without your real name doesn't really mean anything btw... Cheers, Tom

lolilolicon

7:09 p.m.

New subject: [arch-projects] [initscripts][PATCH] arch-sysctl: suppress errors about unknown keys

On Wed, Dec 14, 2011 at 2:26 AM, Tom Gundersen wrote:

...

On Tue, Dec 13, 2011 at 5:55 PM, lolilolicon wrote:

...
The errors about unknown keys in boot messages are harmless, but annoying. Some keys may become unknown when some modules are disabled, yet the user may want to keep the sysctl.conf entries so they can take effect when the modules are subsequently (re)enabled. One example is the IPv6 module and the net.ipv6.conf.all.use_tempaddr key.

Thanks for the patch. However, I don't think this is what we want. As a general rule we don't hide any error/warning messages from the user. It might be that the user does not care, but it might also be that s/he misspelled the name of the key, or that there is some other error where action needs to be taken.

According to sysctl(8), the -e option is used to "ignore errors about unknown keys", so no "other error" would be hidden by it. It's a good thing if we can report error on misspelled keys, but only if we don't report the same errors when the keys are just unknown due to disabled modules. Currently I have IPv6 disabled, so I get in boot messages: error: "net.ipv6.conf.all.use_tempaddr" is an unknown key error: "net.ipv6.conf.default.use_tempaddr" is an unknown key Now if I consistently get these errors, it would be very likely for me to ignore some other real errors, like misspelling: error: "net.ipv9.conf.default.use_tempaddr" is an unknown key BTW, pre arch-sysctl, it used to be `sysctl -q -p &>/dev/null`, which really hides *all* errors; in contrast, The -e option sounds far more reasonable...

...

Alternatively, you could keep all your ipv6 (or whatever) settings in a separate file in /etc/sysctl.d/ipv6.conf, and rename it to ipv6.conf.backup when you don't want them to be used...

No, I'm afraid I would then misspell the filename when I rename it back ;) Seriously, I don't think anyone would choose to do so; it's unnecessary hassle.

...

...
Signed-off-by: lolilolicon

Signed-off-by without your real name doesn't really mean anything btw...

This is the name I go by in the Arch community, a pretty honest fake name that you can trust. If you prefer, I will get rid of the Signed-off-by :)

...

Cheers,

Tom

Tom Gundersen

7:48 p.m.

New subject: [arch-projects] [initscripts][PATCH] arch-sysctl: suppress errors about unknown keys

On Tue, Dec 13, 2011 at 8:09 PM, lolilolicon wrote:

...

On Wed, Dec 14, 2011 at 2:26 AM, Tom Gundersen wrote:

...
Thanks for the patch. However, I don't think this is what we want. As a general rule we don't hide any error/warning messages from the user. It might be that the user does not care, but it might also be that s/he misspelled the name of the key, or that there is some other error where action needs to be taken.

According to sysctl(8), the -e option is used to "ignore errors about unknown keys", so no "other error" would be hidden by it.

Many reasons for "unknown keys", maybe the module is no longer installed (by mistake), or it failed loading, or, ....

...

It's a good thing if we can report error on misspelled keys, but only if we don't report the same errors when the keys are just unknown due to disabled modules.

I can't imagine how that could be done...

...

Currently I have IPv6 disabled, so I get in boot messages:

error: "net.ipv6.conf.all.use_tempaddr" is an unknown key error: "net.ipv6.conf.default.use_tempaddr" is an unknown key

To me it makes most sense to disable the sysctl entries if you disable the modules, anything else should give errors.

...

Now if I consistently get these errors, it would be very likely for me to ignore some other real errors, like misspelling:

error: "net.ipv9.conf.default.use_tempaddr" is an unknown key

With your patch this error would be ignored anyway...

...

BTW, pre arch-sysctl, it used to be `sysctl -q -p &>/dev/null`, which really hides *all* errors;

Yeah, we are slowly moving away from ignoring errors wherever we can.

...

in contrast, The -e option sounds far more reasonable...

Sure, but it still risks ignoring some real errors, which is worse than being annoying.

...

...
...
Signed-off-by: lolilolicon

Signed-off-by without your real name doesn't really mean anything btw...

This is the name I go by in the Arch community, a pretty honest fake name that you can trust. If you prefer, I will get rid of the Signed-off-by :)

As you wish, we are not strict on these things. -t

lolilolicon

8:44 p.m.

New subject: [arch-projects] [initscripts][PATCH] arch-sysctl: suppress errors about unknown keys

On Wed, Dec 14, 2011 at 3:48 AM, Tom Gundersen wrote:

...

On Tue, Dec 13, 2011 at 8:09 PM, lolilolicon wrote:

...
According to sysctl(8), the -e option is used to "ignore errors about unknown keys", so no "other error" would be hidden by it.

Many reasons for "unknown keys", maybe the module is no longer installed (by mistake), or it failed loading, or, ....

But in case of those failures, one shouldn't expect to look for errors in the sysctl error messages in the first place. Those error messages should be supplementary at best.

...

...
It's a good thing if we can report error on misspelled keys, but only if we don't report the same errors when the keys are just unknown due to disabled modules.

I can't imagine how that could be done...

...
Currently I have IPv6 disabled, so I get in boot messages:

error: "net.ipv6.conf.all.use_tempaddr" is an unknown key error: "net.ipv6.conf.default.use_tempaddr" is an unknown key

To me it makes most sense to disable the sysctl entries if you disable the modules, anything else should give errors.

To me, the sysctl entries are to the modules what configuration files are to e.g. daemons -- you don't comment/rename configs if you disable daemons in rc.conf.

...

...
Now if I consistently get these errors, it would be very likely for me to ignore some other real errors, like misspelling:

error: "net.ipv9.conf.default.use_tempaddr" is an unknown key

With your patch this error would be ignored anyway...

Yes, but if in either case it will be ignored, better just not print it :P My point is that if one gets used to the net.ipv6.* key errors, other real errors would more likely be ignored; if instead, we suppress the non-critical unknown key errors, the other real errors will stand out.

...

...
BTW, pre arch-sysctl, it used to be `sysctl -q -p &>/dev/null`, which really hides *all* errors;

Yeah, we are slowly moving away from ignoring errors wherever we can.

I can understand the intent.

...

...
in contrast, The -e option sounds far more reasonable...

Sure, but it still risks ignoring some real errors, which is worse than being annoying.

I still think in reality -e is pretty safe; I wonder what the original intent for the -e option. Well, I think I've made my points. Comparing options, I would add the -e to my copy of arch-sysctl, if unfortunately we couldn't agree on this matter. Cheers

C Anthony Risinger

14 Dec 14 Dec

12:23 a.m.

New subject: [arch-projects] [initscripts][PATCH] arch-sysctl: suppress errors about unknown keys

On Tue, Dec 13, 2011 at 2:44 PM, lolilolicon wrote:

...

On Wed, Dec 14, 2011 at 3:48 AM, Tom Gundersen wrote:

...
On Tue, Dec 13, 2011 at 8:09 PM, lolilolicon wrote:

...
According to sysctl(8), the -e option is used to "ignore errors about unknown keys", so no "other error" would be hidden by it.

Many reasons for "unknown keys", maybe the module is no longer installed (by mistake), or it failed loading, or, ....

But in case of those failures, one shouldn't expect to look for errors in the sysctl error messages in the first place. Those error messages should be supplementary at best.

...
...
It's a good thing if we can report error on misspelled keys, but only if we don't report the same errors when the keys are just unknown due to disabled modules.

I can't imagine how that could be done...

...
Currently I have IPv6 disabled, so I get in boot messages:

error: "net.ipv6.conf.all.use_tempaddr" is an unknown key error: "net.ipv6.conf.default.use_tempaddr" is an unknown key

To me it makes most sense to disable the sysctl entries if you disable the modules, anything else should give errors.

To me, the sysctl entries are to the modules what configuration files are to e.g. daemons -- you don't comment/rename configs if you disable daemons in rc.conf.

...
...
Now if I consistently get these errors, it would be very likely for me to ignore some other real errors, like misspelling:

error: "net.ipv9.conf.default.use_tempaddr" is an unknown key

With your patch this error would be ignored anyway...

Yes, but if in either case it will be ignored, better just not print it :P My point is that if one gets used to the net.ipv6.* key errors, other real errors would more likely be ignored; if instead, we suppress the non-critical unknown key errors, the other real errors will stand out.

...
...
BTW, pre arch-sysctl, it used to be `sysctl -q -p &>/dev/null`, which really hides *all* errors;

Yeah, we are slowly moving away from ignoring errors wherever we can.

I can understand the intent.

...
...
in contrast, The -e option sounds far more reasonable...

Sure, but it still risks ignoring some real errors, which is worse than being annoying.

I still think in reality -e is pretty safe; I wonder what the original intent for the -e option.

Well, I think I've made my points. Comparing options, I would add the -e to my copy of arch-sysctl, if unfortunately we couldn't agree on this matter.

i don't know how beneficial it is to worry about disabled daemons, or much else related to sysctl ... because imo the whole thing is busted/outdated, even sysctl.d as implemented by systemd. in `/etc/rc.multi`, `arch-sysctl` is called *before* any daemons are started, so anything added to /proc after that will not be affected anyway (eg. any modules loaded by daemons et al). the sad truth is sysctl is not hot-plug friendly at all AFAIK, and only sysfs attributes (/sys) can be [cleanly] modified by udev rules ... i know this because i have a desire to disable bridge firewalling on many of my setups, a /proc/net entry, but the hierarchy doesn't exist until the bridge modules are loaded ... which, unless explicitly requested, will almost certainly happen after sysctl stuff has fired. -- C Anthony

Seblu

17 Dec 17 Dec

4:24 p.m.

New subject: [arch-projects] [initscripts][PATCH] arch-sysctl: suppress errors about unknown keys

On Wed, Dec 14, 2011 at 1:23 AM, C Anthony Risinger wrote:

...

On Tue, Dec 13, 2011 at 2:44 PM, lolilolicon wrote:

...
On Wed, Dec 14, 2011 at 3:48 AM, Tom Gundersen wrote:

...
On Tue, Dec 13, 2011 at 8:09 PM, lolilolicon wrote:

...
According to sysctl(8), the -e option is used to "ignore errors about unknown keys", so no "other error" would be hidden by it.

Many reasons for "unknown keys", maybe the module is no longer installed (by mistake), or it failed loading, or, ....

But in case of those failures, one shouldn't expect to look for errors in the sysctl error messages in the first place. Those error messages should be supplementary at best.

...
...
It's a good thing if we can report error on misspelled keys, but only if we don't report the same errors when the keys are just unknown due to disabled modules.

I can't imagine how that could be done...

...
Currently I have IPv6 disabled, so I get in boot messages:

error: "net.ipv6.conf.all.use_tempaddr" is an unknown key error: "net.ipv6.conf.default.use_tempaddr" is an unknown key

To me it makes most sense to disable the sysctl entries if you disable the modules, anything else should give errors.

To me, the sysctl entries are to the modules what configuration files are to e.g. daemons -- you don't comment/rename configs if you disable daemons in rc.conf.

...
...
Now if I consistently get these errors, it would be very likely for me to ignore some other real errors, like misspelling:

error: "net.ipv9.conf.default.use_tempaddr" is an unknown key

With your patch this error would be ignored anyway...

Yes, but if in either case it will be ignored, better just not print it :P My point is that if one gets used to the net.ipv6.* key errors, other real errors would more likely be ignored; if instead, we suppress the non-critical unknown key errors, the other real errors will stand out.

...
...
BTW, pre arch-sysctl, it used to be `sysctl -q -p &>/dev/null`, which really hides *all* errors;

Yeah, we are slowly moving away from ignoring errors wherever we can.

I can understand the intent.

...
...
in contrast, The -e option sounds far more reasonable...

Sure, but it still risks ignoring some real errors, which is worse than being annoying.

I still think in reality -e is pretty safe; I wonder what the original intent for the -e option.

Well, I think I've made my points. Comparing options, I would add the -e to my copy of arch-sysctl, if unfortunately we couldn't agree on this matter.

i don't know how beneficial it is to worry about disabled daemons, or much else related to sysctl ... because imo the whole thing is busted/outdated, even sysctl.d as implemented by systemd. in `/etc/rc.multi`, `arch-sysctl` is called *before* any daemons are started, so anything added to /proc after that will not be affected anyway (eg. any modules loaded by daemons et al).

the sad truth is sysctl is not hot-plug friendly at all AFAIK, and only sysfs attributes (/sys) can be [cleanly] modified by udev rules ...

i know this because i have a desire to disable bridge firewalling on many of my setups, a /proc/net entry, but the hierarchy doesn't exist until the bridge modules are loaded ... which, unless explicitly requested, will almost certainly happen after sysctl stuff has fired.

Yes, sysctl loading is not hotplug ready... I am rather in the opinion of Tom, we do not have to hide errors. Maybe your patch would be more friendly if you check if quiet parameter is given during boot? -- Sébastien Luttringer www.seblu.net

4513

Age (days ago)

4517

Last active (days ago)

List overview

Download

7 comments

4 participants

participants (4)

C Anthony Risinger
lolilolicon
Seblu
Tom Gundersen