[arch-projects] [initscripts][PATCH] rc: exit with error count, not error sum

older
[arch-projects] Patch for FS#23889

Dave Reisner

24 Apr 2011 24 Apr '11

11:42 p.m.

cc199761f assumes that /etc/rc.d scripts will exit with a value of 0 or 1. Since this can't be guaranteed, clamp the return value to 0 or 1 before adding it to the exit value. --- rc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/rc b/rc index 1e64119..54dc11c 100755 --- a/rc +++ b/rc @@ -45,7 +45,7 @@ case $1 in shift for i; do [[ -x "/etc/rc.d/$i" ]] && "/etc/rc.d/$i" $action - (( ret += $? )) + (( ret += !! $? )) # clamp exit value to 0/1 done esac -- 1.7.4.4

Show replies by date

Tom Gundersen

24 Apr 24 Apr

11:57 p.m.

New subject: [arch-projects] [initscripts][PATCH] rc: exit with error count, not error sum

On Sun, Apr 24, 2011 at 11:42 PM, Dave Reisner wrote:

...

cc199761f assumes that /etc/rc.d scripts will exit with a value of 0 or 1. Since this can't be guaranteed, clamp the return value to 0 or 1 before adding it to the exit value.

Do you have a public repo I could pull from? (GMail always messes up the patches, even if I ask for the original message). -t

Dave Reisner

25 Apr 25 Apr

12:09 a.m.

New subject: [arch-projects] [initscripts][PATCH] rc: exit with error count, not error sum

On Sun, Apr 24, 2011 at 11:57:59PM +0200, Tom Gundersen wrote:

...

On Sun, Apr 24, 2011 at 11:42 PM, Dave Reisner wrote:

...
cc199761f assumes that /etc/rc.d scripts will exit with a value of 0 or 1. Since this can't be guaranteed, clamp the return value to 0 or 1 before adding it to the exit value.

Do you have a public repo I could pull from? (GMail always messes up the patches, even if I ask for the original message).

-t

Surely. I'll start using my working branch on Github again. d

Tom Gundersen

30 Apr 30 Apr

9:12 p.m.

New subject: [arch-projects] [initscripts][PATCH] rc: exit with error count, not error sum

On Mon, Apr 25, 2011 at 12:09 AM, Dave Reisner wrote:

...

Surely. I'll start using my working branch on Github again.

Thanks for this! I pulled your patch from there (the iproute2 stuff looks promising!). Cheers, -t

Seblu

25 Apr 25 Apr

12:07 a.m.

New subject: [arch-projects] [initscripts][PATCH] rc: exit with error count, not error sum

On Sun, Apr 24, 2011 at 11:42 PM, Dave Reisner wrote:

...

cc199761f assumes that /etc/rc.d scripts will exit with a value of 0 or 1. Since this can't be guaranteed, clamp the return value to 0 or 1 before adding it to the exit value. --- rc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rc b/rc index 1e64119..54dc11c 100755 --- a/rc +++ b/rc @@ -45,7 +45,7 @@ case $1 in shift for i; do [[ -x "/etc/rc.d/$i" ]] && "/etc/rc.d/$i" $action - (( ret += $? )) + (( ret += !! $? )) # clamp exit value to 0/1 done

why doen't increment ret each time a non zero value is detected? This is simpler no? (($?)) || ((ret++) ? -- Sébastien Luttringer www.seblu.net

Dave Reisner

12:28 a.m.

New subject: [arch-projects] [initscripts][PATCH] rc: exit with error count, not error sum

On Mon, Apr 25, 2011 at 12:07:07AM +0200, Seblu wrote:

...

On Sun, Apr 24, 2011 at 11:42 PM, Dave Reisner wrote:

...
cc199761f assumes that /etc/rc.d scripts will exit with a value of 0 or 1. Since this can't be guaranteed, clamp the return value to 0 or 1 before adding it to the exit value. --- rc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/rc b/rc index 1e64119..54dc11c 100755 --- a/rc +++ b/rc @@ -45,7 +45,7 @@ case $1 in shift for i; do [[ -x "/etc/rc.d/$i" ]] && "/etc/rc.d/$i" $action - (( ret += $? )) + (( ret += !! $? )) # clamp exit value to 0/1 done

why doen't increment ret each time a non zero value is detected? This is simpler no?

(($?)) || ((ret++) ?

Well, it'd be && instead of ||, but this is the first thing that came to mine (using an old C idiom). It's 6 of one, a half dozen of another. Also, I just noticed that this increments the exit value when the [[ -x check fails, but I think I'm okay with that. d

4744

Age (days ago)

4750

Last active (days ago)

List overview

Download

5 comments

3 participants

participants (3)

Dave Reisner
Seblu
Tom Gundersen