On Mon, 29 Aug 2011 11:46:49 -0300 Gerardo Exequiel Pozzi <vmlinuz386@yahoo.com.ar> wrote:
On 08/29/2011 10:25 AM, Dieter Plaetinck wrote:
Imho "Update extrapkgs for transition to libisoburn in archiso" and "Remove unused packages" should be separate commits. Even more, can you explain why each removed package is no longer needed? maybe put that in the commit message as well.
Dieter
To avoid git pollution like you said some times, but seems that here is not applicable.
All I want is that each commit represents a (one) logical change. Sometimes that means squashing several changes together if they belong to the same logical change, yielding a big commit, sometimes it means splitting up a small commit into two ever smaller ones if the changes are unrelated (like this case).
syslinux was used for isohybrid cdrkit was used for mkisofs mkinitcpio-nfs-utils was used for older mkinitcpio that -b does not work propertly, needed for archiso_pxe_nbd nbd was used for older mkinitcpio that -b does not work propertly, needed for archiso_pxe_nbd pwgen was used by mkarchiso/Makefile in ages were iso label was ARCH_ramdomchars (about two years ago)
thanks, now I understand. please put this also in the commit message. Of course, if packages were removed because they are no longer needed with the new libisoburn method, they should also go in the "Update extrapkgs for transition to libisoburn in archiso" commit (cdrkit). All removals of unused packages (with the exception of packages being removed because of the switch to libisoburn) can than be in a separate commit. Btw we still use isohybrid right? Than why is syslinux removed? Dieter